diff --git a/.changeset/steady-outline-marker.md b/.changeset/steady-outline-marker.md new file mode 100644 index 000000000..90154b4a1 --- /dev/null +++ b/.changeset/steady-outline-marker.md @@ -0,0 +1,5 @@ +--- +type: Fixed +pr: 4125 +--- +**`/gsd-plan-phase --chunked`'s outline resume-check no longer has a syntax error** — the `### 8.5.1 Outline Phase` step's resume-detection block had an empty `then` clause (only a comment, no command), which is invalid under both bash and zsh if executed literally. (#4113) diff --git a/gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md b/gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md index f9bedc439..163a7ed1f 100644 --- a/gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md +++ b/gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md @@ -17,7 +17,7 @@ the `## OUTLINE COMPLETE` marker (written by the outline agent — #2762), skip ```bash OUTLINE_FILE="${PHASE_DIR}/${PADDED_PHASE}-PLAN-OUTLINE.md" if [[ -f "$OUTLINE_FILE" ]] && grep -q "^## OUTLINE COMPLETE" "$OUTLINE_FILE"; then - # reuse existing outline — skip to 8.5.2 + : # reuse existing outline — skip to 8.5.2 fi ``` @@ -67,7 +67,7 @@ For each plan entry extracted from `PLAN-OUTLINE.md`: ```bash PLAN_FILE="${PHASE_DIR}/${plan_id}-PLAN.md" if [[ -f "$PLAN_FILE" ]] && head -1 "$PLAN_FILE" | grep -q '^---' && [[ "$ARGUMENTS" != *"--reviews"* ]]; then - continue # resume safety — NOT under --reviews (replan) + : # resume safety — skip this plan, continue to next plan entry — NOT under --reviews (replan) fi ``` diff --git a/scripts/lint-workflow-shellcheck-baseline.json b/scripts/lint-workflow-shellcheck-baseline.json index bd0fb65c3..778dbeb4d 100644 --- a/scripts/lint-workflow-shellcheck-baseline.json +++ b/scripts/lint-workflow-shellcheck-baseline.json @@ -629,31 +629,6 @@ "code": "2235", "message": "Use { ..; } instead of (..) to avoid subshell overhead." }, - { - "file": "gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md", - "code": "1009", - "message": "The mentioned syntax error was in this if expression." - }, - { - "file": "gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md", - "code": "1048", - "message": "Can't have empty then clauses (use 'true' as a no-op)." - }, - { - "file": "gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md", - "code": "1072", - "message": "Unexpected keyword/token. Fix any mentioned problems and try again." - }, - { - "file": "gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md", - "code": "1073", - "message": "Couldn't parse this then clause. Fix to allow more checks." - }, - { - "file": "gsd-core/workflows/plan-phase/steps/chunked-planning-mode.md", - "code": "2105", - "message": "continue is only valid in loops." - }, { "file": "gsd-core/workflows/plan-phase/steps/stall-detection-helpers.md", "code": "2086",