golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "Merge pull request #3578 from gsd-build/fix/3569-init-plan-phase-status"

Browse Source 
This reverts commit a244dd7fc3, reversing
changes made to 8f95b2fe23.
This commit is contained in:
Tom Boucher
2026-05-15 15:16:55 -04:00
parent a244dd7fc3
commit 05d4ba8147
6 changed files with 2 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/src/query/init.ts
View File

@@ -28,7 +28,6 @@ import { resolveModel, MODEL_PROFILES } from './config-query.js';
import { maskIfSecret } from './secrets.js';
import { findPhase } from './phase.js';
import { roadmapGetPhase, getMilestoneInfo, extractCurrentMilestone, extractPhasesFromSection } from './roadmap.js';
import { determinePhaseStatus } from './progress.js';
import { planningPaths, normalizePhaseName, toPosixPath, resolveAgentsDir, detectRuntime } from './helpers.js';
import { generatePhaseSlug, assertSafeProjectCode } from './phase-lifecycle-policy.js';
import type { QueryHandler } from './utils.js';
@@ -470,17 +469,6 @@ export const initPlanPhase: QueryHandler = async (args, projectDir, workstream)
const phaseName = (phaseInfo?.phase_name as string) ?? null;
const phaseDir = (phaseInfo?.directory as string) ?? null;
const plans = (phaseInfo?.plans || []) as string[];
const summaries = (phaseInfo?.summaries || []) as string[];
// #3569: surface phase lifecycle status so /gsd-plan-phase can short-circuit
// on closed (Complete) phases instead of silently replanning over shipped
// code. Reuses determinePhaseStatus — the project-wide vocabulary used by
// `progress` (Pending | Planned | In Progress | Executed | Complete |
// Needs Review). When the phase has no directory on disk yet, treat it as
// Pending (it has not been started).
const phaseStatus = phaseDir
? await determinePhaseStatus(plans.length, summaries.length, join(projectDir, phaseDir))
: 'Pending';
// #3287: compute the canonical directory name with project_code prefix so
// the first-touch mkdir in /gsd-plan-phase stays consistent with phase.add.
@@ -515,7 +503,6 @@ export const initPlanPhase: QueryHandler = async (args, projectDir, workstream)
phase_slug: (phaseInfo?.phase_slug as string) ?? null,
padded_phase: phaseNumber ? normalizePhaseName(phaseNumber) : null,
phase_req_ids,
phase_status: phaseStatus,
has_research: (phaseInfo?.has_research as boolean) || false,
has_context: (phaseInfo?.has_context as boolean) || false,
has_reviews: (phaseInfo?.has_reviews as boolean) || false,