refactor(#1791): ADR-1769 Phase 6 — patch migration + curated current_phase_name preserve (#1695) (#1792)
Migrate cmdStatePatch (state.cts) onto the STATE.md Transition Module substrate and close the curated-field clobber bug class #1743/#1695 (ADR-1769, epic #1769). - Add {kind: 'patch'} to StateTransitionIntent, with patchCore in src/state-transition.cts. Applies each caller-supplied {field:value} pair via stateReplaceField over the full content (body + frontmatter), tracking updated vs. failed. data.updated/data.failed mirror the CLI output shape. - Collapse cmdStatePatch to a transitionCore dispatch. Field-name validation (security) and the resync-progress decision stay in the adapter. - #1695/#1743 fix: extend the #1230 delta heuristic in readModifyWriteStateMd to the curated current_phase_name, table-driven via getFieldClassification('current_phase_name').preservation === 'preserve-always'. When a write does NOT change the body Phase: source line, the curated frontmatter value wins over syncStateFrontmatter's body re-derivation (which harvests a wrong parenthetical aside — #1695). begin/planned/complete-phase rewrite their body Phase line, so the delta does not fire for them and current_phase_name still advances. - Regression: bug-1695-state-patch-clobbers-phase-name.test.cjs — unrelated patch preserves curated current_phase_name; patching the Phase source advances. All 70 transition + 493 regression tests pass (state/phase/milestone + #905/#397/#3242 lineages). Closes #1791
This commit is contained in:
@@ -1032,3 +1032,56 @@ describe('ADR-1769 Phase 5: milestoneComplete transition — closure write', ()
|
||||
assert.ok(/^milestone: v1\.0/m.test(result.content), 'frontmatter milestone preserved');
|
||||
});
|
||||
});
|
||||
|
||||
// ADR-1769 Phase 6: patch
|
||||
|
||||
describe('ADR-1769 Phase 6: patch transition — field updates', () => {
|
||||
const deps = { clock: fixedClock, progressProvider: noProgress };
|
||||
|
||||
test('applies each patched field and reports the updated set', () => {
|
||||
const input = [
|
||||
'# Project State',
|
||||
'',
|
||||
'**Status:** Planning',
|
||||
'**Current Plan:** 2',
|
||||
'**Total Plans in Phase:** 5',
|
||||
'',
|
||||
].join('\n');
|
||||
const result = transitionCore(
|
||||
input,
|
||||
{ kind: 'patch', patches: { Status: 'Paused', 'Current Plan': '3' } },
|
||||
deps,
|
||||
);
|
||||
assert.strictEqual(stateExtractField(result.content, 'Status'), 'Paused');
|
||||
assert.strictEqual(stateExtractField(result.content, 'Current Plan'), '3');
|
||||
assert.deepStrictEqual(result.data && result.data.updated, ['Status', 'Current Plan']);
|
||||
});
|
||||
|
||||
test('reports failed fields (no matching field in content)', () => {
|
||||
const input = '# Project State\n\n**Status:** Planning\n';
|
||||
const result = transitionCore(
|
||||
input,
|
||||
{ kind: 'patch', patches: { Status: 'Paused', Nonexistent: 'x' } },
|
||||
deps,
|
||||
);
|
||||
assert.deepStrictEqual(result.data && result.data.updated, ['Status']);
|
||||
assert.deepStrictEqual(result.data && result.data.failed, ['Nonexistent']);
|
||||
});
|
||||
|
||||
test('leaves content unchanged when no patch matches (no-op)', () => {
|
||||
const input = '# Project State\n\n**Status:** Planning\n';
|
||||
const result = transitionCore(input, { kind: 'patch', patches: { Nonexistent: 'x' } }, deps);
|
||||
assert.strictEqual(result.content, input);
|
||||
assert.deepStrictEqual(result.data && result.data.updated, []);
|
||||
assert.deepStrictEqual(result.data && result.data.failed, ['Nonexistent']);
|
||||
});
|
||||
|
||||
test('patching a frontmatter YAML key directly updates the YAML line', () => {
|
||||
// patch operates on the full content (body + frontmatter), so a lowercase
|
||||
// frontmatter key like `stopped_at` is matched and replaced.
|
||||
const input = ['---', 'status: executing', 'stopped_at: 2026-01-01', '---', '', '# State', ''].join('\n');
|
||||
const result = transitionCore(input, { kind: 'patch', patches: { stopped_at: '2026-06-27' } }, deps);
|
||||
assert.ok(/^stopped_at: 2026-06-27$/m.test(result.content), 'YAML stopped_at must be patched');
|
||||
assert.deepStrictEqual(result.data && result.data.updated, ['stopped_at']);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user