fix(#1356): rewrite bare ~/.claude paths in the Cursor install branch (#1368)

* fix(#1356): rewrite bare ~/.claude paths in the Cursor install branch

The Cursor branch of _applyRuntimeRewrites only rewrote the trailing-slash
.claude forms, so bare ~/.claude / $HOME/.claude references survived into
installed Cursor artifacts (skills/gsd-surface, skills/gsd-graphify,
workflows/plan-phase, workflows/autonomous), tripping the post-install
"unreplaced .claude path reference(s)" audit. Same regression class as
#983/#2418/#2545 — every other affected branch was patched; cursor was missed.

- Add the three bare-form rewrites (~/.claude, $HOME/.claude, ./.claude) to the
  cursor branch, mirroring cline/trae/augment/codebuddy. They run after the
  slash forms (no double-replace) and use (?![\w-]) so .claude-plugin /
  .claudeignore are not corrupted.
- SKILL.md content also passes through this stage, so no stage-1 converter
  change is needed. Verified: 40 bare refs in the real leaking files → 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore(#1356): add changeset for Cursor bare-path rewrite fix

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-17 08:51:48 -04:00
committed by GitHub
parent c03f3cc6af
commit 08e42b0ef1
3 changed files with 122 additions and 0 deletions

View File

@@ -18,6 +18,7 @@ const {
convertClaudeCommandToCursorSkill,
convertClaudeAgentToCursorAgent,
convertClaudeCommandToCursorCommand,
_applyRuntimeRewrites,
} = require('../bin/install.js');
describe('convertClaudeCommandToCursorSkill', () => {
@@ -151,3 +152,112 @@ Some body content.
'convertClaudeCommandToCursorCommand must be exported from install.js');
});
});
// ─── _applyRuntimeRewrites(cursor) — bare-form regression (#1356) ────────────
//
// Prior to this fix the cursor branch only rewrote trailing-slash ~/.claude/
// and $HOME/.claude/ forms. Bare end-of-token references (end of line,
// inside backtick spans, before punctuation) survived and triggered the
// post-install audit "Found N unreplaced .claude path reference(s)".
//
// Fix: add three bare-form rewrites (mirroring augment/windsurf/trae) using
// (?![\w-]) to avoid corrupting .claude-plugin / .claudeignore.
//
// TDD proof: these assertions FAIL before the fix and PASS after.
describe('_applyRuntimeRewrites(cursor) — bare-form ~/.claude regression (#1356)', () => {
const CURSOR_PATH_PREFIX = '~/.cursor/';
// Compound input that exercises every bare and slash ~/.claude / $HOME/.claude
// form the fix must handle. .claude-plugin is intentionally excluded here
// because \b fires before the hyphen — its preservation is tested separately.
const COMPOUND_INPUT = [
'Config dir: ~/.claude',
'Also: $HOME/.claude',
'Slash form: ~/.claude/gsd-core/foo.md',
'Inline: paths `~/.claude`, `~/.cursor`',
].join('\n');
// Input for the preservation test only — includes .claude-plugin.
const COMPOUND_INPUT_WITH_PLUGIN = COMPOUND_INPUT + '\nPlugin installed at: ~/.claude-plugin/plugin.json';
test('bare ~/.claude at end of line is rewritten (no trailing slash)', () => {
const result = _applyRuntimeRewrites(COMPOUND_INPUT, 'cursor', CURSOR_PATH_PREFIX);
assert.ok(
!/~\/\.claude\b/.test(result),
`bare ~/.claude must be gone; got:\n${result}`,
);
assert.ok(result.includes('~/.cursor'), `cursor prefix must appear; got:\n${result}`);
});
test('bare $HOME/.claude at end of line is rewritten', () => {
const result = _applyRuntimeRewrites(COMPOUND_INPUT, 'cursor', CURSOR_PATH_PREFIX);
assert.ok(
!/\$HOME\/\.claude\b/.test(result),
`bare $HOME/.claude must be gone; got:\n${result}`,
);
});
test('bare ~/.claude inside a code span (before punctuation) is rewritten', () => {
const input = 'paths: `~/.claude`, `~/.cursor`';
const result = _applyRuntimeRewrites(input, 'cursor', CURSOR_PATH_PREFIX);
assert.ok(
!/~\/\.claude\b/.test(result),
`bare ~/.claude before punctuation must be gone; got:\n${result}`,
);
});
test('trailing-slash ~/.claude/gsd-core/foo.md is rewritten exactly once (no doubling)', () => {
const input = '~/.claude/gsd-core/foo.md';
const result = _applyRuntimeRewrites(input, 'cursor', CURSOR_PATH_PREFIX);
assert.ok(result.includes('~/.cursor/gsd-core/foo.md'), `slash form must be rewritten; got: ${result}`);
assert.ok(!result.includes('cursor/cursor'), `path must not be doubled; got: ${result}`);
assert.ok(!result.includes('.claude'), `no .claude must survive; got: ${result}`);
});
test('zero surviving bare ~/.claude or $HOME/.claude refs in compound input', () => {
const result = _applyRuntimeRewrites(COMPOUND_INPUT, 'cursor', CURSOR_PATH_PREFIX);
const bareClaudePattern = /(?:~|\$HOME)\/\.claude\b/;
assert.ok(
!bareClaudePattern.test(result),
`no bare ~/.claude / $HOME/.claude must survive; got:\n${result}`,
);
});
test('~/.claude-plugin is NOT corrupted — (?![\\w-]) lookahead preserves it', () => {
const result = _applyRuntimeRewrites(COMPOUND_INPUT_WITH_PLUGIN, 'cursor', CURSOR_PATH_PREFIX);
assert.ok(
result.includes('~/.claude-plugin'),
`~/.claude-plugin must be preserved; got:\n${result}`,
);
assert.ok(
!result.includes('~/.cursor-plugin'),
`~/.cursor-plugin must NOT appear; got:\n${result}`,
);
});
test('bare relative ./.claude (end-of-token) is rewritten to ./.cursor', () => {
// The relative bare form ./.claude (no trailing slash) must also be caught.
// End-of-line, inside a code span, and before punctuation variants.
// The cursor dir name derived from pathPrefix '~/.cursor/' is '.cursor',
// so ./.claude → ./.cursor (the ./${dotDirName} form).
const pathPrefix = '~/.cursor/';
const isGlobal = false;
const input = [
'see ./.claude for config',
'also `./.claude` in a code span',
].join('\n');
const result = _applyRuntimeRewrites(input, 'cursor', pathPrefix, isGlobal);
assert.ok(
result.includes('./.cursor'),
`bare ./.claude must be rewritten to ./.cursor; got:\n${result}`,
);
assert.ok(
!/\/\.claude\b/.test(result),
`no bare ./.claude (end-of-token) must survive; got:\n${result}`,
);
});
});