enhance(#3638): render bracket phase IDs on progress, stats, manager and statusline surfaces (epic #612 PR-5) (#4111)
* enhance(#3638): render bracket IDs on display surfaces Gate progress, stats, manager, and statusline projections on the bracket convention; validate phase_id_convention and single-source the convention card. Forward note: the uat.cts bracket co-change remains deliberately deferred to its owning slice. * chore(#3638): point the changeset at PR #4111 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#3638): close bracket display review gaps * docs(#3638): register phase display modules * chore(#3638): re-trigger CI after macOS shard SIGTERM `full test (macos-latest, 24, shard 3/3)` failed on 20ce98cd1 in `tests/lint-compiled-artifact-sync.test.cjs` — the spawned `scripts/lint-compiled-artifact-sync.cjs` was killed at 60024ms (`exited null (signal SIGTERM)`, stdout and stderr both empty), 24ms past the test's own `TSC_COMPILE_TIMEOUT_MS`. That is the failure mode the constant's comment already documents ("under CI shard load that compile can exceed the budget, dying to a SIGTERM with empty piped stdout"). No content change; this empty commit exists only to re-run the matrix, since re-running a job needs write access on the upstream repository. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
342
tests/adr-612-bracket-display.property.test.cjs
Normal file
342
tests/adr-612-bracket-display.property.test.cjs
Normal file
@@ -0,0 +1,342 @@
|
||||
'use strict';
|
||||
|
||||
/**
|
||||
* ADR-612 PR-5 (#3638) — bracket display surfaces.
|
||||
*
|
||||
* Breaks caught:
|
||||
* - progress/stats re-parse a bracket directory with the legacy numeric shape;
|
||||
* - stats/init-manager fail to read label-less bracket headings;
|
||||
* - a display surface hand-builds an ID that diverges from the canonical
|
||||
* parse/render pair;
|
||||
* - a non-bracket project gains the new display_id field or widened heading
|
||||
* recognition without opting in.
|
||||
*/
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('node:fs');
|
||||
const path = require('node:path');
|
||||
|
||||
const fc = require('./helpers/fast-check-setup.cjs');
|
||||
const { createTempProject, cleanup, runGsdTools } = require('./helpers.cjs');
|
||||
const {
|
||||
parsePhaseId,
|
||||
renderMilestoneId,
|
||||
renderPhaseId,
|
||||
toDir,
|
||||
} = require('../gsd-core/bin/lib/phase-id.cjs');
|
||||
const {
|
||||
renderBracketMilestoneDisplay,
|
||||
} = require('../gsd-core/bin/lib/phase-id-display.cjs');
|
||||
const statusline = require('../hooks/gsd-statusline.js');
|
||||
|
||||
const UPPER = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
|
||||
const CODE_TAIL = `${UPPER}0123456789_`;
|
||||
const codeArb = fc
|
||||
.tuple(
|
||||
fc.constantFrom(...UPPER),
|
||||
fc.string({ unit: fc.constantFrom(...CODE_TAIL), maxLength: 5 }),
|
||||
)
|
||||
.map(([head, tail]) => head + tail);
|
||||
const canonicalNumberArb = fc.oneof(
|
||||
fc.integer({ min: 0, max: 99 }).map((n) => String(n).padStart(2, '0')),
|
||||
fc.integer({ min: 100, max: 9999 }).map(String),
|
||||
);
|
||||
|
||||
function writeState(planningDir) {
|
||||
fs.writeFileSync(
|
||||
path.join(planningDir, 'STATE.md'),
|
||||
[
|
||||
'---',
|
||||
'milestone: v2.0',
|
||||
'milestone_name: Display',
|
||||
'status: planning',
|
||||
'active_phase: null',
|
||||
'---',
|
||||
'',
|
||||
'# State',
|
||||
'',
|
||||
'Phase: 1 of 1 (Display Slice)',
|
||||
'',
|
||||
].join('\n'),
|
||||
);
|
||||
}
|
||||
|
||||
function bracketProject(t) {
|
||||
const cwd = createTempProject('adr-612-display-');
|
||||
t.after(() => cleanup(cwd));
|
||||
const planning = path.join(cwd, '.planning');
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'config.json'),
|
||||
JSON.stringify({ phase_id_convention: 'bracket', project_code: 'GSD' }),
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'ROADMAP.md'),
|
||||
[
|
||||
'# Roadmap',
|
||||
'',
|
||||
'## [GSD.02] v2.0: Display',
|
||||
'',
|
||||
'- [ ] **[GSD.02] 05.03: Display Slice**',
|
||||
'',
|
||||
'### [GSD.02] 05.03: Display Slice',
|
||||
'',
|
||||
'**Goal:** Render the canonical ID',
|
||||
'',
|
||||
].join('\n'),
|
||||
);
|
||||
writeState(planning);
|
||||
const phaseDir = path.join(planning, 'phases', 'GSD.02-05.03-display-slice');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '05.03-01-PLAN.md'), '# Plan\n');
|
||||
return cwd;
|
||||
}
|
||||
|
||||
function legacyProject(t) {
|
||||
const cwd = createTempProject('adr-612-display-legacy-');
|
||||
t.after(() => cleanup(cwd));
|
||||
const planning = path.join(cwd, '.planning');
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'config.json'),
|
||||
JSON.stringify({ phase_id_convention: 'sequential', project_code: 'GSD' }),
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'ROADMAP.md'),
|
||||
[
|
||||
'# Roadmap',
|
||||
'',
|
||||
'## v2.0: Display',
|
||||
'',
|
||||
'- [ ] **Phase 05.03: Display Slice**',
|
||||
'',
|
||||
'### Phase 05.03: Display Slice',
|
||||
'',
|
||||
'**Goal:** Preserve legacy display',
|
||||
'',
|
||||
].join('\n'),
|
||||
);
|
||||
writeState(planning);
|
||||
const phaseDir = path.join(planning, 'phases', '05.03-display-slice');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '05.03-01-PLAN.md'), '# Plan\n');
|
||||
return cwd;
|
||||
}
|
||||
|
||||
function malformedBracketProject(t) {
|
||||
const cwd = createTempProject('adr-612-display-malformed-');
|
||||
t.after(() => cleanup(cwd));
|
||||
const planning = path.join(cwd, '.planning');
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'config.json'),
|
||||
JSON.stringify({ phase_id_convention: 'bracket', project_code: 'GSD' }),
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(planning, 'ROADMAP.md'),
|
||||
[
|
||||
'# Roadmap',
|
||||
'',
|
||||
'## [GSD.02] v2.0: Display',
|
||||
'',
|
||||
].join('\n'),
|
||||
);
|
||||
writeState(planning);
|
||||
const phaseDir = path.join(planning, 'phases', 'gsd.02-05.03-recovered-display-name');
|
||||
fs.mkdirSync(phaseDir, { recursive: true });
|
||||
fs.writeFileSync(path.join(phaseDir, '05.03-01-PLAN.md'), '# Plan\n');
|
||||
return cwd;
|
||||
}
|
||||
|
||||
function runJson(command, cwd) {
|
||||
const result = runGsdTools(command, cwd);
|
||||
assert.ok(result.success, `${command} failed: ${result.error}`);
|
||||
return JSON.parse(result.output);
|
||||
}
|
||||
|
||||
describe('#3638: canonical bracket display examples', () => {
|
||||
test('progress and stats expose canonical display_id while retaining the phase token', (t) => {
|
||||
const cwd = bracketProject(t);
|
||||
|
||||
for (const [command, expectedName] of [
|
||||
['progress json', 'display slice'],
|
||||
['stats json', 'Display Slice'],
|
||||
]) {
|
||||
const output = runJson(command, cwd);
|
||||
assert.equal(output.phases.length, 1, `${command} must report the bracket phase`);
|
||||
assert.equal(output.milestone_version, '[GSD.02]');
|
||||
assert.deepEqual(
|
||||
{
|
||||
number: output.phases[0].number,
|
||||
display_id: output.phases[0].display_id,
|
||||
name: output.phases[0].name,
|
||||
},
|
||||
{ number: '05.03', display_id: '[GSD.02] 05.03', name: expectedName },
|
||||
);
|
||||
}
|
||||
|
||||
const progressTable = runJson('progress table', cwd).rendered;
|
||||
const statsTable = runJson('stats table', cwd).rendered;
|
||||
assert.match(progressTable, /\| \[GSD\.02\] 05\.03 \| display slice \|/);
|
||||
assert.match(statsTable, /\| \[GSD\.02\] 05\.03 \| Display Slice \|/);
|
||||
assert.doesNotMatch(progressTable, /v2\.0/);
|
||||
assert.doesNotMatch(statsTable, /v2\.0/);
|
||||
});
|
||||
|
||||
test('init manager reads the label-less bracket heading and emits its canonical display_id', (t) => {
|
||||
const cwd = bracketProject(t);
|
||||
const output = runJson('init manager', cwd);
|
||||
|
||||
assert.equal(output.phases.length, 1);
|
||||
assert.deepEqual(
|
||||
{
|
||||
number: output.phases[0].number,
|
||||
display_id: output.phases[0].display_id,
|
||||
name: output.phases[0].name,
|
||||
disk_status: output.phases[0].disk_status,
|
||||
},
|
||||
{
|
||||
number: '05.03',
|
||||
display_id: '[GSD.02] 05.03',
|
||||
name: 'Display Slice',
|
||||
disk_status: 'planned',
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
test('a non-bracket project preserves the legacy object and table shape', (t) => {
|
||||
const cwd = legacyProject(t);
|
||||
|
||||
for (const [command, expectedName] of [
|
||||
['progress json', 'display slice'],
|
||||
['stats json', 'Display Slice'],
|
||||
['init manager', 'Display Slice'],
|
||||
]) {
|
||||
const output = runJson(command, cwd);
|
||||
assert.equal(output.phases.length, 1, `${command} must retain its legacy phase`);
|
||||
assert.equal(output.phases[0].number, '05.03');
|
||||
assert.equal(output.phases[0].name, expectedName);
|
||||
assert.equal(Object.hasOwn(output.phases[0], 'display_id'), false);
|
||||
}
|
||||
|
||||
assert.match(runJson('progress table', cwd).rendered, /\| 05\.03 \| display slice \|/);
|
||||
assert.match(runJson('stats table', cwd).rendered, /\| 05\.03 \| Display Slice \|/);
|
||||
});
|
||||
|
||||
test('progress recovers a malformed bracket directory name without a display_id', (t) => {
|
||||
const output = runJson('progress json', malformedBracketProject(t));
|
||||
|
||||
assert.equal(output.phases.length, 1);
|
||||
assert.deepEqual(
|
||||
{
|
||||
number: output.phases[0].number,
|
||||
name: output.phases[0].name,
|
||||
hasDisplayId: Object.hasOwn(output.phases[0], 'display_id'),
|
||||
},
|
||||
{ number: '05.03', name: 'recovered display name', hasDisplayId: false },
|
||||
);
|
||||
});
|
||||
|
||||
test('stats recovers a malformed bracket directory name without a display_id', (t) => {
|
||||
const output = runJson('stats json', malformedBracketProject(t));
|
||||
|
||||
assert.equal(output.phases.length, 1);
|
||||
assert.deepEqual(
|
||||
{
|
||||
number: output.phases[0].number,
|
||||
name: output.phases[0].name,
|
||||
hasDisplayId: Object.hasOwn(output.phases[0], 'display_id'),
|
||||
},
|
||||
{ number: '05.03', name: 'recovered display name', hasDisplayId: false },
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('#3638: bracket milestone renderer', () => {
|
||||
test('pins the milestone label as the shared phase-display prefix', () => {
|
||||
const id = parsePhaseId('[GSD.02] 05.03-01');
|
||||
|
||||
assert.equal(renderMilestoneId(id), '[GSD.02]');
|
||||
assert.equal(renderPhaseId(id), `${renderMilestoneId(id)} 05.03-01`);
|
||||
assert.equal(renderBracketMilestoneDisplay('v2.0', 'GSD'), '[GSD.02]');
|
||||
});
|
||||
});
|
||||
|
||||
describe('#3638: statusline/progress-card convention gate', () => {
|
||||
const state = {
|
||||
milestone: 'v2.0',
|
||||
milestoneName: 'Display',
|
||||
activePhase: '05.03',
|
||||
status: 'executing',
|
||||
percent: '50',
|
||||
};
|
||||
const bracket = { convention: 'bracket', projectCode: 'GSD' };
|
||||
|
||||
test('full and compact cards render only the canonical bracket identity', () => {
|
||||
const full = statusline.formatGsdState(state, bracket);
|
||||
const compact = statusline.formatGsdStateCompact(state, bracket);
|
||||
|
||||
assert.equal(
|
||||
full,
|
||||
'[GSD.02] Display [█████░░░░░] 50% · [GSD.02] 05.03 executing',
|
||||
);
|
||||
assert.equal(compact, '[GSD.02] · [GSD.02] 05.03 · executing');
|
||||
assert.doesNotMatch(`${full}\n${compact}`, /v2\.0|\bPhase\b|\bP05\.03\b/);
|
||||
});
|
||||
|
||||
test('a non-bracket convention retains the exact legacy card strings', () => {
|
||||
assert.equal(
|
||||
statusline.formatGsdState(state, { convention: 'sequential', projectCode: 'GSD' }),
|
||||
'v2.0 Display [█████░░░░░] 50% · Phase 05.03 executing',
|
||||
);
|
||||
assert.equal(
|
||||
statusline.formatGsdStateCompact(state, { convention: 'sequential', projectCode: 'GSD' }),
|
||||
'v2.0 · P05.03 · executing',
|
||||
);
|
||||
});
|
||||
|
||||
test('renderStatusline threads the bracket configuration through both entry points', (t) => {
|
||||
const cwd = bracketProject(t);
|
||||
const input = {
|
||||
model: { display_name: 'Claude' },
|
||||
workspace: { current_dir: cwd },
|
||||
context_window: {},
|
||||
};
|
||||
|
||||
const full = statusline.renderStatusline(input);
|
||||
assert.match(full, /\[GSD\.02\]/);
|
||||
assert.doesNotMatch(full, /v2\.0/);
|
||||
|
||||
fs.writeFileSync(
|
||||
path.join(cwd, '.planning', 'config.json'),
|
||||
JSON.stringify({
|
||||
phase_id_convention: 'bracket',
|
||||
project_code: 'GSD',
|
||||
statusline: { state_format: 'compact' },
|
||||
}),
|
||||
);
|
||||
const compact = statusline.renderStatusline(input);
|
||||
assert.match(compact, /\[GSD\.02\]/);
|
||||
assert.doesNotMatch(compact, /v2\.0/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('#3638: pure bracket pair remains the display/disk oracle', () => {
|
||||
test('render(parse(display)) is identity and toDir(parse(display)) reaches the hand-built dir', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
codeArb,
|
||||
canonicalNumberArb,
|
||||
canonicalNumberArb,
|
||||
fc.option(canonicalNumberArb, { nil: undefined }),
|
||||
(project, milestone, phase, subphase) => {
|
||||
const token = subphase === undefined ? phase : `${phase}.${subphase}`;
|
||||
const display = `[${project}.${milestone}] ${token}`;
|
||||
const dir = `${project}.${milestone}-${token}-display-slice`;
|
||||
const parsed = parsePhaseId(display);
|
||||
|
||||
assert.equal(renderPhaseId(parsed), display);
|
||||
assert.equal(toDir(parsed, 'display slice'), dir);
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
});
|
||||
@@ -52,6 +52,8 @@ const BASE_SITES = [
|
||||
baseline: B.ANY_BRACKET, src: '(?:\\[[^\\]]{1,200}\\]\\s*)?Phase\\s+' },
|
||||
{ file: 'roadmap-parser.cts', site: 'getMilestonePhaseFilter phaseHeadingPattern',
|
||||
baseline: B.ANY_BRACKET, src: '(?:\\[[^\\]]{1,200}\\]\\s*)?Phase\\s+' },
|
||||
{ file: 'commands.cts', site: 'cmdStats headingPattern',
|
||||
baseline: B.ANY_BRACKET, src: '(?:\\[[^\\]]{1,200}\\]\\s*)?Phase\\s+' },
|
||||
// #2761 B2: BRACKET_PHASE_TAIL_RE (isBracketMilestoneBoundary's phase-tail
|
||||
// discriminator) always passes the literal 'bracket' convention — it is not
|
||||
// itself convention-gated (the CALLER, isBracketMilestoneBoundary, is only
|
||||
@@ -123,6 +125,10 @@ const BASE_SITES = [
|
||||
baseline: B.LABEL_ONLY, src: 'Phase\\s+' },
|
||||
{ file: 'planning-snapshot.cts', site: 'buildRoadmapPhaseCheckboxesField (W011/W006 not-started)',
|
||||
baseline: B.LABEL_ONLY, src: 'Phase\\s+' },
|
||||
{ file: 'init.cts', site: 'cmdInitManager phaseHeadingPrefix',
|
||||
baseline: B.LABEL_ONLY, src: 'Phase\\s+' },
|
||||
{ file: 'init.cts', site: 'cmdInitManager phaseHeadingPrefixNoCapture',
|
||||
baseline: B.LABEL_ONLY, src: 'Phase\\s+' },
|
||||
];
|
||||
|
||||
// Every convention value that is NOT the bracket convention. A repo carrying any
|
||||
@@ -681,6 +687,8 @@ describe('#612 PR-2: every selector call site declares the right baseline (live
|
||||
|
||||
// file -> [ANY_BRACKET count, LABEL_ONLY count]
|
||||
const EXPECTED = {
|
||||
'commands.cts': [1, 0],
|
||||
'init.cts': [0, 2],
|
||||
'roadmap.cts': [3, 3],
|
||||
'validate.cts': [1, 2],
|
||||
'state.cts': [0, 3],
|
||||
|
||||
@@ -13,6 +13,65 @@ const fs = require('fs');
|
||||
const path = require('path');
|
||||
const { runGsdTools, createTempProject, cleanup, delay } = require('./helpers.cjs');
|
||||
|
||||
// ─── ADR-612 PR-5: phase_id_convention enum validation ──────────────────────
|
||||
|
||||
describe('#3638: phase_id_convention config enum', () => {
|
||||
test('accepts sequential, milestone-prefixed, and bracket exactly', (t) => {
|
||||
const tmpDir = createTempProject('gsd-phase-id-convention-');
|
||||
t.after(() => cleanup(tmpDir));
|
||||
|
||||
for (const convention of ['sequential', 'milestone-prefixed', 'bracket']) {
|
||||
const result = runGsdTools(['config-set', 'phase_id_convention', convention], tmpDir);
|
||||
assert.ok(result.success, `config-set phase_id_convention ${convention} failed: ${result.error}`);
|
||||
assert.equal(readConfig(tmpDir).phase_id_convention, convention);
|
||||
}
|
||||
});
|
||||
|
||||
test('absent and null preserve the unset legacy behavior', (t) => {
|
||||
const tmpDir = createTempProject('gsd-phase-id-convention-');
|
||||
t.after(() => cleanup(tmpDir));
|
||||
assert.equal(
|
||||
fs.existsSync(path.join(tmpDir, '.planning', 'config.json')),
|
||||
false,
|
||||
'an absent config leaves the convention unset',
|
||||
);
|
||||
writeConfig(tmpDir, { phase_id_convention: 'bracket', model_profile: 'balanced' });
|
||||
|
||||
const result = runGsdTools(['config-set', 'phase_id_convention', 'null'], tmpDir);
|
||||
assert.ok(result.success, `config-set phase_id_convention null failed: ${result.error}`);
|
||||
const config = readConfig(tmpDir);
|
||||
assert.equal(Object.hasOwn(config, 'phase_id_convention'), false);
|
||||
assert.equal(config.model_profile, 'balanced', 'unsetting the convention must preserve sibling config');
|
||||
});
|
||||
|
||||
test('rejects unsupported and case-mismatched values with the supported set', (t) => {
|
||||
const tmpDir = createTempProject('gsd-phase-id-convention-');
|
||||
t.after(() => cleanup(tmpDir));
|
||||
|
||||
for (const value of ['free-form', 'Bracket']) {
|
||||
const result = runGsdTools(['config-set', 'phase_id_convention', value], tmpDir);
|
||||
assert.equal(result.success, false, `${value} must be rejected`);
|
||||
assert.match(result.error, /Invalid phase_id_convention/);
|
||||
assert.match(result.error, /sequential, milestone-prefixed, bracket/);
|
||||
}
|
||||
});
|
||||
|
||||
test('sequential remains valid configuration but is not a roadmap-upgrade target', (t) => {
|
||||
const tmpDir = createTempProject('gsd-phase-id-convention-');
|
||||
t.after(() => cleanup(tmpDir));
|
||||
|
||||
const configResult = runGsdTools(['config-set', 'phase_id_convention', 'sequential'], tmpDir);
|
||||
assert.ok(configResult.success, `sequential config failed: ${configResult.error}`);
|
||||
|
||||
const migrationResult = runGsdTools(
|
||||
['roadmap', 'upgrade', '--convention', 'sequential', '--dry-run'],
|
||||
tmpDir,
|
||||
);
|
||||
assert.equal(migrationResult.success, false, 'sequential must not become a migration target');
|
||||
assert.match(migrationResult.error, /Only --convention milestone-prefixed is supported/);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── helpers ──────────────────────────────────────────────────────────────────
|
||||
|
||||
function readConfig(tmpDir) {
|
||||
|
||||
1
tests/fixtures/install-tree/antigravity.json
vendored
1
tests/fixtures/install-tree/antigravity.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/augment.json
vendored
1
tests/fixtures/install-tree/augment.json
vendored
@@ -354,6 +354,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
@@ -218,6 +218,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/claude.json
vendored
1
tests/fixtures/install-tree/claude.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/cline.json
vendored
1
tests/fixtures/install-tree/cline.json
vendored
@@ -284,6 +284,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/codebuddy.json
vendored
1
tests/fixtures/install-tree/codebuddy.json
vendored
@@ -354,6 +354,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/codex.json
vendored
1
tests/fixtures/install-tree/codex.json
vendored
@@ -318,6 +318,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/copilot.json
vendored
1
tests/fixtures/install-tree/copilot.json
vendored
@@ -283,6 +283,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/cursor.json
vendored
1
tests/fixtures/install-tree/cursor.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/hermes.json
vendored
1
tests/fixtures/install-tree/hermes.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/kilo.json
vendored
1
tests/fixtures/install-tree/kilo.json
vendored
@@ -354,6 +354,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/kimi-code.json
vendored
1
tests/fixtures/install-tree/kimi-code.json
vendored
@@ -283,6 +283,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/kimi.json
vendored
1
tests/fixtures/install-tree/kimi.json
vendored
@@ -290,6 +290,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/opencode.json
vendored
1
tests/fixtures/install-tree/opencode.json
vendored
@@ -354,6 +354,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/pi.json
vendored
1
tests/fixtures/install-tree/pi.json
vendored
@@ -84,6 +84,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/qwen.json
vendored
1
tests/fixtures/install-tree/qwen.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/trae.json
vendored
1
tests/fixtures/install-tree/trae.json
vendored
@@ -282,6 +282,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/windsurf.json
vendored
1
tests/fixtures/install-tree/windsurf.json
vendored
@@ -210,6 +210,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
1
tests/fixtures/install-tree/zcode.json
vendored
1
tests/fixtures/install-tree/zcode.json
vendored
@@ -354,6 +354,7 @@
|
||||
"gsd-core/references/nyquist-compliance.md",
|
||||
"gsd-core/references/offer-next.md",
|
||||
"gsd-core/references/phase-argument-parsing.md",
|
||||
"gsd-core/references/phase-id-convention.md",
|
||||
"gsd-core/references/plan-checker-examples.md",
|
||||
"gsd-core/references/planner-antipatterns.md",
|
||||
"gsd-core/references/planner-chunked.md",
|
||||
|
||||
58
tests/phase-id-card.test.cjs
Normal file
58
tests/phase-id-card.test.cjs
Normal file
@@ -0,0 +1,58 @@
|
||||
'use strict';
|
||||
|
||||
/** ADR-612 PR-5: the bracket convention card has one runtime source. */
|
||||
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('node:fs');
|
||||
const path = require('node:path');
|
||||
const { normalizeEol } = require('../gsd-core/bin/lib/text-lines.cjs');
|
||||
|
||||
const {
|
||||
phaseIdCard,
|
||||
PHASE_ID_CARD,
|
||||
PHASE_ID_LEGEND,
|
||||
} = require('../gsd-core/bin/lib/phase-id-card.cjs');
|
||||
|
||||
const REFERENCE_PATH = path.join(
|
||||
__dirname,
|
||||
'..',
|
||||
'gsd-core',
|
||||
'references',
|
||||
'phase-id-convention.md',
|
||||
);
|
||||
|
||||
describe('#3638: phase ID convention card single source', () => {
|
||||
test('the runtime card labels every identity dimension', () => {
|
||||
const rendered = phaseIdCard();
|
||||
|
||||
assert.match(rendered, /^\[GSD\.02\] 05\.03-01/m);
|
||||
assert.match(rendered, /plan\s+01/);
|
||||
assert.match(rendered, /subphase\s+03/);
|
||||
assert.match(rendered, /phase\s+05/);
|
||||
assert.match(rendered, /milestone\s+02/);
|
||||
assert.match(rendered, /project\s+GSD/);
|
||||
assert.match(PHASE_ID_LEGEND, /no 'Phase' word, no vX\.Y/);
|
||||
assert.equal(PHASE_ID_CARD.split('\n').length, 7);
|
||||
});
|
||||
|
||||
test('an optional title composes without mutating the canonical card', () => {
|
||||
assert.equal(
|
||||
phaseIdCard({ title: 'Bracket convention:' }),
|
||||
`Bracket convention:\n\n${PHASE_ID_CARD}\n\n${PHASE_ID_LEGEND}`,
|
||||
);
|
||||
assert.equal(phaseIdCard(), `${PHASE_ID_CARD}\n\n${PHASE_ID_LEGEND}`);
|
||||
});
|
||||
|
||||
test('the reference card block is generated byte-for-byte from the runtime source', () => {
|
||||
const reference = normalizeEol(fs.readFileSync(REFERENCE_PATH, 'utf8'));
|
||||
const opener = '<!-- PHASE-ID-CARD:START -->\n```text\n';
|
||||
const closer = '\n```\n<!-- PHASE-ID-CARD:END -->';
|
||||
const start = reference.indexOf(opener);
|
||||
const end = reference.indexOf(closer, start + opener.length);
|
||||
|
||||
assert.notEqual(start, -1, 'generated card opener must remain present');
|
||||
assert.notEqual(end, -1, 'generated card closer must remain present');
|
||||
assert.equal(reference.slice(start + opener.length, end), phaseIdCard());
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user