golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: detect files_modified overlap and enforce wave ordering for dependent plans (#1587) (#1600)

Browse Source 
* fix: correct STATE.md progress counter fields during plan/phase completion (#1589)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ci: re-run CI with Windows pointer lifecycle fix in main

* fix: orchestrator owns STATE.md/ROADMAP.md writes in parallel worktree mode (#1571)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: detect files_modified overlap and enforce wave ordering for dependent plans (#1587)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: trim gsd-planner.md below 50000-char prompt-injection limit

The assign_waves section added in this branch pushed agents/gsd-planner.md
to 50271 chars, triggering the security scanner's prompt-stuffing check on
all CI platforms. Condense prose while preserving all logic and validation
rules; file is now 49754 chars.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-04-03 12:19:41 -04:00
committed by GitHub
parent 40fc681b28
commit 0b43cfd303
4 changed files with 384 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
agents/gsd-planner.md
View File

@@ -1216,13 +1216,26 @@ for each plan in plan_order:
else:
plan.wave = max(waves[dep] for dep in plan.depends_on) + 1
waves[plan.id] = plan.wave
# Implicit dependency: files_modified overlap forces a later wave.
for each plan B in plan_order:
for each earlier plan A where A != B:
if any file in B.files_modified is also in A.files_modified:
B.wave = max(B.wave, A.wave + 1)
waves[B.id] = B.wave
```
**Rule:** Any two plans in the same wave MUST have zero `files_modified` overlap — even if
no explicit `depends_on` was set. After computing all wave numbers, verify every wave group:
collect the union of `files_modified` per wave; if any file appears in two or more plans
within the same wave, bump the later plan to the next wave and repeat until clean.
Log each bump: `"Plan {B} moved to wave {N+1}: files_modified overlap with Plan {A} on {file}"`
</step>
<step name="group_into_plans">
Rules:
1. Same-wave tasks with no file conflicts → parallel plans
2. Shared files → same plan or sequential plans
2. Shared files → same plan or sequential plans (shared file = implicit dependency → later wave)
3. Checkpoint tasks → `autonomous: false`
4. Each plan: 2-3 tasks, single concern, ~50% context target
</step>