* chore(#3059): close the ESLint glob-coverage escape and guard it 62 tracked source files matched no `files:` glob in eslint.config.mjs, so ESLint skipped them entirely while `eslint .` still exited 0 — including all 26 files under hooks/, the enforcement machinery itself. Covers 56 of them (eslint-rules/, hooks/, bin/lib/, pi/, examples/, vscode/, the plugin shims, root *.mjs) and allowlists the 6 deliberate must-not-compile brand-typing fixtures with a recorded reason each. hooks/** is covered with n/no-process-exit deliberately off: a hook's whole contract is its exit code, several exits are load-bearing stdin-timeout guards where nothing else terminates the process, and ADR-0012/0174 scope the no-process-exit convention to the Command Routing Hub. bin/lib/ui-safety-gate.cjs is dual-mode, so it keeps the rule live and takes two targeted disables in its require.main===module tail instead. Adds scripts/lint-eslint-glob-coverage.cjs + a node:test drift guard so the class cannot regrow: allowlist entries require a non-empty reason, the list ratchets down only (a stale entry fails), and a tracked-count floor means a broken `git ls-files` fails rather than reporting clean. Closes #3059 * chore(#3059): apply review findings — correct the changeset count, add parser properties Isolated adversarial review, confirmed by rebuilding a byte-for-byte replica of the pre-change eslint.config.mjs: the changeset claimed 44 previously- unlinted files. The real figure is 56 (56 covered + 6 allowlisted = 62). That was user-facing CHANGELOG text and was wrong; corrected, along with three consequential figures in the design record. CLAUDE.md requires a fast-check property test for parsers and budget limits, and listTrackedSourceFiles is a parser. The standards review called this "satisfied in spirit"; it is not. Adds three properties driving the real exported parser through an injected execFile: extension totality/soundness including a trailing terminator, backslash-normalization totality, and CRLF/LF equivalence — the invariant the repo's recurring CRLF defect class breaks. Also de-duplicates the anchor rows onto one shared resolver, kept deliberately independent of the guard's own resolveFileCoverage so an anchor still fails if that resolution regresses, and records in the guard's header why the bin/install.js family is NOT allowlisted: it resolves to 2 rules under ADR-1703, so an entry would trip the allowlist_stale ratchet. * fix(#3059): make the coverage guard's git call container-safe The remote runner reported the guard degrading to `git_failed` on both Node lanes: fatal: detected dubious ownership in repository at '/work' The runner executes in a container where the repo is owned by a different UID, so git refuses to operate on it. The guard's degraded-verdict path worked exactly as designed — it reported the failure instead of throwing or falsely reporting clean — but a guard that cannot run in CI is not a gate. `git ls-files` is now invoked as `git -c safe.directory=* ls-files`. `-c` scopes the override to the single invocation and mutates no config file, and the wildcard is appropriate because this command only enumerates tracked paths in the repository it is already executing inside. Adds a regression test that captures the argv through the injected execFile seam and asserts `-c safe.directory=*` precedes `ls-files`, so the container case is pinned behaviorally rather than by reading the script's source. * chore(#3059): backfill changeset PR number pr:0 placeholder replaced with the real number now that #3277 exists. --------- Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
@@ -323,8 +323,22 @@ export default tseslint.config(
|
||||
|
||||
// ── gsd-core/bin/**/*.cjs + scripts/**/*.cjs ───────────────────────────
|
||||
// CommonJS Node files: js.recommended + eslint-plugin-n + local plugin rules
|
||||
// eslint-rules/**, bin/lib/**, pi/**, examples/**, vscode/*.js, .kilo/plugins/*.js,
|
||||
// and .opencode/plugins/*.js were previously unmatched by every glob in this config
|
||||
// (drift guard scripts/lint-eslint-glob-coverage.cjs, #3059). All are CommonJS
|
||||
// (require/module.exports); folded into this block rather than duplicated.
|
||||
{
|
||||
files: ['gsd-core/bin/**/*.cjs', 'scripts/**/*.cjs'],
|
||||
files: [
|
||||
'gsd-core/bin/**/*.cjs',
|
||||
'scripts/**/*.cjs',
|
||||
'eslint-rules/**/*.cjs',
|
||||
'bin/lib/**/*.cjs',
|
||||
'pi/**/*.cjs',
|
||||
'examples/**/*.cjs',
|
||||
'vscode/*.js',
|
||||
'.kilo/plugins/*.js',
|
||||
'.opencode/plugins/*.js',
|
||||
],
|
||||
plugins: {
|
||||
n: pluginN,
|
||||
local: localPlugin,
|
||||
@@ -357,6 +371,49 @@ export default tseslint.config(
|
||||
},
|
||||
},
|
||||
|
||||
// ── hooks/**/*.js — enforcement hooks (#3059) ──────────────────────────────
|
||||
{
|
||||
files: ['hooks/**/*.js', 'hooks/**/*.cjs'],
|
||||
plugins: { n: pluginN, local: localPlugin },
|
||||
languageOptions: { sourceType: 'commonjs', globals: { ...globals.node } },
|
||||
rules: {
|
||||
...js.configs.recommended.rules,
|
||||
'no-var': 'error',
|
||||
'prefer-const': 'warn',
|
||||
'no-unused-vars': ['warn', { argsIgnorePattern: '^_', varsIgnorePattern: '^_', caughtErrors: 'none' }],
|
||||
'no-empty': ['warn', { allowEmptyCatch: true }],
|
||||
'no-useless-escape': 'warn',
|
||||
'n/no-path-concat': 'error',
|
||||
// n/no-process-exit is deliberately OFF for hooks ONLY.
|
||||
//
|
||||
// A hook is a standalone process whose ENTIRE contract is its exit code: the
|
||||
// harness reads exit 2 as "deny". `process.exitCode = N; return;` is not
|
||||
// equivalent — it lets execution continue past the denial, and several exits
|
||||
// here are load-bearing in a way that makes that a behavior change, not a
|
||||
// refactor:
|
||||
// - stdin-timeout guards (e.g. hooks/gsd-read-guard.js, gsd-cursor-subagent-stop.js)
|
||||
// fire from a setTimeout where NOTHING else terminates the process if stdin
|
||||
// never closes;
|
||||
// - hooks/gsd-worktree-path-guard.js exits from a nested `if` whose fallthrough
|
||||
// would otherwise reach a different unconditional exit;
|
||||
// - hooks/gsd-write-guard.js:159-175 documents that pipe writes are async on
|
||||
// Windows, so it deliberately does fs.writeSync(1/2, ...) BEFORE process.exit(2)
|
||||
// to avoid truncation.
|
||||
// ADR-0012 and ADR-0174 scope the "never calls process.exit" convention to the
|
||||
// Command Routing Hub (src/command-routing-hub.cts), not to hooks. Rewriting 89
|
||||
// call sites in enforcement hooks to satisfy a rule aimed at libraries would trade
|
||||
// a real behavior risk for a cosmetic win. See .gsd/phase/chore-3059-eslint-glob-coverage-guard/40-design.md.
|
||||
'n/no-process-exit': 'off',
|
||||
},
|
||||
},
|
||||
|
||||
// ── root *.mjs config files (#3059) ────────────────────────────────────────
|
||||
{
|
||||
files: ['*.mjs'],
|
||||
languageOptions: { sourceType: 'module', globals: { ...globals.node } },
|
||||
rules: { ...js.configs.recommended.rules },
|
||||
},
|
||||
|
||||
// ── tests/**/*.test.cjs ─────────────────────────────────────────────────────
|
||||
{
|
||||
files: ['tests/**/*.cjs'],
|
||||
|
||||
Reference in New Issue
Block a user