* test(#4600): pin explicit-flag-overrides-gate precedence * fix(#4600): explicit --converge overrides the convergence feature gate PLAN_STRATEGY=converge is set only by an explicit --converge/--cross-ai, so gating it on workflow.plan_review_convergence made an explicit operator flag lose to a config default and stop the run with a question-shaped success. The config remains the default for non-flag invocation; the flag now wins, and the step says so instead of gate-and-exit. * test(#4600): pin the precedence contract sentences as written * fix(#4600): keep the precedence sentence on one line The pinned contract phrase wrapped across a line break, so the writer-contract assertion could not match it. * fix(#4600): document the flag-overrides-gate precedence on user surfaces commands/gsd/autonomous.md and docs/COMMANDS.md still said --converge requires workflow.plan_review_convergence=true; both now state the override. Changeset typed Changed with the docs update alongside. * docs(#4600): backfill changeset PR number * fix(#4600): restore the convergence gate mention in user surfaces * test(#4600): pin the dispatched convergence run against the config gate * fix(#4600): override the convergence gate on the dispatched run Emitted-Drift-Ack-Growth: autonomous.md — #4600: the converge dispatch appends --override-gate inside the PLAN_STRATEGY conditional, and the precedence sentences replace the stale fail-fast instruction Emitted-Drift-Ack-Growth: plan-review-convergence.md — #4600: config gate 1.5 honors an explicit --override-gate dispatch (token-anchored) while the standalone veto and config-get default are preserved --------- Co-authored-by: sim <sim@local>
This commit is contained in:
@@ -37,7 +37,7 @@ Optional flags:
|
||||
- `--to N` — stop after phase N completes (halt instead of advancing to next phase).
|
||||
- `--only N` — execute only phase N (single-phase mode).
|
||||
- `--interactive` — run discuss inline with questions (not auto-answered), then dispatch plan→execute as background agents. Keeps the main context lean while preserving user input on decisions.
|
||||
- `--converge` — run each phase's planning step through `gsd-plan-review-convergence` instead of plain `gsd-plan-phase`. Requires `workflow.plan_review_convergence=true`.
|
||||
- `--converge` — run each phase's planning step through `gsd-plan-review-convergence` instead of plain `gsd-plan-phase`. Works even when `workflow.plan_review_convergence` is `false` — the explicit flag overrides the gate; the gate (`workflow.plan_review_convergence=true` enables it) governs the standalone `gsd-plan-review-convergence` command. Without the flag, planning runs `gsd-plan-phase`.
|
||||
- `--cross-ai` — compatibility alias for `--converge`.
|
||||
|
||||
When `--converge` or `--cross-ai` is set, reviewer selector flags supported by `gsd-plan-review-convergence` may be passed through: `--codex`, `--claude`, `--opencode`, `--ollama`, `--lm-studio`, `--llama-cpp`, `--all`, and `--max-cycles N`.
|
||||
|
||||
@@ -11,7 +11,7 @@ allowed-tools:
|
||||
- Agent
|
||||
- Skill
|
||||
- AskUserQuestion
|
||||
requires: [phase, review]
|
||||
requires: [phase, review, autonomous]
|
||||
---
|
||||
|
||||
<objective>
|
||||
@@ -55,7 +55,8 @@ Phase number: extracted from $ARGUMENTS (required)
|
||||
- `--max-cycles N` — Maximum replan→review cycles (default: 3)
|
||||
|
||||
**Feature gate:** This command requires `workflow.plan_review_convergence=true`. Enable with:
|
||||
`gsd config-set workflow.plan_review_convergence true`
|
||||
`gsd config-set workflow.plan_review_convergence true`. A dispatch carrying `--override-gate` —
|
||||
how `/gsd:autonomous --converge` invokes this workflow (#4600) — bypasses the gate for that run.
|
||||
</context>
|
||||
|
||||
<process>
|
||||
|
||||
Reference in New Issue
Block a user