* fix(#586): make ship PHASE_VERIFICATION_INCOMPLETE actionable, drop dead `pass` arm The ship preflight gate blocked with PHASE_VERIFICATION_INCOMPLETE but named no next step, and accepted a `pass` status the verifier never emits. Capture the verification status and route per value (gaps_found / human_needed / missing), mirroring execute-phase's status table; accept only `passed`. Closes #586 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(#586): backfill changeset PR number 650 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#586): scope ship verification status to frontmatter only Codex adversarial review of PR #650 flagged that the status gate grepped `^status:` over the entire VERIFICATION.md, so a `status:` line in the report body (a code block / copied artifact) concatenates into a non-matching value and blocks a genuinely-passed phase with the wrong next action. Restrict extraction to the leading YAML frontmatter block, first match only. Adds a behavioral regression test that runs the gate's own bash pipeline against a passing report whose body contains decoy `status:` lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(#586): drop manual PR ref from changeset body The changelog renderer auto-appends `(#<pr>)` from the fragment's pr: field (scripts/changeset/serialize.cjs, github-release-notes.cjs). The manual trailing `(#586)` produced a double, mismatched ref (issue #586 + auto PR #650); remove it to match the sibling-fragment convention. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(#586): make ship-586 bash-fence regex Windows-safe (CRLF) The behavioral test extracted the gate's bash block with /```bash\n.../ — a literal \n that fails to match Windows CRLF checkouts and trips the windows-test-parity-guard (fenceRegexLiteralNewline). Use ```bash\r?\n and normalize the captured block to LF before running it. Full unit suite: 0 fail. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(#586): run ship-586 bash-pipeline tests on POSIX only On Windows CI the behavioral tests failed: git-bash is present (so the old hasBash guard ran them) but receives a Windows-style tmpdir path it cannot glob, so extraction returned empty. The extraction logic is platform-independent and the gate's bash only runs in a POSIX workflow context, so skip the pipeline execution on win32. POSIX (macOS/Linux) still runs and asserts it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -41,10 +41,15 @@ Verify the work is ready to ship:
|
||||
|
||||
1. **Verification passed?**
|
||||
```bash
|
||||
VERIFICATION=$(cat ${PHASE_DIR}/*-VERIFICATION.md 2>/dev/null)
|
||||
VERIFICATION_FILE=$(ls ${PHASE_DIR}/*-VERIFICATION.md 2>/dev/null | head -1)
|
||||
STATUS=$(sed -n '/^---$/,/^---$/p' "${VERIFICATION_FILE}" 2>/dev/null | grep -m1 "^status:" | cut -d: -f2 | tr -d ' ')
|
||||
```
|
||||
Check for `status: pass` or `status: passed`.
|
||||
If no VERIFICATION.md or status is anything other than `pass` / `passed` (including `human_needed` / `gaps_found`): block with `PHASE_VERIFICATION_INCOMPLETE`; complete or formally re-run verification before shipping.
|
||||
The verifier emits exactly `passed`, `gaps_found`, or `human_needed` (see the status table in `execute-phase.md`); only `passed` may ship. Route on `${STATUS}` — on any non-`passed` value, block with `PHASE_VERIFICATION_INCOMPLETE` and state the matching next action:
|
||||
- `passed` → verification complete; continue to the next preflight check.
|
||||
- `gaps_found` → run `/gsd:plan-phase ${PHASE_NUMBER} --gaps` to plan the fixes, then re-run `/gsd:execute-phase` before shipping.
|
||||
- `human_needed` → complete the manual tests in `${PHASE_DIR}/*-UAT.md`, then re-run the verify step until status is `passed`.
|
||||
- empty (no `*-VERIFICATION.md`) → the verify step never completed; re-run `/gsd:execute-phase`.
|
||||
- any other value → unexpected status `${STATUS}`; re-run `/gsd:execute-phase` verification.
|
||||
|
||||
2. **Clean working tree?**
|
||||
```bash
|
||||
|
||||
Reference in New Issue
Block a user