From 0e1711b460e77553f9ce435ce3123e87158434b6 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Sat, 11 Apr 2026 09:02:01 -0400 Subject: [PATCH] fix(workflow): carve out Other+empty exception from answer_validation retry loop (#2093) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a user selects "Other" in AskUserQuestion with no text body, the answer_validation block was treating the empty result as a generic empty response and retrying the question — causing 2-3 cascading question rounds instead of pausing for freeform user input as intended by the Other handling on line 795. Add an explicit exception in answer_validation: "Other" + empty text signals freeform intent, not a missing answer. The workflow must output one prompt line and stop rather than retry or generate more questions. Fixes #2085 Co-authored-by: Claude Sonnet 4.6 --- get-shit-done/workflows/discuss-phase.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/get-shit-done/workflows/discuss-phase.md b/get-shit-done/workflows/discuss-phase.md index 7d0bb784b..163dcefac 100644 --- a/get-shit-done/workflows/discuss-phase.md +++ b/get-shit-done/workflows/discuss-phase.md @@ -113,6 +113,15 @@ Phase: "API documentation" **IMPORTANT: Answer validation** — After every AskUserQuestion call, check if the response is empty or whitespace-only. If so: + +**Exception — "Other" with empty text:** If the user selected "Other" (or "Chat more") and the response body is empty or whitespace-only, this is NOT an empty answer — it is a signal that the user wants to type freeform input. In this case: +1. Output a single plain-text line: "What would you like to discuss?" +2. STOP generating. Do not call any tools. Do not output any further text. +3. Wait for the user's next message. +4. After receiving their message, reflect it back and continue. +Do NOT retry the AskUserQuestion or generate more questions when "Other" is selected with empty text. + +**All other empty responses:** If the response is empty or whitespace-only (and the user did NOT select "Other"): 1. Retry the question once with the same parameters 2. If still empty, present the options as a plain-text numbered list and ask the user to type their choice number Never proceed with an empty answer.