fix(#3309): restore W027's active-worktree exclusion
The migrated checkW027 (stale worktree) dropped the pre-migration exclusion of the CLI's own current worktree, since a Rule.check(snapshot) has no cwd access (§8.1 rule 1 forbids ambient I/O) — flagged as a disclosed regression during this phase's own design work, then confirmed as a real, fixable gap by the Spec-axis orthogonal review rather than an inherent limitation. Fixes it properly instead of accepting the regression: buildPlanningSnapshot(cwd) already receives cwd as its own input, so exposing it as snapshot.cwd is not new ambient I/O, just surfacing an existing parameter — fully consistent with §8.1 rule 2's "parsed value" allowance. checkW027 now excludes the entry matching snapshot.cwd before flagging, matching the original verify.cts:2233-2242 behavior exactly.
This commit is contained in:
@@ -97,6 +97,13 @@ interface PhaseSnapshot {
|
||||
}
|
||||
|
||||
interface PlanningSnapshot {
|
||||
// The resolved absolute `cwd` this snapshot was built for — `cwd` is
|
||||
// already `buildPlanningSnapshot`'s own input, not a new ambient read, so
|
||||
// exposing it is a "parsed value" per §8.1 rule 2, not §8.1 rule 1 ambient
|
||||
// I/O. Backs W027's active-worktree exclusion
|
||||
// (`src/health-diagnostic-rules/worktree-health.cts`), the one pre-migration
|
||||
// behavior (`verify.cts:2233-2242`) that genuinely needed the caller's cwd.
|
||||
cwd: string;
|
||||
milestone: ReturnType<typeof getMilestoneInfo>;
|
||||
phaseDirs: ReturnType<typeof listMilestonePhaseDirs>;
|
||||
phases: { value: PhaseSnapshot[]; scope: Scope };
|
||||
@@ -668,6 +675,7 @@ function buildPlanningSnapshot(cwd: string): PlanningSnapshot {
|
||||
const stateFields = buildStateFields(paths.state);
|
||||
|
||||
return {
|
||||
cwd: path.resolve(cwd),
|
||||
milestone,
|
||||
phaseDirs,
|
||||
phases: {
|
||||
|
||||
Reference in New Issue
Block a user