From 161aa61137d2e3a003bbaca104e45a3508404e56 Mon Sep 17 00:00:00 2001 From: Solvely-Colin Date: Tue, 3 Feb 2026 12:10:57 -0500 Subject: [PATCH] fix: researcher agent always writes RESEARCH.md regardless of commit_docs Fixes #343 The agent was misinterpreting commit_docs=false as 'skip file write' when it should only skip git commit operations. Changes: - Explicitly state Write tool is mandatory in Step 5 - Clarify commit_docs only affects git operations, not file writes - Rename Step 6 to indicate it's optional - Make the file-write-then-commit order explicit --- agents/gsd-phase-researcher.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/agents/gsd-phase-researcher.md b/agents/gsd-phase-researcher.md index f3feb7bc2..97b5a1327 100644 --- a/agents/gsd-phase-researcher.md +++ b/agents/gsd-phase-researcher.md @@ -526,6 +526,8 @@ Run through verification protocol checklist: ## Step 5: Write RESEARCH.md +**ALWAYS use the Write tool to persist RESEARCH.md to disk.** This is mandatory regardless of `commit_docs` setting. + Use the output format template. Populate all sections with verified findings. **CRITICAL: User Constraints Section MUST be FIRST** @@ -553,9 +555,11 @@ Write to: `$PHASE_DIR/$PADDED_PHASE-RESEARCH.md` Where `PHASE_DIR` is the full path (e.g., `.planning/phases/01-foundation`) -## Step 6: Commit Research +⚠️ **The `commit_docs` setting only controls git commits, NOT file writing.** Always write the file first. -**If `COMMIT_PLANNING_DOCS=false`:** Skip git operations, log "Skipping planning docs commit (commit_docs: false)" +## Step 6: Commit Research (optional) + +**If `COMMIT_PLANNING_DOCS=false`:** Skip git operations only. The file MUST already be written in Step 5. **If `COMMIT_PLANNING_DOCS=true` (default):**