golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2376): emit absolute subagent-facing paths from init/state, convert workflow literals (#2428)

Browse Source 
* fix(#2376): emit absolute subagent-facing init/state paths

Make init.* and state.* path fields absolute rather than cwd-relative
so subagent prompts resolve correctly regardless of working directory.
Adds intel_dir/conflicts_path/requirements_path/roadmap_path/state_path
to cmdInitIngestDocs, an absolute debug_dir to cmdStateLoad, and
replaces bare .planning/... literals in 12 workflow Agent() prompt
blocks with the absolute init-JSON path fields. Includes decoy-cwd
regression tests and realpath'd tmpdir fixtures for macOS.

Squashed rebase of the #2376 commit series onto a fresh origin/next
(previous merge ee25543a1 was against a now-stale next).

* chore(#2376): add changeset

* chore(#2376): regenerate golden fixtures + workflow size baseline

Regenerated after rebasing the absolute-path fix onto current next
(picks up #2351's run-with-timeout content in execute-phase.md too).

* fix(#2376): trim execute-phase.md redundancy to stay under the size margin

* chore(#2376): regenerate golden/size baseline after rebase onto next
This commit is contained in:
Tom Boucher
2026-07-19 15:43:48 -04:00
committed by GitHub
parent d04e287fa9
commit 1a46bc068a
42 changed files with 905 additions and 510 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/onboard-command.test.cjs
View File

@@ -7,7 +7,7 @@ const { describe, test, beforeEach, afterEach } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const { runGsdTools, cleanup } = require('./helpers.cjs');
const { runGsdTools, cleanup, absPlanningPath } = require('./helpers.cjs');
const { createFixture } = require('./fixtures/index.cjs');
const ROOT = path.join(__dirname, '..');
@@ -18,7 +18,12 @@ describe('init onboard public CLI projection', () => {
let tmpDir;
beforeEach(() => {
tmpDir = createFixture({ planning: false, projectDoc: false });
// #2376 macOS fix: realpath the fixture root so absolute path-field
// assertions (absPlanningPath comparisons below) match the code's
// process.cwd()-anchored output — macOS's tmpdir is a symlink
// (/var/... -> /private/var/...) that a spawned child resolves via
// realpath but createFixture() does not. No-op on Linux (no symlink).
tmpDir = fs.realpathSync(createFixture({ planning: false, projectDoc: false }));
});
afterEach(() => {
@@ -142,7 +147,7 @@ describe('init onboard public CLI projection', () => {
assert.strictEqual(parsed.has_codebase_map, true);
assert.deepStrictEqual(parsed.missing_codebase_map_files, []);
assert.strictEqual(parsed.onboarding_summary_exists, true);
assert.strictEqual(parsed.onboarding_summary_path, '.planning/onboarding/SUMMARY.md');
assert.strictEqual(parsed.onboarding_summary_path, absPlanningPath(tmpDir, 'onboarding', 'SUMMARY.md'));
assert.strictEqual(parsed.text_mode, true);
});
@@ -224,7 +229,7 @@ describe('init onboard public CLI projection', () => {
// Once project setup is complete, a fast map must not misroute back to the
// pre-new-project complete-map handoff; onboarding advances to the summary.
assert.strictEqual(parsed.next_action.kind, 'write-summary');
assert.strictEqual(parsed.next_action.summary_path, '.planning/onboarding/SUMMARY.md');
assert.strictEqual(parsed.next_action.summary_path, absPlanningPath(tmpDir, 'onboarding', 'SUMMARY.md'));
});
test('fast mode routes incomplete planning to partial-planning before the complete-map gate (regression #1990: fast map gate misroute)', () => {
@@ -259,7 +264,8 @@ describe('init onboard public CLI projection', () => {
});
cleanup(tmpDir);
tmpDir = createFixture({ planning: false, projectDoc: false });
// #2376 macOS fix: see beforeEach above.
tmpDir = fs.realpathSync(createFixture({ planning: false, projectDoc: false }));
fs.mkdirSync(path.join(tmpDir, 'docs', 'adr'), { recursive: true });
fs.writeFileSync(path.join(tmpDir, 'docs', 'adr', '0001-runtime.md'), '# ADR: Runtime\n');
result = runGsdTools('init onboard --raw', tmpDir, { HOME: tmpDir });
@@ -271,7 +277,8 @@ describe('init onboard public CLI projection', () => {
});
cleanup(tmpDir);
tmpDir = createFixture({ planning: false, projectDoc: false });
// #2376 macOS fix: see beforeEach above.
tmpDir = fs.realpathSync(createFixture({ planning: false, projectDoc: false }));
result = runGsdTools('init onboard --raw', tmpDir, { HOME: tmpDir });
assert.ok(result.success, `init onboard should succeed: ${result.error}`);
assert.deepStrictEqual(JSON.parse(result.output).next_action, {
@@ -281,7 +288,8 @@ describe('init onboard public CLI projection', () => {
});
cleanup(tmpDir);
tmpDir = createFixture({ planning: false, projectDoc: false });
// #2376 macOS fix: see beforeEach above.
tmpDir = fs.realpathSync(createFixture({ planning: false, projectDoc: false }));
fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });
fs.writeFileSync(path.join(tmpDir, '.planning', 'PROJECT.md'), '# Project\n');
fs.writeFileSync(path.join(tmpDir, '.planning', 'ROADMAP.md'), '# Roadmap\n');
@@ -301,7 +309,7 @@ describe('init onboard public CLI projection', () => {
assert.ok(result.success, `init onboard should succeed: ${result.error}`);
assert.deepStrictEqual(JSON.parse(result.output).next_action, {
kind: 'write-summary',
summary_path: '.planning/onboarding/SUMMARY.md',
summary_path: absPlanningPath(tmpDir, 'onboarding', 'SUMMARY.md'),
reason: 'Onboarding summary is missing.',
});