golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #1568 from behruznassre/fix/1514-retired-phase-total-phases

Browse Source 
fix(#1514): exclude retired/folded phases from progress.total_phases
This commit is contained in:
Tom Boucher
2026-06-23 10:55:41 -04:00
committed by GitHub
parent afabb7c526 da2de3a183
commit 1b95762661
3 changed files with 473 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/humble-cranes-wake.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 1568
---
**Shipped milestones with a retired/folded phase now reach 100%** — a phase struck through in ROADMAP (marked `[x]`, with a directory but no completion artifact) was counted in `progress.total_phases` but could never be counted complete, freezing the milestone below 100% (e.g. 5/6 = 83%) with `state sync --verify` reporting no drift. Both STATE counting paths (`state json` and `state sync`) now exclude retired phases — detected from GFM strikethrough whose subject is the phase on a checklist/heading line — from both the phase-dir set and the heading count, via the canonical phase-id helpers so numeric, decimal, and project-code IDs match alike. (#1514)