golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

feat(#2162): opt-in compact GSD-state format for the statusline (#2175)

Browse Source 
* feat(#2162): opt-in compact GSD-state format for the statusline

New statusline.state_format config, enum full|compact (default full —
existing rendering untouched). "compact" renders the state segment as
"<version> · P<phase>/<total> · <status>", e.g. "v1.12 · P7/12 ·
executing" — dropping the milestone name and progress bar (the two
biggest width costs) and collapsing narrative statuses to a single
keyword. Per the #2162 approval conditions, the keyword set is the
canonical vocabulary from normalizeStateStatus() in state-document.cjs
(discussing/planning/executing/verifying/completed/paused) — no
parallel hand-rolled list, so the vocabularies can't drift — and the
canonical stuck state "paused" renders uppercase as PAUSED (no new
"blocked" lifecycle state). Statuses the normalizer passes through
unrecognized fall back to their first word capped at 16 chars.
Lifecycle scenes preserved: active_phase wins over the body phase
number, milestone completion renders "complete", idle-with-next-action
renders "next <action> <phases>".

Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg

* docs(#2162): changeset fragment for PR #2175

* fix(#2162): review fixes — ENUM_KEYS coverage, cap boundary tests, changeset format

- register statusline.state_format in the fix-1628 coercion-bypass matrix
- 15/16/17-char boundary tests for the shortGsdStatus fallback cap
- changeset body ends with the (#2162) citation per house convention

Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg

* fix(#2162): round-2 review fixes — scene exclusivity, direct config-set coverage

- compact renderer gates the milestone-complete scene behind the absence of
  an in-flight phase id, mirroring formatGsdState's if/else precedence
  (Scene 1 beats Scene 3); regression test covers the non-atomic
  active_phase + percent=100 STATE.md shape
- direct config-set accept/reject test for statusline.state_format plain
  strings (ENUM_KEYS matrix covers only the JSON coercion shapes)

Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg

* test: regenerate golden-install-parity fixtures for the statusline hook change

Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg

* fix(#2162): complete-scene gate matches formatGsdState exactly (+property tests)

Re-review Major: gating done on !phaseId held completion back for the
legacy phaseNum shape — formatGsdState reaches Scene 3 on percent=100
regardless of phaseNum, so compact must too. Gate is now !s.activePhase.
The phaseNum-only test now expects 'complete' and cross-checks the full
renderer; a parity test feeds identical inputs to both renderers.
Re-review Minor: shortGsdStatus gets fast-check property coverage
(totality, canonical fixed points, separator safety, fallback shape).
Golden fixtures regenerated for the hook byte change.

Claude-Session: https://claude.ai/code/session_01Hme55Pvq6BhpgwBcyC5HAg
This commit is contained in:
Cody Anderson
2026-07-14 19:09:24 -06:00
committed by GitHub
parent eec9efc351
commit 20ff405cb3
26 changed files with 432 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/capability-registry.test.cjs
View File

@@ -5952,6 +5952,7 @@ const ENUM_KEYS = [
{ key: 'workflow.human_verify_mode', member: 'mid-flight' },
{ key: 'workflow.context_guard_mode', member: 'off' },
{ key: 'statusline.context_position', member: 'front' },
{ key: 'statusline.state_format', member: 'compact' },
{ key: 'code_quality.fallow.scope', member: 'phase' },
{ key: 'code_quality.fallow.profile', member: 'standard' },
{ key: 'plan_review.source_grounding_authority', member: 'grep' },

4
tests/fixtures/golden-install-parity/antigravity.json vendored
View File

@@ -41,7 +41,7 @@
"gsd-core/bin/gsd-tools.cjs": "efc88e7691c6c3e6",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "8bc541aabc2e143c",
@@ -328,7 +328,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "eefea61f9b0e464c",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "e284419f4ce60383",
"hooks/gsd-statusline.js": "ba8422027f710711",
"hooks/gsd-update-banner.js": "55143a25f978f301",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

4
tests/fixtures/golden-install-parity/augment.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -399,7 +399,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "c8800819f7443a15",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "05144fab95be6e45",
"hooks/gsd-statusline.js": "85141ec6a067fce2",
"hooks/gsd-update-banner.js": "55143a25f978f301",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

4
tests/fixtures/golden-install-parity/claude-local.json vendored
View File

@@ -111,7 +111,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -398,7 +398,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "00d2449afefd2e5f",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "5d2c06224db20d23",
"hooks/gsd-statusline.js": "bc03b97ef19328c0",
"hooks/gsd-update-banner.js": "b457746cb76c1957",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

4
tests/fixtures/golden-install-parity/claude.json vendored
View File

@@ -40,7 +40,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -327,7 +327,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "00d2449afefd2e5f",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "5d2c06224db20d23",
"hooks/gsd-statusline.js": "bc03b97ef19328c0",
"hooks/gsd-update-banner.js": "b457746cb76c1957",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

2
tests/fixtures/golden-install-parity/cline.json vendored
View File

@@ -44,7 +44,7 @@
"gsd-core/bin/gsd-tools.cjs": "49dfaa890fdd5627",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

4
tests/fixtures/golden-install-parity/codebuddy.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -399,7 +399,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "7f7a7615b303369a",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "49fe17737e4565f9",
"hooks/gsd-statusline.js": "7cdf1ae0e5b17969",
"hooks/gsd-update-banner.js": "55143a25f978f301",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

2
tests/fixtures/golden-install-parity/codex.json vendored
View File

@@ -147,7 +147,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

2
tests/fixtures/golden-install-parity/copilot.json vendored
View File

@@ -42,7 +42,7 @@
"gsd-core/bin/gsd-tools.cjs": "efc88e7691c6c3e6",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "10226e9512dd44bf",

2
tests/fixtures/golden-install-parity/cursor.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "50658d517405cd63",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

4
tests/fixtures/golden-install-parity/hermes.json vendored
View File

@@ -41,7 +41,7 @@
"gsd-core/bin/gsd-tools.cjs": "12ee14a48b678d2b",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -328,7 +328,7 @@
"hooks/gsd-read-guard.js": "1f58b020a91f032b",
"hooks/gsd-read-injection-scanner.js": "f358eca3fa1eab24",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "815e107016e994a1",
"hooks/gsd-statusline.js": "3f59c6becf124608",
"hooks/gsd-update-banner.js": "b457746cb76c1957",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

2
tests/fixtures/golden-install-parity/kilo.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

4
tests/fixtures/golden-install-parity/kimi.json vendored
View File

@@ -18,7 +18,7 @@
".kimi/hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
".kimi/hooks/gsd-read-injection-scanner.js": "c519598b9257aafa",
".kimi/hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
".kimi/hooks/gsd-statusline.js": "e0a50e21a1e9aeb6",
".kimi/hooks/gsd-statusline.js": "fb90ca297b60bddf",
".kimi/hooks/gsd-update-banner.js": "55143a25f978f301",
".kimi/hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
".kimi/hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",
@@ -105,7 +105,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

4
tests/fixtures/golden-install-parity/opencode.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -399,7 +399,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "f72060dfe035f706",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "f93d64704cba14fd",
"hooks/gsd-statusline.js": "982cbb17444935fa",
"hooks/gsd-update-banner.js": "55143a25f978f301",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

4
tests/fixtures/golden-install-parity/pi.json vendored
View File

@@ -8,7 +8,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -295,7 +295,7 @@
"hooks/gsd-read-guard.js": "9e423cd03e2d1b16",
"hooks/gsd-read-injection-scanner.js": "f454242c010804cf",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "239c1b15d1ff4ef9",
"hooks/gsd-statusline.js": "b59f79b77f53b2a0",
"hooks/gsd-update-banner.js": "55143a25f978f301",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

4
tests/fixtures/golden-install-parity/qwen.json vendored
View File

@@ -41,7 +41,7 @@
"gsd-core/bin/gsd-tools.cjs": "205830afac36f33a",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",
@@ -328,7 +328,7 @@
"hooks/gsd-read-guard.js": "2c8d417d12b51040",
"hooks/gsd-read-injection-scanner.js": "396574bd25e99ff9",
"hooks/gsd-session-state.sh": "e54379ba86bf1b6d",
"hooks/gsd-statusline.js": "e9cfc9ddfffabe4d",
"hooks/gsd-statusline.js": "390b3601312345ae",
"hooks/gsd-update-banner.js": "b457746cb76c1957",
"hooks/gsd-validate-commit.sh": "bf5dd61d33cb3a38",
"hooks/gsd-windsurf-pre-command.js": "948be1c6d14c79cd",

2
tests/fixtures/golden-install-parity/trae.json vendored
View File

@@ -41,7 +41,7 @@
"gsd-core/bin/gsd-tools.cjs": "c8283c0c8888e357",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

2
tests/fixtures/golden-install-parity/windsurf.json vendored
View File

@@ -41,7 +41,7 @@
"gsd-core/bin/gsd-tools.cjs": "f21bb9ba5e55f642",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

2
tests/fixtures/golden-install-parity/zcode.json vendored
View File

@@ -112,7 +112,7 @@
"gsd-core/bin/gsd-tools.cjs": "06c046925b7156b7",
"gsd-core/bin/gsd_run": "62d9b647ede212e6",
"gsd-core/bin/shared/config-defaults.manifest.json": "517e6a7c1e9f4f16",
"gsd-core/bin/shared/config-schema.manifest.json": "ef818b1afd7ee8e4",
"gsd-core/bin/shared/config-schema.manifest.json": "0109a5a9866a24e0",
"gsd-core/bin/shared/model-catalog.json": "b55176ca044728d3",
"gsd-core/bin/shared/runtime-aliases.manifest.json": "2df2c5ac1957911a",
"gsd-core/bin/verify-reapply-patches.cjs": "caec5dbce11e3904",

66
tests/gsd-statusline-state.property.test.cjs Normal file
View File

@@ -0,0 +1,66 @@
'use strict';
/**
* Property tests for the compact GSD-state status normalizer (#2162).
*
* shortGsdStatus() collapses free-text STATE.md statuses to a canonical
* keyword (or a capped first-word fallback). As a parsing/normalization
* contract it gets property coverage per the repo testing rules, alongside
* the example-based cases in gsd-statusline.test.cjs.
*/
const { test, describe } = require('node:test');
const fc = require('./helpers/fast-check-setup.cjs');
const { shortGsdStatus } = require('../hooks/gsd-statusline.js');
const CANONICAL = ['discussing', 'planning', 'executing', 'verifying', 'completed', 'paused'];
describe('shortGsdStatus properties (#2162)', () => {
test('totality: any string input yields null or a short non-empty string', () => {
fc.assert(
fc.property(fc.string(), (s) => {
const out = shortGsdStatus(s);
if (out === null) return true;
return typeof out === 'string' && out.length > 0 && out.length <= 16;
}),
);
});
test('canonical statuses are fixed points (paused shouts as PAUSED)', () => {
fc.assert(
fc.property(fc.constantFrom(...CANONICAL), (canonical) => {
const out = shortGsdStatus(canonical);
return canonical === 'paused' ? out === 'PAUSED' : out === canonical;
}),
);
});
test('output never contains whitespace or separator characters', () => {
// The compact line joins segments with ' · ' — a status containing
// whitespace or the separator would corrupt the segment structure.
fc.assert(
fc.property(fc.string(), (s) => {
const out = shortGsdStatus(s);
return out === null || !/[\s·—–]/.test(out);
}),
);
});
test('unrecognized free text falls back to its first word, capped at 16', () => {
// Alphabetic words that are not canonical and don't contain canonical
// trigger substrings exercise the fallback path deterministically.
const word = fc.stringMatching(/^[A-Za-z]{1,32}$/).filter((w) => {
const lower = w.toLowerCase();
return !CANONICAL.some((c) => lower.includes(c.slice(0, 4)));
});
fc.assert(
fc.property(word, word, (first, second) => {
const out = shortGsdStatus(`${first} ${second}`);
// The normalizer may still map some phrasings to a canonical keyword
// (e.g. synonym tables); otherwise the first word survives, capped.
return out === null || CANONICAL.concat('PAUSED').includes(out) || out === first.slice(0, 16);
}),
);
});
});

238
tests/gsd-statusline.test.cjs
View File

@@ -1365,6 +1365,244 @@ test('config-set statusline.show_context_tokens yes → rejected', () => {
}
// ────────────────────────────────────────────────────────────────────────
// Compact GSD-state format (statusline.state_format)
// ────────────────────────────────────────────────────────────────────────
{
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const os = require('node:os');
const path = require('node:path');
const { runGsdTools, createTempProject, cleanup } = require('./helpers.cjs');
const statusline = require('../hooks/gsd-statusline.js');
const { shortGsdStatus, formatGsdStateCompact, formatGsdState } = statusline;
const { VALID_CONFIG_KEYS } = require('../gsd-core/bin/lib/config-schema.cjs');
describe('config schema: statusline.state_format', () => {
test('registers statusline.state_format', () => {
assert.ok(
VALID_CONFIG_KEYS.has('statusline.state_format'),
'statusline.state_format must be in VALID_CONFIG_KEYS',
);
});
// Direct config-set write-path coverage, mirroring the sibling
// context_position tests (the ENUM_KEYS matrix covers only the JSON
// coercion-bypass shapes, not the plain-string paths).
test('config-set accepts "compact" and rejects an invalid plain string', () => {
const tmpDir = createTempProject();
try {
const ok = runGsdTools(['config-set', 'statusline.state_format', 'compact'], tmpDir);
assert.ok(ok.success, ok.error);
const bad = runGsdTools(['config-set', 'statusline.state_format', 'tiny'], tmpDir);
assert.equal(bad.success, false, 'invalid enum value must be rejected');
assert.ok(
/statusline\.state_format|Invalid/i.test(bad.error),
`stderr must reference key or "Invalid"; got: ${bad.error}`,
);
} finally {
cleanup(tmpDir);
}
});
});
describe('shortGsdStatus', () => {
test('returns null for empty input', () => {
assert.equal(shortGsdStatus(null), null);
assert.equal(shortGsdStatus(''), null);
assert.equal(shortGsdStatus(undefined), null);
});
test('paused — the canonical stuck state — wins and renders uppercase (#2162 condition)', () => {
assert.equal(shortGsdStatus('paused — waiting on credentials'), 'PAUSED');
assert.equal(shortGsdStatus('stopped by user'), 'PAUSED');
});
test('collapses lifecycle narratives to canonical keywords via normalizeStateStatus', () => {
assert.equal(shortGsdStatus('Executing phase 7 of the parser milestone'), 'executing');
assert.equal(shortGsdStatus('Ready to plan next phase'), 'planning');
assert.equal(shortGsdStatus('Discussing scope with user'), 'discussing');
assert.equal(shortGsdStatus('Verifying UAT criteria'), 'verifying');
assert.equal(shortGsdStatus('Work complete'), 'completed');
});
test('matches the canonical vocabulary exactly — no drift from normalizeStateStatus', () => {
const { normalizeStateStatus } = require('../gsd-core/bin/lib/state-document.cjs');
for (const canonical of ['discussing', 'planning', 'executing', 'verifying', 'completed', 'paused']) {
const rendered = shortGsdStatus(canonical);
const expected = canonical === 'paused' ? 'PAUSED' : canonical;
assert.equal(rendered, expected);
assert.equal(normalizeStateStatus(canonical, null), canonical,
`canonical vocabulary changed upstream: ${canonical}`);
}
});
test('unknown shapes fall back to the first word, capped at 16 chars', () => {
assert.equal(shortGsdStatus('reticulating splines'), 'reticulating');
assert.equal(shortGsdStatus('supercalifragilisticexpialidocious state'), 'supercalifragili');
});
test('16-char cap boundary: limit-1 / limit / limit+1', () => {
assert.equal(shortGsdStatus('x'.repeat(15)), 'x'.repeat(15));
assert.equal(shortGsdStatus('x'.repeat(16)), 'x'.repeat(16));
assert.equal(shortGsdStatus('x'.repeat(17)), 'x'.repeat(16));
});
});
describe('formatGsdStateCompact', () => {
test('renders version · phase/total · status', () => {
const out = formatGsdStateCompact({
milestone: 'v1.12', phaseNum: '7', phaseTotal: '12',
status: 'Executing phase 7 — building the parser',
});
assert.equal(out, 'v1.12 · P7/12 · executing');
});
test('prefers lifecycle active_phase over body phase number', () => {
const out = formatGsdStateCompact({
milestone: 'v2.0', activePhase: '4.5', phaseNum: '4', status: 'executing',
});
assert.equal(out, 'v2.0 · P4.5 · executing');
});
test('paused state renders uppercase in the compact line', () => {
const out = formatGsdStateCompact({
milestone: 'v2.0', activePhase: '4.5', status: 'paused — waiting on review',
});
assert.equal(out, 'v2.0 · P4.5 · PAUSED');
});
test('milestone completion renders "complete"', () => {
assert.equal(formatGsdStateCompact({ milestone: 'v2.0', percent: '100' }), 'v2.0 · complete');
assert.equal(
formatGsdStateCompact({ milestone: 'v2.0', completedPhases: '5', totalPhases: '5' }),
'v2.0 · complete');
});
test('scene exclusivity: an in-flight phase wins over milestone-complete', () => {
// Non-atomic STATE.md edits can leave active_phase populated alongside
// percent=100 — the compact format must mirror formatGsdState's
// if/else-chain precedence (Scene 1 beats Scene 3), never render both.
const state = {
milestone: 'v2.0', activePhase: '4.5', percent: '100', status: 'executing',
};
assert.equal(formatGsdStateCompact(state), 'v2.0 · P4.5 · executing');
const full = formatGsdState(state);
assert.ok(!/(complete)/.test(full) || !/4\.5/.test(full),
`full format must not co-render phase and complete either; got: ${full}`);
// The legacy body-phase shape (phaseNum, no activePhase) does NOT hold
// completion back — formatGsdState reaches Scene 3 on percent=100
// regardless of phaseNum, and compact must agree (#2175 re-review Major).
const legacyDone = { milestone: 'v2.0', phaseNum: '5', phaseTotal: '5', percent: '100', status: 'verifying' };
assert.equal(formatGsdStateCompact(legacyDone), 'v2.0 · P5/5 · complete');
assert.ok(formatGsdState(legacyDone).includes('milestone complete'),
'parity: full format must render Scene 3 for the same input');
});
test('parity: both renderers agree on completion for the same input', () => {
// Feed identical state objects to both renderers and require they agree
// on whether the milestone reads as complete — the drift guard for the
// parallel rendering surfaces.
const cases = [
{ milestone: 'v2.0', percent: '100' },
{ milestone: 'v2.0', phaseNum: '5', phaseTotal: '5', percent: '100', status: 'verifying' },
{ milestone: 'v2.0', completedPhases: '5', totalPhases: '5' },
{ milestone: 'v2.0', activePhase: '4.5', percent: '100', status: 'executing' },
{ milestone: 'v1.9', percent: '40', status: 'executing', phaseNum: '2', phaseTotal: '5' },
];
for (const s of cases) {
const fullDone = formatGsdState(s).includes('milestone complete');
const compactDone = / complete$|^complete$/.test(formatGsdStateCompact(s));
assert.equal(compactDone, fullDone,
`completion parity diverged for ${JSON.stringify(s)}`);
}
});
test('idle with queued next action renders "next <action> <phases>"', () => {
const out = formatGsdStateCompact({
milestone: 'v2.0', nextAction: 'execute-phase', nextPhases: ['4.5', '4.6'],
});
assert.equal(out, 'v2.0 · next execute-phase 4.5/4.6');
});
test('empty state renders empty string', () => {
assert.equal(formatGsdStateCompact({}), '');
});
test('drops the milestone name and progress bar the full format shows', () => {
const state = {
milestone: 'v1.9', milestoneName: 'Code Quality', percent: '40',
status: 'executing', phaseNum: '2', phaseTotal: '5',
};
const full = formatGsdState(state);
const compact = formatGsdStateCompact(state);
assert.ok(full.includes('Code Quality'), `full keeps name; got: ${full}`);
assert.ok(!compact.includes('Code Quality'), `compact drops name; got: ${compact}`);
assert.ok(!compact.includes('█'), `compact drops bar; got: ${compact}`);
});
});
describe('state_format via renderStatusline', () => {
function makeProject(stateFormat) {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'state-fmt-'));
fs.mkdirSync(path.join(dir, '.planning'), { recursive: true });
if (stateFormat !== undefined) {
fs.writeFileSync(
path.join(dir, '.planning', 'config.json'),
JSON.stringify({ statusline: { state_format: stateFormat } }),
);
}
fs.writeFileSync(path.join(dir, '.planning', 'STATE.md'), [
'---',
'milestone: v1.9',
'milestone_name: Code Quality',
'status: executing',
'---',
'',
'Phase: 2 of 5 (parser-rewrite)',
'',
].join('\n'));
return dir;
}
test('compact format drops the milestone name', () => {
const dir = makeProject('compact');
try {
const out = statusline.renderStatusline({
model: { display_name: 'Claude' },
workspace: { current_dir: dir },
});
assert.ok(out.includes('v1.9 · P2/5 · executing'), `expected compact state; got: ${out}`);
assert.ok(!out.includes('Code Quality'), `expected no milestone name; got: ${out}`);
} finally {
cleanup(dir);
}
});
test('default (key absent) keeps the full format unchanged', () => {
const dir = makeProject(undefined);
try {
const out = statusline.renderStatusline({
model: { display_name: 'Claude' },
workspace: { current_dir: dir },
});
assert.ok(out.includes('Code Quality'), `expected full format; got: ${out}`);
} finally {
cleanup(dir);
}
});
test('explicit "full" matches the default rendering', () => {
const dirDefault = makeProject(undefined);
const dirFull = makeProject('full');
try {
const input = (dir) => ({
model: { display_name: 'Claude' },
workspace: { current_dir: dir },
});
const a = statusline.renderStatusline(input(dirDefault));
const b = statusline.renderStatusline(input(dirFull));
// Same STATE.md content → same rendered middle segment (the trailing
// directory basename differs per temp dir, so compare with it removed)
assert.equal(
a.replace(path.basename(dirDefault), ''),
b.replace(path.basename(dirFull), ''));
} finally {
cleanup(dirDefault);
cleanup(dirFull);
}
});
});
}
// ────────────────────────────────────────────────────────────────────────
// Compact 1M model badge
// ────────────────────────────────────────────────────────────────────────