* feat(#3464): widen no-source-grep to detect regex.exec() on tracked text Adds an execCall kind alongside the existing regexTest detection -- regex.exec(tracked) was invisible to the rule while regex.test(tracked) was already caught, despite both reading a source-derived string through a regex. Measured: 4 previously-invisible sites across 2 files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * test(#3464): migrate 4 sites newly flagged by the exec() widening docs-hooks-table-parity.test.cjs's three regex-extraction loops are site-scoped marked (source-text-is-the-product) -- the dynamic preToolEvent/postToolEvent dialect branching they mirror is explicitly documented as not statically parseable, so a literal-pattern mirror is the practical minimum-cost check. no-bare-gsd-tools-command-position.test.cjs's readRouterVerbs() now requires HOST_COMMAND_ROUTERS directly instead of regex-walking gsd-tools.cjs's source text -- the same accessor three other suites already use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3464): pay down 6 grandfathered uncited allow-test-rule markers Two were genuinely load-bearing (suppressing a real detected violation) and just needed a citation added -- phase6-capstone-conformance.test.cjs, runtime-name-policy.test.cjs, both now (#3464). Four were dead-weight file-header markers suppressing nothing -- each file's real effective sites are covered by separate, already-cited markers elsewhere in the same file. Deleted outright rather than cited, per Phase 1's own precedent (remove non-load-bearing markers instead of grandfathering them forever) -- codex-config.test.cjs (two copies), gsd-check-update-worker-platform-gate.test.cjs, orphaned-hooks.test.cjs, settings-jsonc.test.cjs. allowlist.json: 134 -> 128 entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore(#3464): re-baseline effective-exemption ceiling to 84 The exec() widening's 3 newly-marked sites are now suppressed and counted; ceiling rises 81 -> 84, the exact measured high-water mark. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3464): correct citation and restore a wrongly-deleted marker Two review corrections, both found by the orthogonal review pass: - docs-hooks-table-parity.test.cjs's 3 new exec() markers cited #3464 (mechanically "the phase that widened the rule") when the file's own established, correct reference is #3839 (the issue this whole test exists to enforce, already cited in its file header) -- fixed to match. - gsd-check-update-worker-platform-gate.test.cjs's deleted file-header marker was NOT dead weight: its codeOnly() helper wraps readFileSync and is called inline as an assert argument, a genuine source-grep pattern on real .cjs/.js source that the rule cannot currently see (helper-function indirection is a distinct blind spot from anything Phase 7/8 measured) -- CONTRIBUTING.md is explicit that "unverified" is not the same as "vestigial." Restored, site-scoped this time (directly above codeOnly(), not as an inert file-header comment) and cited (#3103, the issue the file's own docstring already references). codex-config.test.cjs's two deletions and orphaned-hooks.test.cjs's / settings-jsonc.test.cjs's deletions were independently re-verified and stand: their flagged lines read generated .toml/.json OUTPUT, not source, or have no residual pattern at all. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: sim <sim@local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -61,26 +61,26 @@ const SCAN_DIRS = [
|
||||
];
|
||||
|
||||
// Derive the verb set the bare-call guard matches against. Most top-level
|
||||
// verbs live in the host-command router table as `'verb': routeHandler` entries
|
||||
// (~70); this reads those dynamically so new router verbs are covered the moment
|
||||
// they land. A handful of verbs are dispatched as FAMILIES (their own
|
||||
// `command === 'verb'` arm, not a route-table entry): `query` (line ~2876),
|
||||
// `intel`, `verify`, and `graphify`. These are stable, documented families, so
|
||||
// they are supplemented explicitly here rather than parsed from the help string
|
||||
// (whose prose mixes real verbs with English words like "for"/"output"/"working",
|
||||
// producing noise). If a family verb is ever promoted into the route table the
|
||||
// union dedupes harmlessly; if a NEW family verb is added it must be added here.
|
||||
// verbs live in the host-command router table (`HOST_COMMAND_ROUTERS`, ~70
|
||||
// entries, exported by gsd-tools.cjs for exactly this kind of test); this
|
||||
// reads that real exported object directly so new router verbs are covered
|
||||
// the moment they land. A handful of verbs are dispatched as FAMILIES (their
|
||||
// own `command === 'verb'` arm, not a route-table entry): `query` (line
|
||||
// ~2876), `intel`, `verify`, and `graphify`. These are stable, documented
|
||||
// families, so they are supplemented explicitly here rather than parsed from
|
||||
// the help string (whose prose mixes real verbs with English words like
|
||||
// "for"/"output"/"working", producing noise). If a family verb is ever
|
||||
// promoted into the route table the union dedupes harmlessly; if a NEW
|
||||
// family verb is added it must be added here.
|
||||
//
|
||||
// Sorted longest-first so a hyphenated verb (`verify-summary`) is preferred over
|
||||
// its prefix (`verify`) — the exact ordering bug that let `verify-summary` slip
|
||||
// past a fixed 6-verb list during the first #2751 pass.
|
||||
const FAMILY_DISPATCHED_VERBS = ['query', 'intel', 'verify', 'graphify'];
|
||||
function readRouterVerbs() {
|
||||
const src = fs.readFileSync(ROUTER_PATH, 'utf8');
|
||||
const re = /(?:'([a-z][a-z-]*)'|([a-z][a-z-]*))\s*:\s*route[A-Z]\w*/g;
|
||||
const { HOST_COMMAND_ROUTERS } = require(ROUTER_PATH);
|
||||
const verbs = new Set(FAMILY_DISPATCHED_VERBS);
|
||||
let m;
|
||||
while ((m = re.exec(src)) !== null) verbs.add(m[1] || m[2]);
|
||||
for (const verb of Object.keys(HOST_COMMAND_ROUTERS)) verbs.add(verb);
|
||||
return [...verbs].sort((a, b) => b.length - a.length);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user