golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(#3170): anchor milestone one-liner extraction to a summary-shaped heading (#3401)

Browse Source 
* test(#3170): extractOneLinerFromBody must anchor to a summary-shaped heading

Regression for #3170: the function matched the first heading's first bold
run, so an incidental first heading (rule list, deviation notes) contributed
its bold text as the milestone accomplishment. Rows 1/2 fail RED on next; rows
3/4 guard Overview recognition and the #2660 Summary-heading form.

* fix(#3170): anchor milestone one-liner extraction to a summary-shaped heading

extractOneLinerFromBody matched the first heading's first bold run regardless
of section, so an incidental first heading (rule list, deviation notes)
contributed its bold text as the milestone accomplishment written into
MILESTONES.md. Iterate headings and extract from the first Summary/Overview/
Accomplishments one with a bold run, falling back to null when none exists.
The #2660 Summary-heading forms and the frontmatter one-liner precedence are
preserved.

* docs(#3170): add changeset

* test(#3170): align extractOneLinerFromBody unit fixtures with summary-heading contract

The core-utils unit fixtures used generic # Title headings encoding the old
'any first heading' contract; the #3170 fix anchors to a Summary/Overview/
Accomplishments heading (the function is summary-specific). Update the
heading text to Summary-shaped; the extraction assertions (bold, frontmatter
strip, colon-label, CRLF, unicode) are unchanged.

* docs(#3170): backfill changeset PR number (3401)

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-12 22:21:53 -04:00
committed by GitHub
parent b8cb031ce2
commit 2283168612
4 changed files with 89 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
tests/milestone.test.cjs
View File

@@ -2106,6 +2106,60 @@ describe('bug #2660: extractOneLinerFromBody', () => {
}
// ────────────────────────────────────────────────────────────────────────
describe('#3170: extractOneLinerFromBody anchors to a summary-shaped heading', () => {
// Self-contained require (the #2660 block's require is fold-scoped).
const path = require('path');
const { extractOneLinerFromBody } = require(
path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'core-utils.cjs')
);
test('row 1 — an incidental first heading does not contribute its bold run; the Summary heading does', () => {
const content = [
'# Rules',
'',
'**Rule 1 - Bug** Task 2 spawned a real agent CLI process on first attempt.',
'',
'## Summary',
'',
'**Shipped unattended dogfooding resume.** Real deliverable description.',
'',
].join('\n');
assert.strictEqual(
extractOneLinerFromBody(content),
'Shipped unattended dogfooding resume.',
`must anchor to the Summary heading, not the incidental # Rules one`
);
});
test('row 2 — no summary-shaped heading at all returns null (not the wrong text)', () => {
const content = [
'# Deviation Notes',
'',
'**NeutralPath** is the production fix.',
'',
'## Follow-ups',
'',
'**The production fix is one expression.** Not a deliverable summary.',
'',
].join('\n');
assert.strictEqual(
extractOneLinerFromBody(content),
null,
`no Summary/Overview/Accomplishments heading → null, not incidental bold text`
);
});
test('row 3 — an Overview heading is recognized', () => {
const content = '# Overview\n\n**Shipped the thing.** Details follow.\n';
assert.strictEqual(extractOneLinerFromBody(content), 'Shipped the thing.');
});
test('row 4 — #2660 form (heading contains "Summary") is unchanged', () => {
const content = '# Phase 1: Foundation Summary\n\n**One-liner:** Real prose here.\n';
assert.strictEqual(extractOneLinerFromBody(content), 'Real prose here.');
});
});
// Folded from tests/enh-72-business-context.test.cjs — consolidation epic #1969 (B8 #1977)
// ────────────────────────────────────────────────────────────────────────
{