fix: embed model_overrides in Codex TOML and OpenCode agent files (#2279)
* docs: sync ARCHITECTURE.md command count to 74 commands/gsd/ has 74 .md files; the two count references in ARCHITECTURE.md still said 73. Fixes the command-count-sync regression test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: embed model_overrides in Codex TOML and OpenCode agent files (#2256) Codex and OpenCode use static agent files (TOML / markdown frontmatter) rather than inline Task(model=...) parameters, so model_overrides set in ~/.gsd/defaults.json was silently ignored — all subagents fell through to the runtime's default model. Fix: at install time, read model_overrides from ~/.gsd/defaults.json and embed the matching model ID into each agent file: - Codex: model = "..." field in the agent TOML (generateCodexAgentToml) - OpenCode: model: ... field in agent frontmatter (convertClaudeToOpencodeFrontmatter) Also adds readGsdGlobalModelOverrides() helper and passes the result through installCodexConfig() and the OpenCode agent install loop. Closes #2256 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(commands): add gsd:inbox command for GitHub issue/PR triage inbox.md was created but not committed, causing the command count to read 73 in git while ARCHITECTURE.md correctly stated 74. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -320,6 +320,35 @@ tools: Read, Grep, Glob
|
||||
const result = generateCodexAgentToml('gsd-unknown', sampleAgent);
|
||||
assert.ok(result.includes('sandbox_mode = "read-only"'), 'defaults to read-only');
|
||||
});
|
||||
|
||||
// ─── #2256: model_overrides support ───────────────────────────────────────
|
||||
|
||||
test('emits model field when modelOverrides contains an entry for the agent (#2256)', () => {
|
||||
const overrides = { 'gsd-executor': 'gpt-5.3-codex' };
|
||||
const result = generateCodexAgentToml('gsd-executor', sampleAgent, overrides);
|
||||
assert.ok(result.includes('model = "gpt-5.3-codex"'), 'model field must be present in TOML');
|
||||
});
|
||||
|
||||
test('does not emit model field when modelOverrides is null (#2256)', () => {
|
||||
const result = generateCodexAgentToml('gsd-executor', sampleAgent, null);
|
||||
assert.ok(!result.includes('model ='), 'model field must be absent when no override');
|
||||
});
|
||||
|
||||
test('does not emit model field when modelOverrides has no entry for this agent (#2256)', () => {
|
||||
const overrides = { 'gsd-planner': 'gpt-5.4' };
|
||||
const result = generateCodexAgentToml('gsd-executor', sampleAgent, overrides);
|
||||
assert.ok(!result.includes('model ='), 'model field must be absent for agents not in overrides');
|
||||
});
|
||||
|
||||
test('model field appears before developer_instructions (#2256)', () => {
|
||||
const overrides = { 'gsd-executor': 'gpt-5.3-codex' };
|
||||
const result = generateCodexAgentToml('gsd-executor', sampleAgent, overrides);
|
||||
const modelIdx = result.indexOf('model = "gpt-5.3-codex"');
|
||||
const instrIdx = result.indexOf("developer_instructions = '''");
|
||||
assert.ok(modelIdx !== -1, 'model field present');
|
||||
assert.ok(instrIdx !== -1, 'developer_instructions present');
|
||||
assert.ok(modelIdx < instrIdx, 'model field must appear before developer_instructions');
|
||||
});
|
||||
});
|
||||
|
||||
// ─── CODEX_AGENT_SANDBOX mapping ────────────────────────────────────────────────
|
||||
|
||||
Reference in New Issue
Block a user