Refactor SDK-first architecture seams (#3316)
* refactor: tighten sdk-first architecture seams Refs #3312 * refactor: finish state document seam cleanup Refs #3312 * test: harden minimal install cleanup assertion * ci: support sdk-scoped package lock * fix(3316): restore root package-lock.json and align changeset pr ref Reverts dec57a83 ("ci: support sdk-scoped package lock") and restores the root package-lock.json that c249d34d deleted. The deletion was the wrong direction: - The root package.json declares its own runtime and dev deps (@anthropic-ai/claude-agent-sdk, ws, c8). Without a root lockfile, `npm install --no-package-lock` resolves whatever satisfies semver at install time — CI today and CI in six months can install different transitive trees, defeating reproducibility. - The lockfile has been part of every release on this repo (long history on main); removing it loses the npm audit / Dependabot target without compensating benefit. - The CI workaround pattern (cache-dependency-path: sdk/package-lock.json + `npm install --no-package-lock`) papered over the symptom rather than fix the cause. Also fix the changeset pr: from 3312 (issue) to 3316 (PR). CONTEXT.md flags this exact failure mode as a recurring CodeRabbit finding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: address coderabbit review findings * fix: close remaining coderabbit threads --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -854,6 +854,35 @@ describe('phase add command', () => {
|
||||
assert.ok(roadmap.includes('**Requirements**: TBD'), 'new phase entry should include Requirements TBD');
|
||||
});
|
||||
|
||||
test('phase add ignores --raw instead of persisting it in the description', () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
`# Roadmap v1.0\n\n### Phase 1: Foundation\n**Goal:** Setup\n\n---\n`
|
||||
);
|
||||
|
||||
const result = runGsdTools(['phase', 'add', '--raw', 'User', 'Dashboard'], tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
|
||||
const roadmap = fs.readFileSync(path.join(tmpDir, '.planning', 'ROADMAP.md'), 'utf-8');
|
||||
assert.ok(roadmap.includes('### Phase 2: User Dashboard'), 'description should exclude --raw');
|
||||
assert.ok(!roadmap.includes('--raw'), 'raw flag must not be persisted into ROADMAP.md');
|
||||
});
|
||||
|
||||
test('phase add rejects unsupported flags and dangling --id', () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
`# Roadmap v1.0\n\n### Phase 1: Foundation\n**Goal:** Setup\n\n---\n`
|
||||
);
|
||||
|
||||
const unsupported = runGsdTools(['phase', 'add', '--unknown', 'Dashboard'], tmpDir);
|
||||
assert.ok(!unsupported.success, 'unsupported flags should fail');
|
||||
assert.match(unsupported.error, /phase add does not support --unknown/);
|
||||
|
||||
const dangling = runGsdTools(['phase', 'add', 'Dashboard', '--id'], tmpDir);
|
||||
assert.ok(!dangling.success, 'dangling --id should fail');
|
||||
assert.match(dangling.error, /--id requires a value/);
|
||||
});
|
||||
|
||||
test('skips 999.x backlog phases when calculating next phase number', () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
@@ -1176,6 +1205,22 @@ describe('phase add-batch command (#2165)', () => {
|
||||
const result = runGsdTools(['phase', 'add-batch', '--descriptions', '[]'], tmpDir);
|
||||
assert.ok(!result.success, 'should fail on empty array');
|
||||
});
|
||||
|
||||
test('returns error when --descriptions JSON is not an array', () => {
|
||||
const result = runGsdTools(['phase', 'add-batch', '--descriptions', '{"one":"Alpha"}'], tmpDir);
|
||||
assert.ok(!result.success, 'should fail on non-array JSON');
|
||||
assert.match(result.error, /--descriptions must be a JSON array/);
|
||||
});
|
||||
|
||||
test('returns error when --descriptions is missing its JSON value', () => {
|
||||
const missing = runGsdTools(['phase', 'add-batch', '--descriptions'], tmpDir);
|
||||
assert.ok(!missing.success, 'should fail on dangling --descriptions');
|
||||
assert.match(missing.error, /--descriptions must be a JSON array/);
|
||||
|
||||
const flagValue = runGsdTools(['phase', 'add-batch', '--descriptions', '--raw'], tmpDir);
|
||||
assert.ok(!flagValue.success, 'should fail when --descriptions value is another flag');
|
||||
assert.match(flagValue.error, /--descriptions must be a JSON array/);
|
||||
});
|
||||
});
|
||||
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
@@ -2855,4 +2900,3 @@ describe('phase complete excludes 999.x backlog from next-phase (#2129)', () =>
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
// milestone complete command
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
|
||||
|
||||
Reference in New Issue
Block a user