golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(install): wire --sdk flag into installSdkIfNeeded (#3033)

Browse Source 
hasSdk was parsed in bin/install.js but never passed to
installSdkIfNeeded, so `npx get-shit-done-cc@latest --sdk` silently
skipped SDK deployment via the isLocal early-return and emitted a
misleading "✓ GSD SDK ready" message.

installSdkIfNeeded now accepts opts.forceSdk. When true (set from
hasSdk at the call site in installAllRuntimes), the local-install
soft-skip is bypassed so the full shim-link path runs regardless of
install mode. When dist is also missing with forceSdk=true, the
fail-fast diagnostic fires instead of silently returning.

The #2678 soft-skip (isLocal + missing dist + no --sdk) is preserved.

Closes #3033

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-05-06 21:04:03 -04:00
parent f4d0208abb
commit 2bc49b0aec
4 changed files with 194 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bin/install.js
View File

@@ -9338,7 +9338,12 @@ function installSdkIfNeeded(opts) {
// so a self-link into a user-writable PATH dir makes `gsd-sdk` callable
// from local-mode installs too. Only when the dist is genuinely missing
// do we bail out with a non-fatal warning.
if (opts.isLocal && !fs.existsSync(sdkCliPath)) {
//
// #3033: --sdk (opts.forceSdk) overrides the local-install early-return —
// the user explicitly requested SDK deployment, so treat the missing-dist
// case like a global install (fail fast with an actionable diagnostic)
// instead of silently skipping.
if (opts.isLocal && !opts.forceSdk && !fs.existsSync(sdkCliPath)) {
console.warn(`\n ${yellow}⚠${reset} Skipping SDK check for local install — sdk/dist/cli.js not found at ${sdkCliPath}.`);
return;
}
@@ -9813,7 +9818,8 @@ function installAllRuntimes(runtimes, isGlobal, isInteractive) {
// prebuilt in the tarball (fix/2441-sdk-decouple); gsd-sdk reaches users via
// the parent package's bin/gsd-sdk.js shim, so no sub-install is needed.
// Skip with --no-sdk. Skip with isLocal (#2678 — local installs don't own global npm).
installSdkIfNeeded({ isLocal: !isGlobal });
// #3033: pass forceSdk so --sdk overrides the local-install skip.
installSdkIfNeeded({ isLocal: !isGlobal, forceSdk: hasSdk });
const printSummaries = () => {
for (const result of results) {