golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#812): honor COPILOT_HOME in Copilot global config-dir resolution (#814)

Browse Source 
* fix(#812): honor COPILOT_HOME in Copilot global config-dir resolution

getGlobalConfigDir('copilot') resolved the global config directory using
only --config-dir > COPILOT_CONFIG_DIR > ~/.copilot, ignoring the
COPILOT_HOME env var. Per GitHub's Copilot CLI docs, COPILOT_HOME
overrides the default ~/.copilot location (and user-level hooks are read
from $COPILOT_HOME/hooks/), so a global --copilot install wrote all
artifacts (skills, agents, copilot-instructions.md, the gsd-session.json
hook) to ~/.copilot even when the user relocated their Copilot home,
making them undiscoverable by Copilot CLI.

Mirror the codex/CODEX_HOME branch: precedence is now
--config-dir > COPILOT_CONFIG_DIR > COPILOT_HOME > ~/.copilot. Uninstall
uses the same resolver, so it stays symmetric.

Also: document COPILOT_HOME in the installer --help notes, the
USER-GUIDE env-var table, and the installer-migrations Copilot row; and
clear COPILOT_HOME in the two default-path test suites so they stay
hermetic now that the resolver honors it.

Closes #812

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore(#812): add changeset for PR #814

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-07 15:27:46 -04:00
committed by GitHub
parent eefef2ec19
commit 3025a6846e
8 changed files with 49 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/bug-3126-global-skills-base-runtime-path.test.cjs
View File

@@ -63,7 +63,7 @@ describe('bug #3126: runtime-homes getGlobalConfigDir — defaults', () => {
test(`${runtime} default configDir`, () => {
// Clear all env vars for this runtime
const envKeys = ['CLAUDE_CONFIG_DIR','CURSOR_CONFIG_DIR','GEMINI_CONFIG_DIR',
'CODEX_HOME','COPILOT_CONFIG_DIR','ANTIGRAVITY_CONFIG_DIR','WINDSURF_CONFIG_DIR',
'CODEX_HOME','COPILOT_CONFIG_DIR','COPILOT_HOME','ANTIGRAVITY_CONFIG_DIR','WINDSURF_CONFIG_DIR',
'AUGMENT_CONFIG_DIR','TRAE_CONFIG_DIR','QWEN_CONFIG_DIR','HERMES_HOME',
'CODEBUDDY_CONFIG_DIR','CLINE_CONFIG_DIR','OPENCODE_CONFIG_DIR','OPENCODE_CONFIG',
'KILO_CONFIG_DIR','KILO_CONFIG',

36
tests/copilot-install.test.cjs
View File

@@ -78,9 +78,11 @@ describe('getDirName (Copilot)', () => {
describe('getGlobalConfigDir (Copilot)', () => {
let originalCopilotConfigDir;
let originalCopilotHome;
beforeEach(() => {
originalCopilotConfigDir = process.env.COPILOT_CONFIG_DIR;
originalCopilotHome = process.env.COPILOT_HOME;
});
afterEach(() => {
@@ -89,10 +91,16 @@ describe('getGlobalConfigDir (Copilot)', () => {
} else {
delete process.env.COPILOT_CONFIG_DIR;
}
if (originalCopilotHome !== undefined) {
process.env.COPILOT_HOME = originalCopilotHome;
} else {
delete process.env.COPILOT_HOME;
}
});
test('returns ~/.copilot with no env var or explicit dir', () => {
delete process.env.COPILOT_CONFIG_DIR;
delete process.env.COPILOT_HOME;
const result = getGlobalConfigDir('copilot');
assert.strictEqual(result, path.join(os.homedir(), '.copilot'));
});
@@ -114,6 +122,34 @@ describe('getGlobalConfigDir (Copilot)', () => {
assert.strictEqual(result, '/explicit/path');
});
test('respects COPILOT_HOME env var', () => {
delete process.env.COPILOT_CONFIG_DIR;
process.env.COPILOT_HOME = '/custom/copilot-home';
const result = getGlobalConfigDir('copilot');
assert.strictEqual(result, '/custom/copilot-home');
});
test('COPILOT_HOME supports tilde expansion', () => {
delete process.env.COPILOT_CONFIG_DIR;
process.env.COPILOT_HOME = '~/my-copilot';
const result = getGlobalConfigDir('copilot');
assert.strictEqual(result, path.join(os.homedir(), 'my-copilot'));
});
test('COPILOT_CONFIG_DIR takes priority over COPILOT_HOME', () => {
process.env.COPILOT_CONFIG_DIR = '/config-dir-path';
process.env.COPILOT_HOME = '/home-path';
const result = getGlobalConfigDir('copilot');
assert.strictEqual(result, '/config-dir-path');
});
test('explicit dir takes priority over COPILOT_HOME', () => {
delete process.env.COPILOT_CONFIG_DIR;
process.env.COPILOT_HOME = '/home-path';
const result = getGlobalConfigDir('copilot', '/explicit/path');
assert.strictEqual(result, '/explicit/path');
});
test('does not break existing runtimes', () => {
assert.strictEqual(getGlobalConfigDir('claude'), path.join(os.homedir(), '.claude'));
assert.strictEqual(getGlobalConfigDir('codex'), path.join(os.homedir(), '.codex'));

2
tests/install.test.cjs
View File

@@ -69,7 +69,7 @@ describe('getGlobalConfigDir — all runtimes default paths', () => {
// Test the default (no env var, no explicit dir) for each runtime
const ENV_KEYS = [
'CLAUDE_CONFIG_DIR', 'CURSOR_CONFIG_DIR', 'GEMINI_CONFIG_DIR', 'CODEX_HOME',
'GROK_AGENTS_HOME', 'COPILOT_CONFIG_DIR', 'WINDSURF_CONFIG_DIR', 'AUGMENT_CONFIG_DIR',
'GROK_AGENTS_HOME', 'COPILOT_CONFIG_DIR', 'COPILOT_HOME', 'WINDSURF_CONFIG_DIR', 'AUGMENT_CONFIG_DIR',
'TRAE_CONFIG_DIR', 'QWEN_CONFIG_DIR', 'HERMES_HOME', 'CODEBUDDY_CONFIG_DIR',
'CLINE_CONFIG_DIR', 'OPENCODE_CONFIG_DIR', 'OPENCODE_CONFIG', 'KILO_CONFIG_DIR',
'KILO_CONFIG', 'ANTIGRAVITY_CONFIG_DIR', 'XDG_CONFIG_HOME',