golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test(#4515): migrate installer-runs batch to named timeout constants (#4575)

Browse Source 
* test(#4515): migrate installer-runs batch to named timeout constants

Batch 4 of the ad hoc timeout literal migration (epic #4445). Replaces
every bare numeric timeout/timeoutMs object-literal property across
tests/install.test.cjs, tests/install-minimal-hooks.test.cjs,
tests/fragment-single-edit-propagation.install.test.cjs,
tests/install-regressions.test.cjs, tests/install-runtime-artifacts.test.cjs,
tests/npm-integrity-gate.test.cjs, tests/faulty-deps.test.cjs,
tests/release-tarball-smoke.install.test.cjs,
tests/install-write-confinement.test.cjs, tests/plugin-manifest.test.cjs,
and tests/packaging-shipped-scripts-require-only-shipped.test.cjs with a
named constant, per eslint-rules/no-adhoc-timeout-literal.cjs. Removes
these 11 files from the rule's allowlist.

Adds one new shared constant to tests/helpers/timeouts.cjs for a
fixture-JSON value (in seconds, not ms) mimicking a Claude Code
settings.json hook-entry's own timeout field, shared across two files in
this batch. Every other new constant is file-local, each carrying a
comment explaining why its call site is a distinct operational class from
the existing shared norms even where its digits numerically coincide with
one. No src/bin file touched, no numeric timeout value changed anywhere.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: combine gsd-worktree-path-guard's git rev-parse calls to cut subprocess count under CI load

Discovered while verifying PR #4575 (a full test (windows-latest) failure in an unrelated test, tests/kilo-upgrades.test.cjs's worktree-path-guard rejection test). Root cause: this hook's up-to-4 sequential git spawns (git-dir, branch, worktree-toplevel, file-toplevel), invoked inside a native-plugin's own 8000ms-capped subprocess wrapper, left zero margin for node/git startup overhead — the guard is deliberately fail-open on any timeout, so CI-load-induced latency in this chain silently downgrades a security block into an allow. Combines the first three git rev-parse calls (git-dir, branch via --abbrev-ref, worktree-toplevel) into ONE spawn instead of three, using git's documented multi-flag rev-parse output (one line per flag, in order) — verified empirically including the detached-HEAD edge case. No timeout value changed; this reduces subprocess COUNT, not any tolerance.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* docs: add changeset fragment for the worktree-path-guard fix

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: sim <sim@local>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-09-09 11:45:44 -04:00
committed by GitHub
parent 5823d2ec7a
commit 30468f16fe
15 changed files with 221 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/install-regressions.test.cjs
View File

@@ -21,7 +21,12 @@ const fs = require('node:fs');
const path = require('node:path');
const { runNode } = require('./helpers/process-seam.cjs');
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
const { INSTALL_TIMEOUT_MS } = require('./helpers/timeouts.cjs');
const { INSTALL_TIMEOUT_MS, FIXTURE_HOOK_TIMEOUT_SECONDS } = require('./helpers/timeouts.cjs');
// Bounds a scoped/targeted runNode([INSTALL_SCRIPT, ...]) invocation — a
// lighter shape than the shared full-install INSTALL_TIMEOUT_MS class
// (120000ms), so kept as its own constant rather than raised to that bound.
const SCOPED_INSTALL_TIMEOUT_MS = 60_000;
const { createTempDir, cleanup, mockPartialWriteThenThrow } = require('./helpers.cjs');
const {
@@ -95,7 +100,7 @@ describe('#2429 regression: Codex local skills stay project-scoped', () => {
const result = runNode(
[INSTALL_SCRIPT, '--codex', '--local', '--profile=core'],
{ cwd: projectDir, env, timeoutMs: 60_000 },
{ cwd: projectDir, env, timeoutMs: SCOPED_INSTALL_TIMEOUT_MS },
);
assert.strictEqual(
@@ -1118,7 +1123,7 @@ describe('#1004 regression: installer does not duplicate managed hooks when regi
{
type: 'http',
url: hookUrl,
timeout: 5,
timeout: FIXTURE_HOOK_TIMEOUT_SECONDS,
},
],
},
@@ -1970,7 +1975,7 @@ describe('#1874 F6 (#338 migration): a malformed settings.local.json is preserve
delete env.GSD_TEST_MODE;
const result = runNode(
[INSTALL_SCRIPT, '--claude', '--local'],
{ cwd: root, env, timeoutMs: 60_000 },
{ cwd: root, env, timeoutMs: SCOPED_INSTALL_TIMEOUT_MS },
);
assert.strictEqual(result.exitCode, 0,
`installer exited ${result.exitCode}\n${result.stdout}\n${result.stderr}`);
@@ -2018,7 +2023,7 @@ describe('#1874 F6 adjacent: malformed settings.local.json does not crash the in
delete env.GSD_TEST_MODE;
const result = runNode(
[INSTALL_SCRIPT, '--claude', '--local'],
{ cwd: root, env, timeoutMs: 60_000 },
{ cwd: root, env, timeoutMs: SCOPED_INSTALL_TIMEOUT_MS },
);
assert.strictEqual(result.exitCode, 0,