golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#1907): validate per-item shape in isValidReport so adapter garbage fails closed (#1910)

Browse Source 
* fix(#1907): validate per-item shape in isValidReport so adapter garbage fails closed

isValidReport checked only the container (items is-array, coverage scalars), so a report
like {items:[{}]} sailed through runProbeCli and stringified as green output — despite the
docstring promising it 'fails closed on adapter garbage'. Add a per-item Item-contract guard
(requirement_id/category/status + typed nullable fields) so a future adapter that bypasses
the analyzeCoverage merge and returns per-item garbage inside a well-shaped envelope fails
closed (exit 2) instead of emitting it as valid coverage.

analyzeCoverage always emits fully-populated, validated Items, so the 2 shipped adapters are
unaffected (verified across the edge/prohibition suites).

Refs #1907, epic #1904.

* chore(changeset): Fixed fragment for #1910 (isValidReport per-item)
This commit is contained in:
Rezolv
2026-07-02 11:55:53 -04:00
committed by GitHub
parent a4bc04a5ff
commit 312c9d3ec3
3 changed files with 57 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/clever-rams-march.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 1910
---
Fixed: probe-core's runProbeCli now fails closed on per-item adapter garbage inside a well-shaped report envelope, matching its documented 'fails closed on adapter garbage' contract.