From 34ac1f5e59be91e47baa4099a5f8e8e35fc2d2ed Mon Sep 17 00:00:00 2001
From: Tom Boucher <trekkie@nomorestars.com>
Date: Fri, 15 May 2026 20:20:25 -0400
Subject: [PATCH] fix: address CodeRabbit findings on phase mode parsing

---
 ...3251-command-aliases-manifest-coverage.test.cjs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/feat-3251-command-aliases-manifest-coverage.test.cjs b/tests/feat-3251-command-aliases-manifest-coverage.test.cjs
index 09e95daca..487bfd7c4 100644
--- a/tests/feat-3251-command-aliases-manifest-coverage.test.cjs
+++ b/tests/feat-3251-command-aliases-manifest-coverage.test.cjs
@@ -147,7 +147,7 @@ function runGsdTools(args, projectDir) {
   });
 }
 
-function listProjectFiles(projectDir) {
+function snapshotProjectState(projectDir) {
   const files = [];
   function walk(dir) {
     if (!fs.existsSync(dir)) return;
@@ -203,7 +203,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
           '',
         ].join('\n'),
       );
-      const beforeFiles = listProjectFiles(projectDir);
+      const beforeFiles = snapshotProjectState(projectDir);
 
       const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir);
       assert.equal(result.status, 0, result.stderr);
@@ -214,7 +214,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
       assert.equal(output.roadmap_mode, 'mvp');
       assert.equal(output.config_mvp_mode, false);
       assert.equal(output.cli_flag_present, false);
-      assert.deepEqual(listProjectFiles(projectDir), beforeFiles);
+      assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
     } finally {
       fs.rmSync(projectDir, { recursive: true, force: true });
     }
@@ -239,7 +239,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
           '',
         ].join('\n'),
       );
-      const beforeFiles = listProjectFiles(projectDir);
+      const beforeFiles = snapshotProjectState(projectDir);
 
       const result = runGsdTools(['phase', 'mvp-mode', '1'], projectDir);
       assert.equal(result.status, 0, result.stderr);
@@ -248,7 +248,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
       assert.equal(output.active, false);
       assert.equal(output.source, 'none');
       assert.equal(output.roadmap_mode, null);
-      assert.deepEqual(listProjectFiles(projectDir), beforeFiles);
+      assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
     } finally {
       fs.rmSync(projectDir, { recursive: true, force: true });
     }
@@ -257,7 +257,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
   test('phase.mvp-mode JSON error is typed and leaves project files untouched', () => {
     const projectDir = createProject();
     try {
-      const beforeFiles = listProjectFiles(projectDir);
+      const beforeFiles = snapshotProjectState(projectDir);
       const result = runGsdTools(['--json-errors', 'phase', 'mvp-mode'], projectDir);
       assert.notEqual(result.status, 0);
       assert.equal(result.stdout, '');
@@ -268,7 +268,7 @@ describe('feat-3251: generated aliases dispatch through real gsd-tools behavior'
       assert.equal(error.reason, 'usage');
       assert.equal(typeof error.message, 'string');
       assert.equal(/\n\s*at\s/.test(result.stderr), false, 'non-debug failure must not print a stack trace');
-      assert.deepEqual(listProjectFiles(projectDir), beforeFiles);
+      assert.deepEqual(snapshotProjectState(projectDir), beforeFiles);
     } finally {
       fs.rmSync(projectDir, { recursive: true, force: true });
     }