golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(#1646): route capability routers through Command Routing Hub per ADR-959 (#1647)

Browse Source 
* refactor(#1646): route capability routers through Command Routing Hub per ADR-959

Phase 2 of parent #1641. Converts graphify, intel, and audit command
routers from hand-rolled if/else dispatch to routeHubCommandFamily,
implementing the ADR-959 §III(B) line 75 mandate. The three routers
now share the uniform dispatch shape with the 14 host routers.

src/cjs-command-router-adapter.cts
  * Imported ERROR_REASON from io.cjs.
  * UnknownCommand translation now passes ERROR_REASON.SDK_UNKNOWN_COMMAND
    as the second arg to error() — additive for host routers (their
    existing one-arg error callbacks ignore the second arg), required
    for capability routers whose tests assert reason === 'sdk_unknown_command'
    on the JSON-error envelope.

src/graphify-command-router.cts
  * Replaced 4-branch if/else with routeHubCommandFamily + handlers map.
  * Validation handlers (missing term, missing/invalid --budget) now
    return makeInvalidArgs(arg, reason, ERROR_REASON.USAGE) Results
    instead of calling error() directly (Q2=C, Q4=ii from grilling).
  * Success handlers keep direct output() calls.
  * Subcommands array is alphabetical for byte-identical 'Available:'
    text in the unknown-subcommand message.
  * The unknown-subcommand path is now owned by the Hub's manifest
    check (the adapter passes SDK_UNKNOWN_COMMAND).

src/intel-command-router.cts
  * Replaced 9-branch if/else with routeHubCommandFamily + handlers map.
  * Validation handlers (missing term, missing filePath for patch-meta
    and extract-exports) return makeInvalidArgs Results.
  * Preserved the timeAgo mutation in the non-raw status handler.
  * Preserved the lazy require('./intel.cjs') inside the route function.

src/audit-command-router.cts
  * routeAuditUat: routes through the Hub with a synthetic 'run'
    defaultSubcommand (no real subcommands). Gives uniform observability.
  * routeAuditOpen: captures --json in a closure, strips it from args
    before Hub dispatch (so it isn't mistaken for a subcommand by the
    manifest check), then branches on wantJson inside the handler to
    preserve the formatAuditReport success-path quirk.

docs/CONFIGURATION.md
  * Observability section: noted capability commands (graphify, intel,
    audit-uat, audit-open) now emit DispatchEvent records since #1646.

.changeset/capability-routers-via-hub.md
  * Changed fragment describing the user-visible audit-trail expansion.
    pr:0 placeholder will be backfilled after gh pr create returns the
    real PR number (DEFECT.CHANGESET-PR-FIELD-DRIFT).

Verification
  * graphify cutover tests: 119/119 pass (all unit, dispatch, behavior,
    error path, JSON-errors, and registry assertions)
  * intel cutover tests: 39/39 pass
  * audit cutover tests: 24/24 pass
  * bug-974-graphify-budget-missing-value regression test: pass
  * npm run test:unit (full suite): 2384 tests, 0 fail
  * gsd-test-summary on docker: outcome=passed, 0 failures
    (RULESET.PR-FLOW.docker-before-push)

JSON-error envelope parity verified byte-identical: reason values
('usage', 'sdk_unknown_command') and message texts are preserved
across all three routers' error paths.

* chore(#1646): backfill changeset pr: 1647 (DEFECT.CHANGESET-PR-FIELD-DRIFT)
This commit is contained in:
Tom Boucher
2026-06-23 23:21:06 -04:00
committed by GitHub
parent 6214039358
commit 35478b615e
6 changed files with 212 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
src/intel-command-router.cts
View File

@@ -44,8 +44,15 @@ import io = require('./io.cjs');
import coreUtils = require('./core-utils.cjs');
// eslint-disable-next-line @typescript-eslint/no-require-imports
import path = require('path');
// Phase 2 (#1646): route through the Hub per ADR-959 §III(B) line 75.
// eslint-disable-next-line @typescript-eslint/no-require-imports
import commandRoutingHub = require('./command-routing-hub.cjs');
// eslint-disable-next-line @typescript-eslint/no-require-imports
import cjsCommandRouterAdapter = require('./cjs-command-router-adapter.cjs');
const { ERROR_REASON } = io;
const { makeInvalidArgs } = commandRoutingHub;
const { routeHubCommandFamily } = cjsCommandRouterAdapter;
// Default CoreModule implementation assembled from leaf modules.
// _core seam overrides this entirely for test injection.
const _defaultCore = { output: io.output, timeAgo: coreUtils.timeAgo };
@@ -87,62 +94,81 @@ function routeIntelCommand({ args, cwd, raw, error, _intel, _core }: RouteIntelC
// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-assignment
const intel: IntelModule = _intel ?? require('./intel.cjs');
const c: CoreModule = _core ?? _defaultCore;
const subcommand = args[1];
if (subcommand === 'query') {
const term = args[2];
if (!term) {
error('Usage: gsd-tools intel query <term>', ERROR_REASON.USAGE);
return;
}
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelQuery(term, planningDir), raw);
} else if (subcommand === 'status') {
const planningDir = path.join(cwd, '.planning');
const status = intel.intelStatus(planningDir);
if (!raw && status.files) {
for (const file of Object.values(status.files)) {
if (file.updated_at) {
file.updated_at = c.timeAgo(new Date(file.updated_at));
// Phase 2 (#1646): routes through the Command Routing Hub per ADR-959 §III(B)
// line 75. Validation handlers return `makeInvalidArgs(...)` Results; the
// Hub → adapter translation preserves ERROR_REASON granularity via the
// exitReason field (Phase 1, #1644). Success handlers keep direct `c.output()`
// calls. The timeAgo mutation in non-raw `status` is preserved. Lazy require
// of intel.cjs inside the function is preserved (loads only when dispatched).
routeHubCommandFamily({
family: 'intel',
args,
// Alphabetical for stable unknownMessage text; the integration test asserts
// inclusion of all 9 subcommands, not order.
subcommands: ['api-surface', 'diff', 'extract-exports', 'patch-meta', 'query', 'snapshot', 'status', 'update', 'validate'],
handlers: {
query: () => {
const term = args[2];
if (!term) {
return makeInvalidArgs('term', 'Usage: gsd-tools intel query <term>', ERROR_REASON.USAGE);
}
}
}
c.output(status, raw);
} else if (subcommand === 'diff') {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelDiff(planningDir), raw);
} else if (subcommand === 'snapshot') {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelSnapshot(planningDir), raw);
} else if (subcommand === 'patch-meta') {
const filePath = args[2];
if (!filePath) {
error('Usage: gsd-tools intel patch-meta <file-path>', ERROR_REASON.USAGE);
return;
}
c.output(intel.intelPatchMeta(path.resolve(cwd, filePath)), raw);
} else if (subcommand === 'validate') {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelValidate(planningDir), raw);
} else if (subcommand === 'extract-exports') {
const filePath = args[2];
if (!filePath) {
error('Usage: gsd-tools intel extract-exports <file-path>', ERROR_REASON.USAGE);
return;
}
c.output(intel.intelExtractExports(path.resolve(cwd, filePath)), raw);
} else if (subcommand === 'update') {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelUpdate(planningDir), raw);
} else if (subcommand === 'api-surface') {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelApiSurface(planningDir), raw);
} else {
error(
'Unknown intel subcommand. Available: query, status, update, diff, snapshot, patch-meta, validate, extract-exports, api-surface',
ERROR_REASON.SDK_UNKNOWN_COMMAND,
);
}
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelQuery(term, planningDir), raw);
},
status: () => {
const planningDir = path.join(cwd, '.planning');
const status = intel.intelStatus(planningDir);
if (!raw && status.files) {
for (const file of Object.values(status.files)) {
if (file.updated_at) {
file.updated_at = c.timeAgo(new Date(file.updated_at));
}
}
}
c.output(status, raw);
},
diff: () => {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelDiff(planningDir), raw);
},
snapshot: () => {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelSnapshot(planningDir), raw);
},
'patch-meta': () => {
const filePath = args[2];
if (!filePath) {
return makeInvalidArgs('file-path', 'Usage: gsd-tools intel patch-meta <file-path>', ERROR_REASON.USAGE);
}
c.output(intel.intelPatchMeta(path.resolve(cwd, filePath)), raw);
},
validate: () => {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelValidate(planningDir), raw);
},
'extract-exports': () => {
const filePath = args[2];
if (!filePath) {
return makeInvalidArgs('file-path', 'Usage: gsd-tools intel extract-exports <file-path>', ERROR_REASON.USAGE);
}
c.output(intel.intelExtractExports(path.resolve(cwd, filePath)), raw);
},
update: () => {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelUpdate(planningDir), raw);
},
'api-surface': () => {
const planningDir = path.join(cwd, '.planning');
c.output(intel.intelApiSurface(planningDir), raw);
},
},
unknownMessage: (subcommand: string, available: string[]) =>
`Unknown intel subcommand. Available: ${available.join(', ')}`,
error,
cwd,
raw,
});
}
export = {