golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1508 from Ecko95/fix/infinite-self-discuss-loop

Browse Source 
fix: prevent infinite self-discuss loop in auto/headless mode
This commit is contained in:
Tom Boucher
2026-04-01 17:34:15 -04:00
committed by GitHub
parent bf838c0d92 0782b5bdf0
commit 35b835b861
5 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/prompts/workflows/discuss-phase.md
View File

@@ -64,6 +64,19 @@ Analyze the phase to identify gray areas:
5. **Log each decision** with rationale
</step>
<step name="pass_guard">
**CRITICAL — Single-pass guard:**
This step MUST complete in ONE pass. After writing CONTEXT.md, you are DONE. Do NOT re-read your own CONTEXT.md to identify "gaps", "undefined types", or "missing references" and run additional passes. Each decision naturally references other types and interfaces — this is expected, not a gap. The planner and executor will handle implementation details.
Self-referential gap-finding creates an infinite loop where:
1. Pass N creates decisions referencing types/interfaces
2. Pass N+1 "discovers" those references as "gaps"
3. Pass N+1 creates new decisions that reference more types
4. Repeat forever
Write your decisions once, comprehensively, then stop.
</step>
<step name="write_context">
Create CONTEXT.md capturing decisions made:

3
sdk/src/config.ts
View File

@@ -31,6 +31,8 @@ export interface WorkflowConfig {
research_before_questions: boolean;
discuss_mode: string;
skip_discuss: boolean;
/** Maximum self-discuss passes in auto/headless mode before forcing proceed. Default: 3. */
max_discuss_passes: number;
}
export interface HooksConfig {
@@ -82,6 +84,7 @@ export const CONFIG_DEFAULTS: GSDConfig = {
research_before_questions: false,
discuss_mode: 'discuss',
skip_discuss: false,
max_discuss_passes: 3,
},
hooks: {
context_warnings: true,

5
sdk/src/phase-runner.ts
View File

@@ -419,8 +419,9 @@ export class PhaseRunner {
const contextFiles = await this.contextEngine.resolveContextFiles(PhaseType.Discuss);
let prompt = await this.promptFactory.buildPrompt(PhaseType.Discuss, null, contextFiles);
// Supplement with self-discuss instructions
prompt += '\n\n## Self-Discuss Mode\n\nYou are the AI discussing decisions with yourself. No human is present. Identify 3-5 gray areas in the project scope, reason through each one, make opinionated choices, and write CONTEXT.md with your decisions.';
// Supplement with self-discuss instructions with pass cap
const maxPasses = this.config.workflow.max_discuss_passes ?? 3;
prompt += `\n\n## Self-Discuss Mode\n\nYou are the AI discussing decisions with yourself. No human is present. Identify 3-5 gray areas in the project scope, reason through each one, make opinionated choices, and write CONTEXT.md with your decisions.\n\n**CRITICAL: Single-pass only.** You MUST complete all decisions in ONE pass and write CONTEXT.md once. Do NOT re-read your own CONTEXT.md to find "gaps" and do additional passes. The maximum allowed passes is ${maxPasses} — if you have already written CONTEXT.md, you are DONE. Proceed to the next workflow step. Self-referential gap-finding loops waste resources without adding value.`;
planResult = await runPhaseStepSession(
prompt,