From 372c0356e580d5a38fb592c6264a9d7371cf5e0d Mon Sep 17 00:00:00 2001 From: ngothanhluan Date: Fri, 3 Apr 2026 06:56:50 +0700 Subject: [PATCH] fix: add empty output guard for OpenCode reviewer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Addresses review feedback — checks if opencode output file is non-empty after invocation, writes a failure message if empty to prevent blank sections in REVIEWS.md. Co-Authored-By: Claude Opus 4.6 (1M context) --- get-shit-done/workflows/review.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/get-shit-done/workflows/review.md b/get-shit-done/workflows/review.md index 23f25ff36..598ea6091 100644 --- a/get-shit-done/workflows/review.md +++ b/get-shit-done/workflows/review.md @@ -147,6 +147,9 @@ coderabbit review --prompt-only 2>/dev/null > /tmp/gsd-review-coderabbit-{phase} **OpenCode (via GitHub Copilot):** ```bash cat /tmp/gsd-review-prompt-{phase}.md | opencode run - 2>/dev/null > /tmp/gsd-review-opencode-{phase}.md +if [ ! -s /tmp/gsd-review-opencode-{phase}.md ]; then + echo "OpenCode review failed or returned empty output." > /tmp/gsd-review-opencode-{phase}.md +fi ``` If a CLI fails, log the error and continue with remaining CLIs.