* fix(#1162): support table-format STATE.md in state field read/replace Extend stateExtractField and stateReplaceField in state-document.cts to detect and operate on pipe-table rows (| Field | value |). The separator row | --- | --- | is excluded from matching. updateCurrentPositionFields in state.cts now falls through to stateReplaceField for table-format Current Position sections when the inline Status:/Last activity: patterns do not match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#1163): insert missing plan checklist rows in roadmap update-plan-progress cmdRoadmapUpdatePlanProgress now inserts `- [ ] NN-XX-PLAN.md` checkbox rows under the phase Plans: line when no per-plan checkbox rows exist yet (fresh template). Rows are sorted ascending and any already-summarised plans are immediately marked [x]. The planCountPattern is extended to also match plain `Plans:` (in addition to bold `**Plans:**`) so plan counts are updated in both template variants. The existing-rows check covers both top-level and indented checkbox forms to preserve idempotency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#1163): fill partial plan-row gaps and scope insertion to active milestone - Finding 1 (HIGH): replace all-or-nothing rowsAlreadyPresent guard with per-file set-difference so missing rows are inserted even when SOME plan rows already exist - Finding 2 (MEDIUM): extend planCountPattern to recognise **Plans**: (canonical template form — bold word + outer colon) alongside **Plans:** and plain Plans:; use two-pattern fallback for row insertion to anchor under Plans: checklist header rather than the **Plans**: summary line - Finding 3 (MEDIUM): scope row insertion to the active (post-</details>) milestone region so duplicate phase headings in archived sections never receive new rows - Finding 4 (LOW): rename misleading "pipe-like content" test to honestly describe what it tests (multi-row table isolation); add out-of-scope escaped-pipe comment - Remove now-unused anyCheckboxMatched variable (lint clean) - Add 5 adversarial regression tests (pre-fix failures confirmed) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#1163): scope missing-plan detection to active milestone; preserve authored state fields in table format - roadmap.cts: compute activeRegion (post-</details> slice) once and use it for BOTH missingPlans detection and row insertion, so archived <details> rows no longer suppress active-section inserts (Finding 1 code-review) - roadmap.cts: change (Plans:) inner capture to non-capturing (?:Plans:) in insertRowsPatternA to prevent group-numbering shift (Finding 3) - state.cts: mirror inline-branch preserve-authored guards onto table-format branches in updateCurrentPositionFields — Status table branch checks isInList/matchesPattern before replacing; Last Activity table branch checks isDateShape/inList, preserving executor-authored narrative prose (Finding 2 code-review) - tests: add three failing-first regression tests confirming each finding Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#1162,#1163): fold table-format + plan-row regressions into owning module tests Move bug-1162 cases into tests/state.test.cjs and bug-1163 cases into tests/roadmap.test.cjs under named regression describe blocks; delete the standalone bug-NNNN files and prune their allowlist entries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(#1156): add changeset fragment for table-format state + roadmap insert fix Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -513,9 +513,13 @@ function cmdRoadmapUpdatePlanProgress(cwd: string, phaseNum: string | null | und
|
||||
return '|' + cells.join('|') + '|';
|
||||
});
|
||||
|
||||
// Update plan count in phase detail section
|
||||
// Update plan count in phase detail section.
|
||||
// Three recognised forms (all tolerated; canonical template uses the first):
|
||||
// `**Plans**: N plans` — bold word + outer colon (gsd-core/templates/roadmap.md)
|
||||
// `**Plans:** N plans` — bold "Plans:" (colon inside bold)
|
||||
// `Plans: N plans` — plain text header
|
||||
const planCountPattern = new RegExp(
|
||||
`(#{2,4}\\s*Phase\\s+${phasePattern}(?=[:\\s])[\\s\\S]*?\\*\\*Plans:\\*\\*\\s*)[^\\n]+`,
|
||||
`(#{2,4}\\s*Phase\\s+${phasePattern}(?=[:\\s])[\\s\\S]*?(?:\\*\\*Plans\\*\\*:|\\*\\*Plans:\\*\\*|(?:^|\\n)Plans:)\\s*)[^\\n]+`,
|
||||
'i'
|
||||
);
|
||||
const planCountText = isComplete
|
||||
@@ -544,6 +548,92 @@ function cmdRoadmapUpdatePlanProgress(cwd: string, phaseNum: string | null | und
|
||||
roadmapContent = roadmapContent.replace(planCheckboxPattern, '$1x$2');
|
||||
}
|
||||
|
||||
// Compute the active (post-</details>) region offset ONCE. Both the
|
||||
// missing-plan DETECTION and the row INSERTION must use the same active
|
||||
// region string so that a plan row that exists only in an archived <details>
|
||||
// block is not counted as "already present" in the active milestone section.
|
||||
// (Finding 1 code-review: detection was previously running against the full
|
||||
// roadmapContent, causing archived rows to suppress active-section inserts.)
|
||||
const lastDetailsClose = roadmapContent.lastIndexOf('</details>');
|
||||
const activeRegion = lastDetailsClose === -1
|
||||
? roadmapContent
|
||||
: roadmapContent.slice(lastDetailsClose + '</details>'.length);
|
||||
|
||||
// Compute which plan files are MISSING a checkbox row in the ACTIVE region.
|
||||
// This handles three cases:
|
||||
// (a) Fresh template — no rows at all: all plans are missing.
|
||||
// (b) Partial gap — some rows exist, others don't: only the absent ones.
|
||||
// (c) All rows present — nothing to insert (idempotent).
|
||||
//
|
||||
// Detection is scoped to the active region so a plan that appears in an
|
||||
// archived <details> block is still correctly detected as missing from the
|
||||
// active milestone section.
|
||||
const missingPlans = phaseInfo!.plans.filter((planFile) => {
|
||||
const planEscaped = escapeRegex(planFile);
|
||||
return !new RegExp(`-\\s*\\[[x ]\\]\\s*(?:\\*\\*)?${planEscaped}`, 'i').test(activeRegion);
|
||||
});
|
||||
|
||||
if (missingPlans.length > 0) {
|
||||
// Insert missing plan checklist rows (#1163). We prefer to anchor to the
|
||||
// bare `Plans:` checklist header (canonical template form) and fall back to
|
||||
// the bold `**Plans**:`/`**Plans:**` summary line only when no bare header
|
||||
// is present. Using two separate patterns avoids the lazy-quantifier trap
|
||||
// where a single alternation would stop at the first matching alternative
|
||||
// (the bold summary) before reaching the checklist header.
|
||||
//
|
||||
// Canonical template (gsd-core/templates/roadmap.md) uses BOTH lines:
|
||||
// **Plans**: N plans ← summary (colon outside bold)
|
||||
// Plans: ← checklist header (PREFERRED insertion anchor)
|
||||
// Rows must land after `Plans:`, not between the summary and the header.
|
||||
//
|
||||
// Pattern A: anchor to bare `Plans:` header (preferred).
|
||||
// Pattern B: fallback to bold summary when no bare header exists.
|
||||
const insertRowsPatternA = new RegExp(
|
||||
`(#{2,4}\\s*Phase\\s+${phasePattern}(?=[:\\s])[\\s\\S]*?(?:^|\\n)(?:Plans:)[^\\n]*)`,
|
||||
'i'
|
||||
);
|
||||
const insertRowsPatternB = new RegExp(
|
||||
`(#{2,4}\\s*Phase\\s+${phasePattern}(?=[:\\s])[\\s\\S]*?(?:\\*\\*Plans\\*\\*:|\\*\\*Plans:\\*\\*)[^\\n]*)`,
|
||||
'i'
|
||||
);
|
||||
|
||||
const sortedMissing = [...missingPlans].sort();
|
||||
const newRows = sortedMissing.map(p => `- [ ] ${p}`).join('\n');
|
||||
const inserter = (match: string) => `${match}\n${newRows}`;
|
||||
|
||||
// Scope insertion to the active (post-</details>) milestone region to
|
||||
// prevent duplicate phase headings in archived sections from receiving rows.
|
||||
// replaceInCurrentMilestone only accepts a string replacement, so we
|
||||
// perform the scoped replace manually here (same strategy as that helper).
|
||||
// Note: lastDetailsClose was computed above (shared with detection).
|
||||
const scopedReplace = (src: string, pat: RegExp) => src.replace(pat, inserter);
|
||||
let withRows: string;
|
||||
if (lastDetailsClose === -1) {
|
||||
// activeRegion === roadmapContent when there are no </details> blocks.
|
||||
const regionA = scopedReplace(activeRegion, insertRowsPatternA);
|
||||
withRows = regionA !== activeRegion ? regionA : scopedReplace(activeRegion, insertRowsPatternB);
|
||||
} else {
|
||||
const beforeDetails = roadmapContent.slice(0, lastDetailsClose + '</details>'.length);
|
||||
const regionA = scopedReplace(activeRegion, insertRowsPatternA);
|
||||
const afterWithRows = regionA !== activeRegion ? regionA : scopedReplace(activeRegion, insertRowsPatternB);
|
||||
withRows = beforeDetails + afterWithRows;
|
||||
}
|
||||
if (withRows !== roadmapContent) {
|
||||
roadmapContent = withRows;
|
||||
// Mark any newly-inserted rows that already have summaries as complete
|
||||
for (const summaryFile of phaseInfo!.summaries) {
|
||||
const planId = summaryFile.replace('-SUMMARY.md', '').replace('SUMMARY.md', '');
|
||||
if (!planId) continue;
|
||||
const planEscaped = escapeRegex(planId);
|
||||
const planCheckboxPattern = new RegExp(
|
||||
`(-\\s*\\[) (\\]\\s*(?:\\*\\*)?${planEscaped}(?:\\*\\*)?)`,
|
||||
'i'
|
||||
);
|
||||
roadmapContent = roadmapContent.replace(planCheckboxPattern, '$1x$2');
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
platformWriteSync(roadmapPath, roadmapContent);
|
||||
});
|
||||
output({
|
||||
|
||||
Reference in New Issue
Block a user