golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#3982): strip closed-milestone details from the current window (#4177)

Browse Source 
* test(#3982): archived details must not leak into the current-milestone window

Parser-level regression (newest-first layout, two archived details
blocks) plus the issue's end-to-end phase.complete fixture: completing
phase 20 must advance to 21, never backwards into the archived range.

* fix(#3982): strip closed-milestone details from the current window

The heading-located window stripped <details> archives from the
preamble but not from currentSection; on newest-first roadmaps the
archived titles sit in summary tags rather than headings, so the
section walk reached end-of-document and the window swallowed every
collapsed archive below the active milestone. The strip is gated on
isClosedMilestoneHeading over each block's summary — the issue's
prescribed narrow form — so the active milestone's own collapsed
blocks (#1341) survive instead of trading this bug for the
phase_count: 0 class (#557/#2947).

* chore(#3982): backfill changeset pr number

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-09-02 02:33:54 -04:00
committed by GitHub
parent 9eef1b791b
commit 383c2f6b34
4 changed files with 149 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/roadmap-parser.cts
View File

@@ -91,6 +91,21 @@ function stripShippedMilestones(content: string): string {
return stripTaggedBlocks(content, 'details');
}
/**
* #3982: strip only <details> blocks whose <summary> marks a CLOSED milestone
* (ARCHIVED/SHIPPED/✅/… without an active marker) — the narrow form of
* stripShippedMilestones the current-milestone window needs. A blanket strip
* would delete the ACTIVE milestone's own collapsed blocks (#1341) and
* reproduce the phase_count: 0 class of #557/#2947.
*/
function stripClosedMilestoneDetails(content: string): string {
return content.replace(/<details\b[^>]*>[\s\S]*?<\/details>/gi, (block) => {
const summaryMatch = block.match(/<summary[^>]*>([^<]*)<\/summary>/i);
if (!summaryMatch) return block;
return isClosedMilestoneHeading(summaryMatch[1]) ? '' : block;
});
}
/**
* #2562: is the milestone `version` marked SHIPPED by the ROADMAP itself?
*
@@ -1177,7 +1192,17 @@ function extractCurrentMilestoneScoped(content: string, cwd?: string, ws?: strin
? earliestMilestoneIndex
: firstMatch.index;
const beforeMilestones = content.slice(0, preambleCutoff);
const currentSection = content.slice(sectionStart, sectionEnd);
// #3982: newest-first roadmaps collapse their archives into <details>
// blocks BELOW the active milestone, whose titles live in <summary> tags —
// not headings — so no milestone-shaped heading bounds the section walk and
// the raw slice runs to end-of-document. Strip CLOSED milestone details
// blocks here so the window never feeds archived phases to the
// lowest-outstanding scan. Deliberately NOT a blanket strip: the active
// milestone may legitimately hold its own collapsed <details> (#1341), and
// removing that would trade this bug for the phase_count: 0 class (#557).
// Gated on the same isClosedMilestoneHeading the file already applies to
// <summary> lines, per the issue's prescribed narrower fix.
const currentSection = stripClosedMilestoneDetails(content.slice(sectionStart, sectionEnd));
// Multi-milestone roadmaps split each added milestone across two version-bearing
// headings: a `## Phases` checklist subsection (early) and a dedicated