fix(#2772): resolve four discuss-phase text inconsistencies (dead MAX_PASSES read, gate-prompts drift, circular auto_advance, answer_validation drift) (#2886)
* test(#2772): structural guards for the four discuss-phase text inconsistencies * fix(#2772): resolve four discuss-phase text inconsistencies 1. auto.md: remove the dead MAX_PASSES/max_discuss_passes config read (contradicted the mandated single-pass rule + wasted a shim invocation per auto run). 2. gate-prompts.md: context-handling options now match the actual check_existing flow (Update it | View it | Skip, not Overwrite|Append|Cancel); gray-area-option no longer mandates 'Let Claude decide' (contradicts discuss-phase.md's no-cop-out rule). 3. discuss-phase.md: auto_advance fallback ends the workflow instead of routing back to the already-run confirm_creation step (circular). 4. discuss-phase-assumptions.md: re-sync answer_validation to the parent canonical block (had drifted — lost the 'Other' empty-text branch). * chore(#2772): changeset fragment * fix+test(#2772): also fix the assumptions auto_advance circularity (review minor 1) + add positive test anchors (review minor 2) The sibling discuss-phase-assumptions.md had the identical auto_advance→confirm_creation circularity; fix it the same way (end the workflow). Add positive anchors to both auto_advance tests so a re-phrased regression can't slip past. File #2885 for the dead max_discuss_passes config still advertised in settings/registry/docs (review minor 3). * fix(#2772): keep discuss-phase.md under the 32000B #717 cap + ack assumptions growth The auto_advance fixes + the assumptions answer_validation re-sync grew both files past the emitted-attribution gate (and discuss-phase.md past the #717 32000B cap). Condense the auto_advance prose in both files (discuss-phase.md now net -11, under cap; auto.md already net -4650 from the MAX_PASSES shim removal). Add discuss-phase-assumptions.md to tests/emitted-drift-ack.json for its residual +220 (answer_validation re-sync + auto_advance fix). * chore(#2772): backfill changeset PR number (2886) --------- Co-authored-by: Test <test@example.com>
This commit is contained in:
@@ -90,11 +90,14 @@ Up to 4 suggested next actions with selection (status, resume workflows).
|
||||
3-option handler for existing CONTEXT.md in discuss workflow.
|
||||
- question: "Phase {N} already has a CONTEXT.md. How should we handle it?"
|
||||
- header: "Context"
|
||||
- options: Overwrite | Append | Cancel
|
||||
- options: Update it | View it | Skip
|
||||
|
||||
## Pattern: gray-area-option
|
||||
Dynamic template for presenting gray area choices in discuss workflow.
|
||||
- question: "{Gray area title}"
|
||||
- header: "Decision"
|
||||
- options: {Option 1} | {Option 2} | Let Claude decide
|
||||
- Note: Options generated at runtime. Always include "Let Claude decide" as last option.
|
||||
- options: {Option 1} | {Option 2}
|
||||
- Note: Options generated at runtime. Present real choices only — do NOT include a
|
||||
"skip" or "you decide" option (the user ran discuss-phase to decide). An "Other"
|
||||
free-text escape hatch may be offered per modes/default.md, but never a
|
||||
"Let Claude decide" cop-out.
|
||||
|
||||
Reference in New Issue
Block a user