golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2576): normalize padded vs unpadded resolves_phase in close_phase_todos (#2597)

Browse Source 
* test(#2576): add failing regression for padded resolves_phase compare

* fix(#2576): normalize padded vs unpadded resolves_phase in close_phase_todos

* chore(#2576): backfill changeset pr to 2597

* test(#2576): drop fast-check property test (cross-platform-fragile on Windows CI)
This commit is contained in:
Tom Boucher
2026-07-24 12:10:32 -04:00
committed by GitHub
parent be3bf97eff
commit 3b15a1e3cc
23 changed files with 215 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/sharp-otters-zip.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 2597
---
**`/gsd-execute-phase` now auto-closes pending todos for single-digit phases** — the close_phase_todos step normalizes both the phase number and each todo's `resolves_phase` value before comparing, so a todo tagged `resolves_phase: 5` is recognized when phase `05` completes. Previously the step compared the zero-padded `PHASE_NUMBER` (e.g. "05") against the unpadded value new-milestone wrote (e.g. "5") as literal strings, so every single-digit phase (1-9) silently failed to auto-close its todos — they stayed stuck in `pending/` forever despite their resolving phase completing. Decimal sub-phases (4.1 vs 04.1), letter suffixes, and quoted YAML values are now handled too. (#2576)