golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(sdk): preserve same-milestone archived phase handling (#3480)

Browse Source 
* fix(sdk): preserve same-milestone archived phase resolution (#3469)

* chore(changeset): add #3480 fragment

* fix(sdk): guard roadmapPhase null narrowing in initPhaseOp

* fix(sdk): use explicit roadmapPhase narrowing in archived guard
This commit is contained in:
Tom Boucher
2026-05-13 19:25:33 -04:00
committed by GitHub
parent 10101f07be
commit 409295b450
5 changed files with 109 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
sdk/src/query/init.ts
View File

@@ -99,6 +99,19 @@ function computeExpectedPhaseDirName(
return `${prefix}${paddedNum}-${slug}`;
}
async function shouldDropArchivedPhaseMatch(
phaseInfo: Record<string, unknown> | null,
roadmapPhase: Record<string, unknown> | null,
projectDir: string,
workstream?: string,
): Promise<boolean> {
if (!phaseInfo?.archived || !roadmapPhase || !roadmapPhase.found) return false;
const archivedTag = String(phaseInfo.archived ?? '');
const milestone = await getMilestoneInfo(projectDir, workstream);
if (milestone?.version && archivedTag === milestone.version) return false;
return true;
}
/**
* Get the latest completed milestone from MILESTONES.md.
* Port of getLatestCompletedMilestone from init.cjs lines 10-25.
@@ -169,7 +182,7 @@ async function getPhaseInfoWithFallback(
const roadmapPhase = roadmapResult.data as Record<string, unknown> | null;
// Match init.cjs: drop archived disk match when the phase is listed in the current ROADMAP
if (phaseInfo?.archived && roadmapPhase?.found) {
if (await shouldDropArchivedPhaseMatch(phaseInfo, roadmapPhase, projectDir, workstream)) {
phaseInfo = null;
}
@@ -212,7 +225,7 @@ async function getPhaseInfoForVerifyWork(
const roadmapResult = await roadmapGetPhase([phase], projectDir, workstream);
const roadmapPhase = roadmapResult.data as Record<string, unknown> | null;
if (phaseInfo?.archived && roadmapPhase?.found) {
if (await shouldDropArchivedPhaseMatch(phaseInfo, roadmapPhase, projectDir, workstream)) {
phaseInfo = null;
}
@@ -694,7 +707,7 @@ export const initPhaseOp: QueryHandler = async (args, projectDir, workstream) =>
const roadmapPhase = roadmapResult.data as Record<string, unknown> | null;
// If the only match comes from an archived milestone, prefer current ROADMAP
if (phaseInfo?.archived && roadmapPhase?.found) {
if (roadmapPhase?.found && await shouldDropArchivedPhaseMatch(phaseInfo, roadmapPhase, projectDir, workstream)) {
const phaseName = roadmapPhase.phase_name as string;
phaseInfo = {
found: true,