diff --git a/.changeset/2072-thread-model-into-routed-agent-spawns.md b/.changeset/2072-thread-model-into-routed-agent-spawns.md new file mode 100644 index 000000000..a74b21ff9 --- /dev/null +++ b/.changeset/2072-thread-model-into-routed-agent-spawns.md @@ -0,0 +1,5 @@ +--- +type: Fixed +pr: 2074 +--- +**`model_overrides` and per-phase-type models now actually apply to the assumptions-analyzer, code-reviewer, and code-fixer agents on Claude Code.** Previously `model_overrides["gsd-code-reviewer"]` / `["gsd-assumptions-analyzer"]` / `["gsd-code-fixer"]` (and `models.verification` / `models.discuss` / `models.execution`) were accepted and resolved but silently dropped — the workflows spawned these agents with no model, so they inherited the session model and the configured routing never took effect (no warning). Every spawn now threads its resolved model: `discuss-phase-assumptions`, `code-review`, and `code-review-fix` (both the re-review and the two fixer spawns) resolve it inline, and `quick`'s review step uses the code-reviewer's own resolved model instead of the executor's. The stale "`discuss` — reserved, no subagent" model-profile docs are corrected to list `gsd-assumptions-analyzer`, and the `verification` row now includes `gsd-code-reviewer`. (#2074) diff --git a/docs/CONFIGURATION.md b/docs/CONFIGURATION.md index f1c4357a8..c8db5326a 100644 --- a/docs/CONFIGURATION.md +++ b/docs/CONFIGURATION.md @@ -1114,10 +1114,10 @@ for the change to take effect. See issue #2256. | Phase type | Agents | |---|---| | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | -| `discuss` | (reserved — no subagent today) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | | `completion` | (reserved — no subagent today) | `discuss` and `completion` are accepted by the schema for forward compatibility; setting them today is a no-op until a subagent maps to them. diff --git a/docs/FEATURES.md b/docs/FEATURES.md index 1a80bd7c3..2a3bcf584 100644 --- a/docs/FEATURES.md +++ b/docs/FEATURES.md @@ -2751,10 +2751,10 @@ Users who run a memory / knowledge-base MCP server (for example, ExoCortex-style | Slot | Agents assigned | |------|-----------------| | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | -| `discuss` | (reserved for future subagent) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | | `completion` | (reserved for future subagent) | **Accepted values:** `"opus"` / `"sonnet"` / `"haiku"` / `"inherit"` diff --git a/docs/how-to/configure-model-profiles.md b/docs/how-to/configure-model-profiles.md index 153611526..8d575d2f5 100644 --- a/docs/how-to/configure-model-profiles.md +++ b/docs/how-to/configure-model-profiles.md @@ -90,8 +90,9 @@ Phase types and their agents: | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | -| `discuss`, `completion` | Reserved — no subagent today; accepted by schema for forward compatibility | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | +| `discuss` | `gsd-assumptions-analyzer` | +| `completion` | Reserved — no subagent today; accepted by schema for forward compatibility | The `models` block accepts tier aliases only (`opus`, `sonnet`, `haiku`, `inherit`). For a fully-qualified model ID, use `model_overrides` per agent instead. diff --git a/docs/ja-JP/FEATURES.md b/docs/ja-JP/FEATURES.md index 31c1da45c..0e65982f6 100644 --- a/docs/ja-JP/FEATURES.md +++ b/docs/ja-JP/FEATURES.md @@ -2676,10 +2676,10 @@ capture_thought({ | スロット | 割り当てられたエージェント | |---------|----------------------| | `planning` | `gsd-planner`、`gsd-roadmapper`、`gsd-pattern-mapper` | -| `discuss` | (将来のサブエージェント用に予約) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`、`gsd-project-researcher`、`gsd-research-synthesizer`、`gsd-codebase-mapper`、`gsd-ui-researcher` | | `execution` | `gsd-executor`、`gsd-debugger`、`gsd-doc-writer` | -| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier` | +| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier`、`gsd-code-reviewer` | | `completion` | (将来のサブエージェント用に予約) | **受け入れられる値:** `"opus"` / `"sonnet"` / `"haiku"` / `"inherit"` diff --git a/docs/ja-JP/how-to/configure-model-profiles.md b/docs/ja-JP/how-to/configure-model-profiles.md index 2cb243c82..bd59d3f3b 100644 --- a/docs/ja-JP/how-to/configure-model-profiles.md +++ b/docs/ja-JP/how-to/configure-model-profiles.md @@ -88,8 +88,9 @@ npx @opengsd/gsd-core@latest --codex --global # または --opencode、--kilo | `planning` | `gsd-planner`、`gsd-roadmapper`、`gsd-pattern-mapper` | | `research` | `gsd-phase-researcher`、`gsd-project-researcher`、`gsd-research-synthesizer`、`gsd-codebase-mapper`、`gsd-ui-researcher` | | `execution` | `gsd-executor`、`gsd-debugger`、`gsd-doc-writer` | -| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier` | -| `discuss`、`completion` | 予約済み — 現在はサブエージェントなし。スキーマの前方互換性のために受け入れられます | +| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier`、`gsd-code-reviewer` | +| `discuss` | `gsd-assumptions-analyzer` | +| `completion` | 予約済み — 現在はサブエージェントなし。スキーマの前方互換性のために受け入れられます | `models` ブロックはティアエイリアス(`opus`、`sonnet`、`haiku`、`inherit`)のみを受け入れます。特定のエージェントに完全修飾のモデル ID を指定するには `model_overrides` を使用してください。 diff --git a/docs/ko-KR/how-to/configure-model-profiles.md b/docs/ko-KR/how-to/configure-model-profiles.md index c87349c3f..e76d3758c 100644 --- a/docs/ko-KR/how-to/configure-model-profiles.md +++ b/docs/ko-KR/how-to/configure-model-profiles.md @@ -88,8 +88,9 @@ npx @opengsd/gsd-core@latest --codex --global # 또는 --opencode, --kilo 등 | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | -| `discuss`, `completion` | 예약됨 — 현재 서브에이전트 없음; 향후 호환성을 위해 스키마에서 허용 | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | +| `discuss` | `gsd-assumptions-analyzer` | +| `completion` | 예약됨 — 현재 서브에이전트 없음; 향후 호환성을 위해 스키마에서 허용 | `models` 블록은 티어 별칭만 허용합니다(`opus`, `sonnet`, `haiku`, `inherit`). 완전히 정규화된 모델 ID는 에이전트별 `model_overrides`를 사용하세요. diff --git a/docs/pt-BR/CONFIGURATION.md b/docs/pt-BR/CONFIGURATION.md index 9510927f6..fda6c8b64 100644 --- a/docs/pt-BR/CONFIGURATION.md +++ b/docs/pt-BR/CONFIGURATION.md @@ -836,10 +836,10 @@ para que a alteração entre em vigor. Consulte a issue #2256. | Tipo de fase | Agentes | |---|---| | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | -| `discuss` | (reservado — sem subagente atualmente) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | | `completion` | (reservado — sem subagente atualmente) | `discuss` e `completion` são aceitos pelo esquema para compatibilidade futura; defini-los hoje é um no-op até que um subagente seja mapeado para eles. diff --git a/docs/pt-BR/how-to/configure-model-profiles.md b/docs/pt-BR/how-to/configure-model-profiles.md index 66465a740..4f04d6b43 100644 --- a/docs/pt-BR/how-to/configure-model-profiles.md +++ b/docs/pt-BR/how-to/configure-model-profiles.md @@ -88,8 +88,9 @@ Tipos de fase e seus agentes: | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | -| `discuss`, `completion` | Reservado — nenhum subagente hoje; aceito pelo esquema para compatibilidade futura | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | +| `discuss` | `gsd-assumptions-analyzer` | +| `completion` | Reservado — nenhum subagente hoje; aceito pelo esquema para compatibilidade futura | O bloco `models` aceita apenas aliases de nível (`opus`, `sonnet`, `haiku`, `inherit`). Para um ID de modelo totalmente qualificado, use `model_overrides` por agente. diff --git a/docs/zh-CN/CONFIGURATION.md b/docs/zh-CN/CONFIGURATION.md index 2b49cf333..a43d6ba14 100644 --- a/docs/zh-CN/CONFIGURATION.md +++ b/docs/zh-CN/CONFIGURATION.md @@ -805,10 +805,10 @@ gsd-tools query config-set features.thinking_partner false | 阶段类型 | Agents | |---|---| | `planning` | `gsd-planner`, `gsd-roadmapper`, `gsd-pattern-mapper` | -| `discuss` | (保留——当前无 subagent) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`, `gsd-project-researcher`, `gsd-research-synthesizer`, `gsd-codebase-mapper`, `gsd-ui-researcher` | | `execution` | `gsd-executor`, `gsd-debugger`, `gsd-doc-writer` | -| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier` | +| `verification` | `gsd-verifier`, `gsd-plan-checker`, `gsd-integration-checker`, `gsd-nyquist-auditor`, `gsd-ui-checker`, `gsd-ui-auditor`, `gsd-doc-verifier`, `gsd-code-reviewer` | | `completion` | (保留——当前无 subagent) | `discuss` 和 `completion` 被 schema 接受以保持前向兼容性;今天设置它们是无操作,直到某个 subagent 映射到它们为止。 diff --git a/docs/zh-CN/FEATURES.md b/docs/zh-CN/FEATURES.md index 80953d3af..3d9e87e08 100644 --- a/docs/zh-CN/FEATURES.md +++ b/docs/zh-CN/FEATURES.md @@ -2692,10 +2692,10 @@ capture_thought({ | 槽位 | 分配的智能体 | |------|-----------------| | `planning` | `gsd-planner`、`gsd-roadmapper`、`gsd-pattern-mapper` | -| `discuss` | (为未来子智能体保留) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | `gsd-phase-researcher`、`gsd-project-researcher`、`gsd-research-synthesizer`、`gsd-codebase-mapper`、`gsd-ui-researcher` | | `execution` | `gsd-executor`、`gsd-debugger`、`gsd-doc-writer` | -| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier` | +| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier`、`gsd-code-reviewer` | | `completion` | (为未来子智能体保留) | **接受的值:** `"opus"` / `"sonnet"` / `"haiku"` / `"inherit"` diff --git a/docs/zh-CN/how-to/configure-model-profiles.md b/docs/zh-CN/how-to/configure-model-profiles.md index f3e790985..2bb89ae40 100644 --- a/docs/zh-CN/how-to/configure-model-profiles.md +++ b/docs/zh-CN/how-to/configure-model-profiles.md @@ -88,8 +88,9 @@ npx @opengsd/gsd-core@latest --codex --global # or --opencode, --kilo, etc. | `planning` | `gsd-planner`、`gsd-roadmapper`、`gsd-pattern-mapper` | | `research` | `gsd-phase-researcher`、`gsd-project-researcher`、`gsd-research-synthesizer`、`gsd-codebase-mapper`、`gsd-ui-researcher` | | `execution` | `gsd-executor`、`gsd-debugger`、`gsd-doc-writer` | -| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier` | -| `discuss`、`completion` | 保留——目前无子代理;已被模式接受以备向后兼容 | +| `verification` | `gsd-verifier`、`gsd-plan-checker`、`gsd-integration-checker`、`gsd-nyquist-auditor`、`gsd-ui-checker`、`gsd-ui-auditor`、`gsd-doc-verifier`、`gsd-code-reviewer` | +| `discuss` | `gsd-assumptions-analyzer` | +| `completion` | 保留——目前无子代理;已被模式接受以备向后兼容 | `models` 块仅接受层级别名(`opus`、`sonnet`、`haiku`、`inherit`)。如需使用完全限定的模型 ID,请改用按代理设置的 `model_overrides`。 diff --git a/gsd-core/references/model-profiles.md b/gsd-core/references/model-profiles.md index 52e3f7a8d..7cdefdbc8 100644 --- a/gsd-core/references/model-profiles.md +++ b/gsd-core/references/model-profiles.md @@ -45,10 +45,10 @@ Model profiles control which Claude model each GSD agent uses. This allows balan | Phase type | Agents | |---|---| | `planning` | gsd-planner, gsd-roadmapper, gsd-pattern-mapper | -| `discuss` | (reserved — no subagent today) | +| `discuss` | `gsd-assumptions-analyzer` | | `research` | gsd-phase-researcher, gsd-project-researcher, gsd-research-synthesizer, gsd-codebase-mapper, gsd-ui-researcher | | `execution` | gsd-executor, gsd-debugger, gsd-doc-writer | -| `verification` | gsd-verifier, gsd-plan-checker, gsd-integration-checker, gsd-nyquist-auditor, gsd-ui-checker, gsd-ui-auditor, gsd-doc-verifier | +| `verification` | gsd-verifier, gsd-plan-checker, gsd-integration-checker, gsd-nyquist-auditor, gsd-ui-checker, gsd-ui-auditor, gsd-doc-verifier, gsd-code-reviewer | | `completion` | (reserved — no subagent today) | ### Resolution precedence (highest to lowest) diff --git a/gsd-core/workflows/code-review-fix.md b/gsd-core/workflows/code-review-fix.md index 9a14680b6..833be2013 100644 --- a/gsd-core/workflows/code-review-fix.md +++ b/gsd-core/workflows/code-review-fix.md @@ -23,6 +23,10 @@ INIT=$(gsd_run query init.phase-op "${PHASE_ARG}") if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi AGENT_SKILLS_FIXER=$(gsd_run query agent-skills gsd-code-fixer) AGENT_SKILLS_REVIEWER=$(gsd_run query agent-skills gsd-code-reviewer) +# #2072: resolve the routed models so model_overrides / models. are honored +# (gsd-code-reviewer → "verification", gsd-code-fixer → "execution"); thread them below. +REVIEWER_MODEL=$(gsd_run query resolve-model gsd-code-reviewer --raw) +FIXER_MODEL=$(gsd_run query resolve-model gsd-code-fixer --raw) ``` Parse from init JSON: `phase_found`, `phase_dir`, `phase_number`, `phase_name`, `padded_phase`, `commit_docs`. @@ -194,7 +198,7 @@ echo "Fix scope: ${FIX_SCOPE}" Use Agent() to spawn agent: ```text -Agent(subagent_type="gsd-code-fixer", prompt=" +Agent(subagent_type="gsd-code-fixer", model="{FIXER_MODEL}", prompt=" ${REVIEW_PATH} @@ -277,7 +281,7 @@ if [ "$AUTO_MODE" = "true" ]; then # Spawn gsd-code-reviewer agent to re-review (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze) # (This overwrites REVIEW_PATH with latest review state) - Agent(subagent_type="gsd-code-reviewer", prompt=" + Agent(subagent_type="gsd-code-reviewer", model="{REVIEWER_MODEL}", prompt=" depth: ${REVIEW_DEPTH} phase_dir: ${PHASE_DIR} @@ -311,7 +315,7 @@ ${AGENT_SKILLS_REVIEWER}") # Still has issues — spawn fixer again (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze) echo "Issues remain. Applying fixes for iteration ${ITERATION}..." - Agent(subagent_type="gsd-code-fixer", prompt=" + Agent(subagent_type="gsd-code-fixer", model="{FIXER_MODEL}", prompt=" ${REVIEW_PATH} diff --git a/gsd-core/workflows/code-review.md b/gsd-core/workflows/code-review.md index 0a257473f..a559cd74a 100644 --- a/gsd-core/workflows/code-review.md +++ b/gsd-core/workflows/code-review.md @@ -22,6 +22,9 @@ PHASE_ARG="${1}" INIT=$(gsd_run query init.phase-op "${PHASE_ARG}") if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi AGENT_SKILLS_REVIEWER=$(gsd_run query agent-skills gsd-code-reviewer) +# #2072: resolve the routed model so model_overrides / models.verification are honored +# (the resolver maps gsd-code-reviewer → phaseType "verification"); thread it below. +REVIEWER_MODEL=$(gsd_run query resolve-model gsd-code-reviewer --raw) ``` Parse from init JSON: `phase_found`, `phase_dir`, `phase_number`, `phase_name`, `padded_phase`, `commit_docs`. @@ -482,7 +485,7 @@ Spawn the gsd-code-reviewer agent: Print: `◆ Spawning code reviewer... (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)` ``` -Agent(subagent_type="gsd-code-reviewer", prompt=" +Agent(subagent_type="gsd-code-reviewer", model="{REVIEWER_MODEL}", prompt=" ${FILES_TO_READ} diff --git a/gsd-core/workflows/discuss-phase-assumptions.md b/gsd-core/workflows/discuss-phase-assumptions.md index 80c6666ae..6aa600c70 100644 --- a/gsd-core/workflows/discuss-phase-assumptions.md +++ b/gsd-core/workflows/discuss-phase-assumptions.md @@ -68,6 +68,9 @@ _GSD_SHIM_NAME="gsd-tools.cjs"; _GSD_RUNTIME_ROOT="${RUNTIME_DIR:-$(git rev-pars INIT=$(gsd_run query init.phase-op "${PHASE}") if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi AGENT_SKILLS_ANALYZER=$(gsd_run query agent-skills gsd-assumptions-analyzer) +# #2072: resolve the routed model so model_overrides / models.discuss are honored +# (the resolver maps gsd-assumptions-analyzer → phaseType "discuss"); thread it below. +ANALYZER_MODEL=$(gsd_run query resolve-model gsd-assumptions-analyzer --raw) ``` Parse JSON for: `commit_docs`, `phase_found`, `phase_dir`, `phase_number`, `phase_name`, @@ -255,7 +258,7 @@ If no USER-PROFILE.md: calibration_tier = "standard" **Spawn Explore subagent** (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)**:** ``` -Agent(subagent_type="gsd-assumptions-analyzer", prompt=""" +Agent(subagent_type="gsd-assumptions-analyzer", model="{ANALYZER_MODEL}", prompt=""" Analyze the codebase for Phase {PHASE}: {phase_name}. Phase goal: {roadmap_description} diff --git a/gsd-core/workflows/quick.md b/gsd-core/workflows/quick.md index fc9f98756..b3ec7b140 100644 --- a/gsd-core/workflows/quick.md +++ b/gsd-core/workflows/quick.md @@ -134,7 +134,7 @@ AGENT_SKILLS_CHECKER=$(gsd_run query agent-skills gsd-plan-checker) AGENT_SKILLS_VERIFIER=$(gsd_run query agent-skills gsd-verifier) ``` -Parse JSON for: `planner_model`, `executor_model`, `checker_model`, `verifier_model`, `commit_docs`, `branch_name`, `quick_id`, `slug`, `date`, `timestamp`, `quick_dir`, `task_dir`, `roadmap_exists`, `planning_exists`. +Parse JSON for: `planner_model`, `executor_model`, `checker_model`, `verifier_model`, `reviewer_model`, `commit_docs`, `branch_name`, `quick_id`, `slug`, `date`, `timestamp`, `quick_dir`, `task_dir`, `roadmap_exists`, `planning_exists`. ```bash USE_WORKTREES=$(gsd_run query config-get workflow.use_worktrees --raw 2>/dev/null || echo "true") @@ -868,7 +868,7 @@ Agent( Output: ${QUICK_DIR}/${quick_id}-REVIEW.md Depth: quick", subagent_type="gsd-code-reviewer", - model="{executor_model}" + model="{reviewer_model}" ) ``` diff --git a/src/init.cts b/src/init.cts index 19d8e6f1c..5c3ac1724 100644 --- a/src/init.cts +++ b/src/init.cts @@ -758,6 +758,9 @@ function cmdInitQuick(cwd: string, description: string | undefined, raw: boolean executor_model: resolveModelInternal(cwd, 'gsd-executor'), checker_model: resolveModelInternal(cwd, 'gsd-plan-checker'), verifier_model: resolveModelInternal(cwd, 'gsd-verifier'), + // #2072: the quick review step spawns gsd-code-reviewer; resolve its own model + // so model_overrides / models.verification apply (was reusing executor_model). + reviewer_model: resolveModelInternal(cwd, 'gsd-code-reviewer'), commit_docs: config.commit_docs, branch_name: quickBranchName, diff --git a/tests/fixtures/golden-install-parity/antigravity.json b/tests/fixtures/golden-install-parity/antigravity.json index cb9ae5c8d..f685c1249 100644 --- a/tests/fixtures/golden-install-parity/antigravity.json +++ b/tests/fixtures/golden-install-parity/antigravity.json @@ -93,7 +93,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "de81380316d8a37f", - "gsd-core/references/model-profiles.md": "d6ed560db6357ad2", + "gsd-core/references/model-profiles.md": "6568ca29b6ee00d8", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "2459c40bfc8a0ea8", @@ -206,13 +206,13 @@ "gsd-core/workflows/autonomous.md": "603ce2019835f00e", "gsd-core/workflows/check-todos.md": "5a62092df800ad7c", "gsd-core/workflows/cleanup.md": "12c8fd85d3010fe6", - "gsd-core/workflows/code-review-fix.md": "5738cb929c995008", - "gsd-core/workflows/code-review.md": "d454365f1704d0bc", + "gsd-core/workflows/code-review-fix.md": "60640e633b0a124b", + "gsd-core/workflows/code-review.md": "5c40505c01871153", "gsd-core/workflows/complete-milestone.md": "aaf272074acec69d", "gsd-core/workflows/debug.md": "68f1ddc74886ebe5", "gsd-core/workflows/diagnose-issues.md": "c8c41993c277363c", "gsd-core/workflows/discovery-phase.md": "3de990caffdde4f8", - "gsd-core/workflows/discuss-phase-assumptions.md": "42210a0cbe1bac70", + "gsd-core/workflows/discuss-phase-assumptions.md": "8581fd77def7ce84", "gsd-core/workflows/discuss-phase-power.md": "5c0d1ca6abda0383", "gsd-core/workflows/discuss-phase.md": "c0a977154470b7f5", "gsd-core/workflows/discuss-phase/modes/advisor.md": "ab0c68941386998b", @@ -278,7 +278,7 @@ "gsd-core/workflows/pr-branch.md": "dc5598ae8accdecd", "gsd-core/workflows/profile-user.md": "355af92ac285567f", "gsd-core/workflows/progress.md": "79a11ce798082054", - "gsd-core/workflows/quick.md": "35582887917ef938", + "gsd-core/workflows/quick.md": "7108075f69e88e7c", "gsd-core/workflows/reapply-patches.md": "4dcd6117d0a507ca", "gsd-core/workflows/remove-phase.md": "23b9eb0858a2535e", "gsd-core/workflows/remove-workspace.md": "d0bd7e0601138798", diff --git a/tests/fixtures/golden-install-parity/augment.json b/tests/fixtures/golden-install-parity/augment.json index d4f58026c..fad055290 100644 --- a/tests/fixtures/golden-install-parity/augment.json +++ b/tests/fixtures/golden-install-parity/augment.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "8484ad9799b7f680", + "gsd-core/references/model-profiles.md": "e067ad3df6770db1", "gsd-core/references/mvp-concepts.md": "72f7e8b1f8ae7118", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "7e5683728ef33707", "gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc", "gsd-core/workflows/cleanup.md": "0daa2f2720c111f1", - "gsd-core/workflows/code-review-fix.md": "c323f7098b671bd6", - "gsd-core/workflows/code-review.md": "ad450c6ef8459dad", + "gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075", + "gsd-core/workflows/code-review.md": "334c90c401f291f8", "gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2", "gsd-core/workflows/debug.md": "849d7e5b9c12dcae", "gsd-core/workflows/diagnose-issues.md": "6cc3900891dfb927", "gsd-core/workflows/discovery-phase.md": "3ba7cfb89fb1e761", - "gsd-core/workflows/discuss-phase-assumptions.md": "1e229f6d21831d60", + "gsd-core/workflows/discuss-phase-assumptions.md": "f5b765d33eba4f88", "gsd-core/workflows/discuss-phase-power.md": "0841f7dc6e9a054a", "gsd-core/workflows/discuss-phase.md": "5c5e8d8c2c9d95aa", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "c87db7ac8c28be1b", "gsd-core/workflows/profile-user.md": "14263db831230142", "gsd-core/workflows/progress.md": "893aa3c36983f74b", - "gsd-core/workflows/quick.md": "5790ceb09aa685be", + "gsd-core/workflows/quick.md": "069fe37d083a94a3", "gsd-core/workflows/reapply-patches.md": "39050f72601aec89", "gsd-core/workflows/remove-phase.md": "df9a45f0b1880999", "gsd-core/workflows/remove-workspace.md": "a7ca66db6b7c132c", diff --git a/tests/fixtures/golden-install-parity/claude.json b/tests/fixtures/golden-install-parity/claude.json index 9127cacfc..c88ceed97 100644 --- a/tests/fixtures/golden-install-parity/claude.json +++ b/tests/fixtures/golden-install-parity/claude.json @@ -92,7 +92,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "90e2c9bc577278fd", + "gsd-core/references/model-profiles.md": "c249163663bbea53", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -205,13 +205,13 @@ "gsd-core/workflows/autonomous.md": "722397c04272dfaa", "gsd-core/workflows/check-todos.md": "6c2a43d1d3e86589", "gsd-core/workflows/cleanup.md": "0daa2f2720c111f1", - "gsd-core/workflows/code-review-fix.md": "adb62c695b39ef61", - "gsd-core/workflows/code-review.md": "6c40b95e799907d0", + "gsd-core/workflows/code-review-fix.md": "722416b71b31c5fc", + "gsd-core/workflows/code-review.md": "506412604f767adc", "gsd-core/workflows/complete-milestone.md": "dcf1182398efb1ca", "gsd-core/workflows/debug.md": "a9397fd35cca2240", "gsd-core/workflows/diagnose-issues.md": "75ffc381ac3059ff", "gsd-core/workflows/discovery-phase.md": "6161c60d752d0058", - "gsd-core/workflows/discuss-phase-assumptions.md": "46876f83547db40a", + "gsd-core/workflows/discuss-phase-assumptions.md": "a8cd1db094fefd35", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "df56c8cd170b2150", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -277,7 +277,7 @@ "gsd-core/workflows/pr-branch.md": "ab157cd8e49621dd", "gsd-core/workflows/profile-user.md": "ff3820a27731ceb8", "gsd-core/workflows/progress.md": "bd1ecf9207331bda", - "gsd-core/workflows/quick.md": "da83b1a15b7f1bf7", + "gsd-core/workflows/quick.md": "3363bdfefd403686", "gsd-core/workflows/reapply-patches.md": "ba9406b60f2c4041", "gsd-core/workflows/remove-phase.md": "ada8a0546c686483", "gsd-core/workflows/remove-workspace.md": "f3ab3a88a7e9e1ed", diff --git a/tests/fixtures/golden-install-parity/cline.json b/tests/fixtures/golden-install-parity/cline.json index bd83660d1..d98c9c048 100644 --- a/tests/fixtures/golden-install-parity/cline.json +++ b/tests/fixtures/golden-install-parity/cline.json @@ -96,7 +96,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "eb144b83e31196b8", + "gsd-core/references/model-profiles.md": "1794ad3d9854129e", "gsd-core/references/mvp-concepts.md": "72f7e8b1f8ae7118", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -209,13 +209,13 @@ "gsd-core/workflows/autonomous.md": "cc5217b1b2238a4c", "gsd-core/workflows/check-todos.md": "32fdf33f5dc8bdde", "gsd-core/workflows/cleanup.md": "b0ebfc48792b407b", - "gsd-core/workflows/code-review-fix.md": "b946fe7bcb303852", - "gsd-core/workflows/code-review.md": "0b24efcfa71a2ed2", + "gsd-core/workflows/code-review-fix.md": "e4549af672e74e6f", + "gsd-core/workflows/code-review.md": "a65e3e869508f89e", "gsd-core/workflows/complete-milestone.md": "c0808127038a8f86", "gsd-core/workflows/debug.md": "f42e8e3cbc298694", "gsd-core/workflows/diagnose-issues.md": "e616d0d730328d68", "gsd-core/workflows/discovery-phase.md": "3ba7cfb89fb1e761", - "gsd-core/workflows/discuss-phase-assumptions.md": "89987fd183e0d552", + "gsd-core/workflows/discuss-phase-assumptions.md": "9efcb2ef6a9245b3", "gsd-core/workflows/discuss-phase-power.md": "0841f7dc6e9a054a", "gsd-core/workflows/discuss-phase.md": "a290d5ee19607bb7", "gsd-core/workflows/discuss-phase/modes/advisor.md": "250de9aae90daebc", @@ -281,7 +281,7 @@ "gsd-core/workflows/pr-branch.md": "9923878a4f6a2d91", "gsd-core/workflows/profile-user.md": "26f74db0a7fcd268", "gsd-core/workflows/progress.md": "9f326d63afb4b76b", - "gsd-core/workflows/quick.md": "68a9dfcd53f0859f", + "gsd-core/workflows/quick.md": "2afc046e94daad0a", "gsd-core/workflows/reapply-patches.md": "eb4272145a117904", "gsd-core/workflows/remove-phase.md": "e336350f8113a328", "gsd-core/workflows/remove-workspace.md": "e685dfbd736dfd90", diff --git a/tests/fixtures/golden-install-parity/codebuddy.json b/tests/fixtures/golden-install-parity/codebuddy.json index 71d7569c7..31296cf05 100644 --- a/tests/fixtures/golden-install-parity/codebuddy.json +++ b/tests/fixtures/golden-install-parity/codebuddy.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "8484ad9799b7f680", + "gsd-core/references/model-profiles.md": "e067ad3df6770db1", "gsd-core/references/mvp-concepts.md": "72f7e8b1f8ae7118", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "7e5683728ef33707", "gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc", "gsd-core/workflows/cleanup.md": "0daa2f2720c111f1", - "gsd-core/workflows/code-review-fix.md": "c323f7098b671bd6", - "gsd-core/workflows/code-review.md": "ad450c6ef8459dad", + "gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075", + "gsd-core/workflows/code-review.md": "334c90c401f291f8", "gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2", "gsd-core/workflows/debug.md": "849d7e5b9c12dcae", "gsd-core/workflows/diagnose-issues.md": "77d98ac07c4a26ff", "gsd-core/workflows/discovery-phase.md": "3ba7cfb89fb1e761", - "gsd-core/workflows/discuss-phase-assumptions.md": "1e229f6d21831d60", + "gsd-core/workflows/discuss-phase-assumptions.md": "f5b765d33eba4f88", "gsd-core/workflows/discuss-phase-power.md": "0841f7dc6e9a054a", "gsd-core/workflows/discuss-phase.md": "02a5381c9a2173be", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "c87db7ac8c28be1b", "gsd-core/workflows/profile-user.md": "4fa910d15dea5695", "gsd-core/workflows/progress.md": "893aa3c36983f74b", - "gsd-core/workflows/quick.md": "9033dbe58443af36", + "gsd-core/workflows/quick.md": "cc530299ba461539", "gsd-core/workflows/reapply-patches.md": "39050f72601aec89", "gsd-core/workflows/remove-phase.md": "df9a45f0b1880999", "gsd-core/workflows/remove-workspace.md": "a7ca66db6b7c132c", diff --git a/tests/fixtures/golden-install-parity/codex.json b/tests/fixtures/golden-install-parity/codex.json index ad2b46d1f..b80bb7cd9 100644 --- a/tests/fixtures/golden-install-parity/codex.json +++ b/tests/fixtures/golden-install-parity/codex.json @@ -128,7 +128,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "86e81f17c2f23fff", + "gsd-core/references/model-profiles.md": "bd90862f68007f2e", "gsd-core/references/mvp-concepts.md": "23201c8118fb074a", "gsd-core/references/phase-argument-parsing.md": "531176f66da49c98", "gsd-core/references/planner-antipatterns.md": "2459c40bfc8a0ea8", @@ -241,13 +241,13 @@ "gsd-core/workflows/autonomous.md": "92f08626d4aea668", "gsd-core/workflows/check-todos.md": "b2b103e8638e760a", "gsd-core/workflows/cleanup.md": "5d48d64664222a3e", - "gsd-core/workflows/code-review-fix.md": "3ff5f7eac2269ca3", - "gsd-core/workflows/code-review.md": "82858ab037b9176e", + "gsd-core/workflows/code-review-fix.md": "ae7f9c6b39a23c12", + "gsd-core/workflows/code-review.md": "eadada9e0a89adf2", "gsd-core/workflows/complete-milestone.md": "017df7443bd08da5", "gsd-core/workflows/debug.md": "cc7b2d2fd4307a78", "gsd-core/workflows/diagnose-issues.md": "e38bb21d06dff077", "gsd-core/workflows/discovery-phase.md": "71a4b78ff876a854", - "gsd-core/workflows/discuss-phase-assumptions.md": "f23abfe76623ed63", + "gsd-core/workflows/discuss-phase-assumptions.md": "0d936ec25299917c", "gsd-core/workflows/discuss-phase-power.md": "3f8b83dc6be2e9d5", "gsd-core/workflows/discuss-phase.md": "7c9df6656b81fda9", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -313,7 +313,7 @@ "gsd-core/workflows/pr-branch.md": "d13e1cc81de40896", "gsd-core/workflows/profile-user.md": "05828c8cc61ef384", "gsd-core/workflows/progress.md": "7bedc431bb55edb8", - "gsd-core/workflows/quick.md": "3e7686705da2af19", + "gsd-core/workflows/quick.md": "62b9e138dc70b479", "gsd-core/workflows/reapply-patches.md": "26297b84736e66a4", "gsd-core/workflows/remove-phase.md": "9ee0fddd11a0d9d4", "gsd-core/workflows/remove-workspace.md": "19d7465aaa50cb62", diff --git a/tests/fixtures/golden-install-parity/copilot.json b/tests/fixtures/golden-install-parity/copilot.json index 0e194d4b8..f26647d5c 100644 --- a/tests/fixtures/golden-install-parity/copilot.json +++ b/tests/fixtures/golden-install-parity/copilot.json @@ -94,7 +94,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "1d392e37a746742a", - "gsd-core/references/model-profiles.md": "d6ed560db6357ad2", + "gsd-core/references/model-profiles.md": "6568ca29b6ee00d8", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "2459c40bfc8a0ea8", @@ -207,13 +207,13 @@ "gsd-core/workflows/autonomous.md": "dd972ddde9663295", "gsd-core/workflows/check-todos.md": "be9b50b5f28d7504", "gsd-core/workflows/cleanup.md": "8233b05ebf011bec", - "gsd-core/workflows/code-review-fix.md": "ab2b467b41522c10", - "gsd-core/workflows/code-review.md": "1bbbe61f45fccf4c", + "gsd-core/workflows/code-review-fix.md": "fda53892ae4b17fc", + "gsd-core/workflows/code-review.md": "f1c045ec4d33abc8", "gsd-core/workflows/complete-milestone.md": "470cf39261400ee2", "gsd-core/workflows/debug.md": "36cb536be452d79e", "gsd-core/workflows/diagnose-issues.md": "42acbe2a43fc886e", "gsd-core/workflows/discovery-phase.md": "8e99da61fb2b7074", - "gsd-core/workflows/discuss-phase-assumptions.md": "ab2d26b194805ac1", + "gsd-core/workflows/discuss-phase-assumptions.md": "ab0c432b84038681", "gsd-core/workflows/discuss-phase-power.md": "5c0d1ca6abda0383", "gsd-core/workflows/discuss-phase.md": "31a79ea11c1cdd5f", "gsd-core/workflows/discuss-phase/modes/advisor.md": "654cdaf1138d5e27", @@ -279,7 +279,7 @@ "gsd-core/workflows/pr-branch.md": "2833905f119b5722", "gsd-core/workflows/profile-user.md": "5cc032206c99ef71", "gsd-core/workflows/progress.md": "6b9a84a43dc55af5", - "gsd-core/workflows/quick.md": "7ddfe17f048541ec", + "gsd-core/workflows/quick.md": "eb68ea8748546331", "gsd-core/workflows/reapply-patches.md": "8fd59e24b486f180", "gsd-core/workflows/remove-phase.md": "e262654e319d1bc4", "gsd-core/workflows/remove-workspace.md": "ceddfeef5f2d6754", diff --git a/tests/fixtures/golden-install-parity/cursor.json b/tests/fixtures/golden-install-parity/cursor.json index dcca3bbc3..0f089726c 100644 --- a/tests/fixtures/golden-install-parity/cursor.json +++ b/tests/fixtures/golden-install-parity/cursor.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "f4c013e700c52b08", + "gsd-core/references/model-profiles.md": "5452b2e19e19f77e", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e562947d1bf5c5a4", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "4b20eda9a0b587ce", "gsd-core/workflows/check-todos.md": "1a67337d1630848f", "gsd-core/workflows/cleanup.md": "db47963f103c2748", - "gsd-core/workflows/code-review-fix.md": "49e7f024c551b3a5", - "gsd-core/workflows/code-review.md": "6a9fd2996a6b600e", + "gsd-core/workflows/code-review-fix.md": "c57af378033b1b58", + "gsd-core/workflows/code-review.md": "32c37bcbec8b8698", "gsd-core/workflows/complete-milestone.md": "1400a4856f592f3e", "gsd-core/workflows/debug.md": "a73d8018986131ba", "gsd-core/workflows/diagnose-issues.md": "cd582747131726e3", "gsd-core/workflows/discovery-phase.md": "7dcf150998559c11", - "gsd-core/workflows/discuss-phase-assumptions.md": "373788c6b7eab272", + "gsd-core/workflows/discuss-phase-assumptions.md": "c25c6a6c633d71b6", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "14688ff19ce2184c", "gsd-core/workflows/discuss-phase/modes/advisor.md": "30612a2de153cb5b", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "c67d90c65da47168", "gsd-core/workflows/profile-user.md": "8c943983241260b5", "gsd-core/workflows/progress.md": "65aabee5e8a6dd82", - "gsd-core/workflows/quick.md": "762256cf6d177c06", + "gsd-core/workflows/quick.md": "32a71f62041c8510", "gsd-core/workflows/reapply-patches.md": "ba9406b60f2c4041", "gsd-core/workflows/remove-phase.md": "ada8a0546c686483", "gsd-core/workflows/remove-workspace.md": "433affcd1a200826", diff --git a/tests/fixtures/golden-install-parity/hermes.json b/tests/fixtures/golden-install-parity/hermes.json index a76235b8d..d929d8b20 100644 --- a/tests/fixtures/golden-install-parity/hermes.json +++ b/tests/fixtures/golden-install-parity/hermes.json @@ -93,7 +93,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "8472d453a325cc1b", + "gsd-core/references/model-profiles.md": "6012c3b53473f04f", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -206,13 +206,13 @@ "gsd-core/workflows/autonomous.md": "dd572ca89862e5ec", "gsd-core/workflows/check-todos.md": "ea9a303c48a5d752", "gsd-core/workflows/cleanup.md": "6c488059fc152a49", - "gsd-core/workflows/code-review-fix.md": "04b143a963067236", - "gsd-core/workflows/code-review.md": "ff28724fc216972c", + "gsd-core/workflows/code-review-fix.md": "e829d3baf9901b54", + "gsd-core/workflows/code-review.md": "50a05ab8957bd05f", "gsd-core/workflows/complete-milestone.md": "f1866541148dc291", "gsd-core/workflows/debug.md": "15cf6999e85dcc8c", "gsd-core/workflows/diagnose-issues.md": "16f2d2a85335641f", "gsd-core/workflows/discovery-phase.md": "6161c60d752d0058", - "gsd-core/workflows/discuss-phase-assumptions.md": "db60ec68b59a40eb", + "gsd-core/workflows/discuss-phase-assumptions.md": "3a1e215890d2b3f4", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "0aa052ae4ee70bf6", "gsd-core/workflows/discuss-phase/modes/advisor.md": "536e2fa842f1bc95", @@ -278,7 +278,7 @@ "gsd-core/workflows/pr-branch.md": "ecabd55e4eabf229", "gsd-core/workflows/profile-user.md": "de5030437226cf2c", "gsd-core/workflows/progress.md": "f18db000584d9cb1", - "gsd-core/workflows/quick.md": "5044ce4e7512e174", + "gsd-core/workflows/quick.md": "e7a395b9e7786b56", "gsd-core/workflows/reapply-patches.md": "158083a310859594", "gsd-core/workflows/remove-phase.md": "fce799aae3ab2715", "gsd-core/workflows/remove-workspace.md": "8facde381657dd71", diff --git a/tests/fixtures/golden-install-parity/kilo.json b/tests/fixtures/golden-install-parity/kilo.json index 62d6de451..f9fab28cb 100644 --- a/tests/fixtures/golden-install-parity/kilo.json +++ b/tests/fixtures/golden-install-parity/kilo.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "d6ed560db6357ad2", + "gsd-core/references/model-profiles.md": "6568ca29b6ee00d8", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "2459c40bfc8a0ea8", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "73f429f7472c9949", "gsd-core/workflows/check-todos.md": "ed4b4eb12be222d7", "gsd-core/workflows/cleanup.md": "c5f1bf186395d67d", - "gsd-core/workflows/code-review-fix.md": "adb62c695b39ef61", - "gsd-core/workflows/code-review.md": "6c40b95e799907d0", + "gsd-core/workflows/code-review-fix.md": "722416b71b31c5fc", + "gsd-core/workflows/code-review.md": "506412604f767adc", "gsd-core/workflows/complete-milestone.md": "59753bf44d4300da", "gsd-core/workflows/debug.md": "a72d830ac3df74aa", "gsd-core/workflows/diagnose-issues.md": "210b5b313e8a559a", "gsd-core/workflows/discovery-phase.md": "ca7b2be46e59e862", - "gsd-core/workflows/discuss-phase-assumptions.md": "36f7edcb666745f2", + "gsd-core/workflows/discuss-phase-assumptions.md": "3ef1df313e715387", "gsd-core/workflows/discuss-phase-power.md": "5c0d1ca6abda0383", "gsd-core/workflows/discuss-phase.md": "bd4b26ba168bb51f", "gsd-core/workflows/discuss-phase/modes/advisor.md": "f8ae26ba4e07672b", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "ab157cd8e49621dd", "gsd-core/workflows/profile-user.md": "203ebe3f8f3876a8", "gsd-core/workflows/progress.md": "9381c59676ccb937", - "gsd-core/workflows/quick.md": "fd7461e5a92fe450", + "gsd-core/workflows/quick.md": "e71c92cf0463a461", "gsd-core/workflows/reapply-patches.md": "becf9728cdb124c4", "gsd-core/workflows/remove-phase.md": "ada8a0546c686483", "gsd-core/workflows/remove-workspace.md": "fc83f362a2d0a1b7", diff --git a/tests/fixtures/golden-install-parity/kimi.json b/tests/fixtures/golden-install-parity/kimi.json index 795b3c198..bdc538a2e 100644 --- a/tests/fixtures/golden-install-parity/kimi.json +++ b/tests/fixtures/golden-install-parity/kimi.json @@ -129,7 +129,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "8484ad9799b7f680", + "gsd-core/references/model-profiles.md": "e067ad3df6770db1", "gsd-core/references/mvp-concepts.md": "72f7e8b1f8ae7118", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -242,13 +242,13 @@ "gsd-core/workflows/autonomous.md": "7e5683728ef33707", "gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc", "gsd-core/workflows/cleanup.md": "0daa2f2720c111f1", - "gsd-core/workflows/code-review-fix.md": "c323f7098b671bd6", - "gsd-core/workflows/code-review.md": "ad450c6ef8459dad", + "gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075", + "gsd-core/workflows/code-review.md": "334c90c401f291f8", "gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2", "gsd-core/workflows/debug.md": "849d7e5b9c12dcae", "gsd-core/workflows/diagnose-issues.md": "67c058fc7ae6026b", "gsd-core/workflows/discovery-phase.md": "3ba7cfb89fb1e761", - "gsd-core/workflows/discuss-phase-assumptions.md": "1e229f6d21831d60", + "gsd-core/workflows/discuss-phase-assumptions.md": "f5b765d33eba4f88", "gsd-core/workflows/discuss-phase-power.md": "0841f7dc6e9a054a", "gsd-core/workflows/discuss-phase.md": "0c0465ba668adb33", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -314,7 +314,7 @@ "gsd-core/workflows/pr-branch.md": "c87db7ac8c28be1b", "gsd-core/workflows/profile-user.md": "5abfae83739fa978", "gsd-core/workflows/progress.md": "893aa3c36983f74b", - "gsd-core/workflows/quick.md": "e265e01cfe117215", + "gsd-core/workflows/quick.md": "09d88dd1c0b3e03a", "gsd-core/workflows/reapply-patches.md": "39050f72601aec89", "gsd-core/workflows/remove-phase.md": "df9a45f0b1880999", "gsd-core/workflows/remove-workspace.md": "a7ca66db6b7c132c", diff --git a/tests/fixtures/golden-install-parity/opencode.json b/tests/fixtures/golden-install-parity/opencode.json index 1da46755a..7fdd79045 100644 --- a/tests/fixtures/golden-install-parity/opencode.json +++ b/tests/fixtures/golden-install-parity/opencode.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "858c16730df68ac2", - "gsd-core/references/model-profiles.md": "d6ed560db6357ad2", + "gsd-core/references/model-profiles.md": "6568ca29b6ee00d8", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "2459c40bfc8a0ea8", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "6cb0c014f5f56965", "gsd-core/workflows/check-todos.md": "6526b64ee88c7d2e", "gsd-core/workflows/cleanup.md": "94d771d26f62dc86", - "gsd-core/workflows/code-review-fix.md": "5d97b960da4fef73", - "gsd-core/workflows/code-review.md": "aec8ef4de1829607", + "gsd-core/workflows/code-review-fix.md": "adb9388bb157610c", + "gsd-core/workflows/code-review.md": "ae6bcbd1575aeec4", "gsd-core/workflows/complete-milestone.md": "614299b2c08e66c3", "gsd-core/workflows/debug.md": "9d4a8afc8d36be93", "gsd-core/workflows/diagnose-issues.md": "2971c699d52f1b85", "gsd-core/workflows/discovery-phase.md": "724408336596c50c", - "gsd-core/workflows/discuss-phase-assumptions.md": "310b08dc31710cbc", + "gsd-core/workflows/discuss-phase-assumptions.md": "92e43cd12200c610", "gsd-core/workflows/discuss-phase-power.md": "5c0d1ca6abda0383", "gsd-core/workflows/discuss-phase.md": "3a62a8d4c374c69f", "gsd-core/workflows/discuss-phase/modes/advisor.md": "83ca3ea4fac785af", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "929b7cb0c99c7b9e", "gsd-core/workflows/profile-user.md": "248d59a31948e0ed", "gsd-core/workflows/progress.md": "8fc3404087f50b95", - "gsd-core/workflows/quick.md": "10cc8ddd4bc3f0ee", + "gsd-core/workflows/quick.md": "9bdccb7c6a5530c9", "gsd-core/workflows/reapply-patches.md": "a0e9b53f90abceb2", "gsd-core/workflows/remove-phase.md": "dea4661e8f89596f", "gsd-core/workflows/remove-workspace.md": "446847e71aa52504", diff --git a/tests/fixtures/golden-install-parity/qwen.json b/tests/fixtures/golden-install-parity/qwen.json index bf6e3e38e..3e6f677fa 100644 --- a/tests/fixtures/golden-install-parity/qwen.json +++ b/tests/fixtures/golden-install-parity/qwen.json @@ -93,7 +93,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "cc1efc2942164744", + "gsd-core/references/model-profiles.md": "0b7e06ed2e4abac8", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -206,13 +206,13 @@ "gsd-core/workflows/autonomous.md": "3014ff90115f0daf", "gsd-core/workflows/check-todos.md": "ec8c22920f6b2df1", "gsd-core/workflows/cleanup.md": "6a18b165752e3087", - "gsd-core/workflows/code-review-fix.md": "e14afce87cf0d420", - "gsd-core/workflows/code-review.md": "d6d385b6dadae5a0", + "gsd-core/workflows/code-review-fix.md": "f3725ae9d685bed2", + "gsd-core/workflows/code-review.md": "29125604bed2c467", "gsd-core/workflows/complete-milestone.md": "40085d32b15805c8", "gsd-core/workflows/debug.md": "c23d067580b09f63", "gsd-core/workflows/diagnose-issues.md": "652ae26975f82242", "gsd-core/workflows/discovery-phase.md": "6161c60d752d0058", - "gsd-core/workflows/discuss-phase-assumptions.md": "3865afc23e9cd46a", + "gsd-core/workflows/discuss-phase-assumptions.md": "18712f78bb960ec8", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "8644b72386a51241", "gsd-core/workflows/discuss-phase/modes/advisor.md": "3102430dfad9c012", @@ -278,7 +278,7 @@ "gsd-core/workflows/pr-branch.md": "cef0f65b16d500b4", "gsd-core/workflows/profile-user.md": "263c0693563d98da", "gsd-core/workflows/progress.md": "3b1b2142a74af85c", - "gsd-core/workflows/quick.md": "0a9a7dacc73f8e53", + "gsd-core/workflows/quick.md": "bb9a4a145a7edc36", "gsd-core/workflows/reapply-patches.md": "de0ee8acfe7245b2", "gsd-core/workflows/remove-phase.md": "e8ae4fbbfac700f0", "gsd-core/workflows/remove-workspace.md": "4ac64de862dc650e", diff --git a/tests/fixtures/golden-install-parity/trae.json b/tests/fixtures/golden-install-parity/trae.json index 5aecb31d3..f166276e6 100644 --- a/tests/fixtures/golden-install-parity/trae.json +++ b/tests/fixtures/golden-install-parity/trae.json @@ -93,7 +93,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "41b0af6f5f77af81", + "gsd-core/references/model-profiles.md": "b4527b0f255d193f", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e562947d1bf5c5a4", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -206,13 +206,13 @@ "gsd-core/workflows/autonomous.md": "c482645c5d1ead46", "gsd-core/workflows/check-todos.md": "0dda8236355e8c9c", "gsd-core/workflows/cleanup.md": "82f65f5214ecd748", - "gsd-core/workflows/code-review-fix.md": "959a65773b325ed2", - "gsd-core/workflows/code-review.md": "b31bbd7dbe5ed303", + "gsd-core/workflows/code-review-fix.md": "f2761f7f8c4a5674", + "gsd-core/workflows/code-review.md": "47663a2922756c5e", "gsd-core/workflows/complete-milestone.md": "6e918b72bd885426", "gsd-core/workflows/debug.md": "197d3642a6704de5", "gsd-core/workflows/diagnose-issues.md": "9274b11a3db98c65", "gsd-core/workflows/discovery-phase.md": "b32b6197b66c9a13", - "gsd-core/workflows/discuss-phase-assumptions.md": "3d05b08eae75c7bd", + "gsd-core/workflows/discuss-phase-assumptions.md": "e376b1cf29379df4", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "4509657816c5566a", "gsd-core/workflows/discuss-phase/modes/advisor.md": "c9cd7db62e76ebcb", @@ -278,7 +278,7 @@ "gsd-core/workflows/pr-branch.md": "79fd55b88ea2db9c", "gsd-core/workflows/profile-user.md": "672821e6b1266645", "gsd-core/workflows/progress.md": "94768f835b0b8908", - "gsd-core/workflows/quick.md": "9bbf907e39688638", + "gsd-core/workflows/quick.md": "a568015cccb53615", "gsd-core/workflows/reapply-patches.md": "21b38c374f19fd78", "gsd-core/workflows/remove-phase.md": "a46c2fe853bf4e86", "gsd-core/workflows/remove-workspace.md": "ae0e1c6d4438d663", diff --git a/tests/fixtures/golden-install-parity/windsurf.json b/tests/fixtures/golden-install-parity/windsurf.json index 71f434e76..1c471783e 100644 --- a/tests/fixtures/golden-install-parity/windsurf.json +++ b/tests/fixtures/golden-install-parity/windsurf.json @@ -93,7 +93,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "b3ac5dc094bce1dc", + "gsd-core/references/model-profiles.md": "09aa53e3f1764a41", "gsd-core/references/mvp-concepts.md": "3464783eaaef5c10", "gsd-core/references/phase-argument-parsing.md": "e562947d1bf5c5a4", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -206,13 +206,13 @@ "gsd-core/workflows/autonomous.md": "fe7bb7c978f305a2", "gsd-core/workflows/check-todos.md": "afc840fceb07bf99", "gsd-core/workflows/cleanup.md": "93c14107979a4428", - "gsd-core/workflows/code-review-fix.md": "9b2de93a6087774d", - "gsd-core/workflows/code-review.md": "2f0ebfb7a2e33764", + "gsd-core/workflows/code-review-fix.md": "b99b1f20bb27c291", + "gsd-core/workflows/code-review.md": "faa87faf07ae765a", "gsd-core/workflows/complete-milestone.md": "f463bf4e86ac26f6", "gsd-core/workflows/debug.md": "52243eb936a43150", "gsd-core/workflows/diagnose-issues.md": "447072aa72385271", "gsd-core/workflows/discovery-phase.md": "7dcf150998559c11", - "gsd-core/workflows/discuss-phase-assumptions.md": "f57000d5c5fb178a", + "gsd-core/workflows/discuss-phase-assumptions.md": "b091b3d3e580dd29", "gsd-core/workflows/discuss-phase-power.md": "290c0d83d783f9f6", "gsd-core/workflows/discuss-phase.md": "ce4e6abce9cb2d4e", "gsd-core/workflows/discuss-phase/modes/advisor.md": "cb49f485c4a1f09e", @@ -278,7 +278,7 @@ "gsd-core/workflows/pr-branch.md": "acd59f915d018ad4", "gsd-core/workflows/profile-user.md": "c4313672b81b5bcd", "gsd-core/workflows/progress.md": "18813a345bd2343a", - "gsd-core/workflows/quick.md": "3acd391cc0c3813a", + "gsd-core/workflows/quick.md": "b7813e1810c683e1", "gsd-core/workflows/reapply-patches.md": "d449a23d3acf6379", "gsd-core/workflows/remove-phase.md": "e7a6af429b36e77b", "gsd-core/workflows/remove-workspace.md": "b5e60fbb33b3e33a", diff --git a/tests/fixtures/golden-install-parity/zcode.json b/tests/fixtures/golden-install-parity/zcode.json index 7d18f6001..ec6c8dfc8 100644 --- a/tests/fixtures/golden-install-parity/zcode.json +++ b/tests/fixtures/golden-install-parity/zcode.json @@ -164,7 +164,7 @@ "gsd-core/references/loop-hook-dispatch.md": "32e5dfb4dba76987", "gsd-core/references/mandatory-initial-read.md": "fe59abce693717cf", "gsd-core/references/model-profile-resolution.md": "f32bb05102839767", - "gsd-core/references/model-profiles.md": "8484ad9799b7f680", + "gsd-core/references/model-profiles.md": "e067ad3df6770db1", "gsd-core/references/mvp-concepts.md": "72f7e8b1f8ae7118", "gsd-core/references/phase-argument-parsing.md": "e5bbb985f3bc3e34", "gsd-core/references/planner-antipatterns.md": "7ed54ec1e2cc54ac", @@ -277,13 +277,13 @@ "gsd-core/workflows/autonomous.md": "7e5683728ef33707", "gsd-core/workflows/check-todos.md": "bdeaf43f9c61e0cc", "gsd-core/workflows/cleanup.md": "0daa2f2720c111f1", - "gsd-core/workflows/code-review-fix.md": "c323f7098b671bd6", - "gsd-core/workflows/code-review.md": "ad450c6ef8459dad", + "gsd-core/workflows/code-review-fix.md": "2e113d1f4350a075", + "gsd-core/workflows/code-review.md": "334c90c401f291f8", "gsd-core/workflows/complete-milestone.md": "c1f91b77f4ace7f2", "gsd-core/workflows/debug.md": "849d7e5b9c12dcae", "gsd-core/workflows/diagnose-issues.md": "aa8d787db8f3c46c", "gsd-core/workflows/discovery-phase.md": "3ba7cfb89fb1e761", - "gsd-core/workflows/discuss-phase-assumptions.md": "1e229f6d21831d60", + "gsd-core/workflows/discuss-phase-assumptions.md": "f5b765d33eba4f88", "gsd-core/workflows/discuss-phase-power.md": "0841f7dc6e9a054a", "gsd-core/workflows/discuss-phase.md": "d0a67b6f77b4d339", "gsd-core/workflows/discuss-phase/modes/advisor.md": "db488d74d080c653", @@ -349,7 +349,7 @@ "gsd-core/workflows/pr-branch.md": "c87db7ac8c28be1b", "gsd-core/workflows/profile-user.md": "e23bea0a69c0bb4b", "gsd-core/workflows/progress.md": "893aa3c36983f74b", - "gsd-core/workflows/quick.md": "5747c2d8a37affbb", + "gsd-core/workflows/quick.md": "12917fdc9a624a0c", "gsd-core/workflows/reapply-patches.md": "39050f72601aec89", "gsd-core/workflows/remove-phase.md": "df9a45f0b1880999", "gsd-core/workflows/remove-workspace.md": "a7ca66db6b7c132c", diff --git a/tests/model-resolver.test.cjs b/tests/model-resolver.test.cjs index 3e2d06ddf..b902d5149 100644 --- a/tests/model-resolver.test.cjs +++ b/tests/model-resolver.test.cjs @@ -120,6 +120,36 @@ describe('resolveModelInternal', () => { assert.ok(typeof model === 'string' && model.length > 0); }); + // #2072 acceptance: these two catalog agents' config MUST resolve — the bug was + // that the workflows never threaded the resolved value, not that the resolver + // ignored it. These assert the value the (now-threaded) spawns receive. + test('#2072: model_overrides applies to gsd-code-reviewer', () => { + writeConfig(tmpDir, { model_overrides: { 'gsd-code-reviewer': 'my-custom-model' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-code-reviewer'), 'my-custom-model'); + }); + + test('#2072: model_overrides applies to gsd-assumptions-analyzer', () => { + writeConfig(tmpDir, { model_overrides: { 'gsd-assumptions-analyzer': 'my-custom-model' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-assumptions-analyzer'), 'my-custom-model'); + }); + + test('#2072: models.verification tier applies to gsd-code-reviewer', () => { + writeConfig(tmpDir, { models: { verification: 'opus' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-code-reviewer'), 'opus'); + }); + + test('#2072: models.discuss tier applies to gsd-assumptions-analyzer', () => { + writeConfig(tmpDir, { models: { discuss: 'opus' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-assumptions-analyzer'), 'opus'); + }); + + test('#2072: model_overrides + models.execution apply to gsd-code-fixer', () => { + writeConfig(tmpDir, { model_overrides: { 'gsd-code-fixer': 'my-custom-model' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-code-fixer'), 'my-custom-model'); + writeConfig(tmpDir, { models: { execution: 'opus' } }); + assert.strictEqual(resolveModelInternal(tmpDir, 'gsd-code-fixer'), 'opus'); + }); + test('runtime non-claude + model_profile_overrides for runtime tier', () => { writeConfig(tmpDir, { runtime: 'codex', diff --git a/tests/model-routing-spawn-threading.test.cjs b/tests/model-routing-spawn-threading.test.cjs new file mode 100644 index 000000000..bfa6a2ebc --- /dev/null +++ b/tests/model-routing-spawn-threading.test.cjs @@ -0,0 +1,150 @@ +// allow-test-rule: source-text-is-the-product #2072 +// Workflow .md files ARE the deployed orchestration contract the runtime executes; +// asserting that a spawn threads a resolved model= is asserting the deployed contract. + +'use strict'; + +/** + * #2072 — model_overrides / models. were silently inert for + * gsd-assumptions-analyzer and gsd-code-reviewer on Claude: the resolver honored + * them, but the workflows spawned the agents with NO model= param, so the resolved + * value never reached the Agent tool and the agents inherited the session model. + * + * Fix contract: every spawn of these two catalog agents must thread a resolved + * model=, and the workflow must obtain that model (inline `resolve-model` for the + * single-agent workflows, or the `reviewer_model` field of the init.quick bundle). + */ + +const { test, describe } = require('node:test'); +const assert = require('node:assert/strict'); +const fs = require('node:fs'); +const path = require('node:path'); + +const WF = path.join(__dirname, '..', 'gsd-core', 'workflows'); +const read = (rel) => fs.readFileSync(path.join(WF, rel), 'utf-8'); + +// Every .md under gsd-core/workflows (incl. nested steps/ and modes/). +function allWorkflowMd() { + const out = []; + (function walk(dir, rel) { + for (const e of fs.readdirSync(dir, { withFileTypes: true })) { + if (e.isDirectory()) walk(path.join(dir, e.name), path.join(rel, e.name)); + else if (e.name.endsWith('.md')) out.push(path.join(rel, e.name)); + } + })(WF, ''); + return out; +} + +// Return the full text of every `Agent( … )` call in `content`, tracking string +// state (triple- and single-double-quoted) and paren depth so a prompt body's own +// parens/quotes don't end the call early. Order-independent: a call's params are +// captured whether subagent_type= appears before or after the prompt. +function agentCalls(content) { + const calls = []; + const re = /Agent\(/g; + let m; + while ((m = re.exec(content)) !== null) { + let i = m.index + m[0].length; + let depth = 1; + let tq = false; // inside """ … """ + let sq = false; // inside " … " + while (i < content.length && depth > 0) { + if (tq) { + if (content.startsWith('"""', i)) { tq = false; i += 3; continue; } + i++; continue; + } + if (sq) { + if (content[i] === '\\') { i += 2; continue; } + if (content[i] === '"') { sq = false; } + i++; continue; + } + if (content.startsWith('"""', i)) { tq = true; i += 3; continue; } + if (content[i] === '"') { sq = true; i++; continue; } + if (content[i] === '(') { depth++; } + else if (content[i] === ')') { depth--; } + i++; + } + calls.push(content.slice(m.index, i)); + re.lastIndex = i; // don't re-scan inside this call + } + return calls; +} + +describe('#2072: routed-agent spawns thread the resolved model', () => { + test('discuss-phase-assumptions.md resolves + threads gsd-assumptions-analyzer model', () => { + const c = read('discuss-phase-assumptions.md'); + assert.match(c, /resolve-model gsd-assumptions-analyzer/, 'must resolve the routed model'); + assert.match( + c, + /subagent_type="gsd-assumptions-analyzer",\s*model="\{ANALYZER_MODEL\}"/, + 'spawn must thread the resolved model=', + ); + }); + + test('code-review.md resolves + threads gsd-code-reviewer model', () => { + const c = read('code-review.md'); + assert.match(c, /resolve-model gsd-code-reviewer/); + assert.match(c, /subagent_type="gsd-code-reviewer",\s*model="\{REVIEWER_MODEL\}"/); + }); + + test('code-review-fix.md re-review resolves + threads gsd-code-reviewer model', () => { + const c = read('code-review-fix.md'); + assert.match(c, /resolve-model gsd-code-reviewer/); + assert.match(c, /subagent_type="gsd-code-reviewer",\s*model="\{REVIEWER_MODEL\}"/); + }); + + test('quick.md review step threads gsd-code-reviewer own model (not executor_model)', () => { + const c = read('quick.md'); + // reviewer_model comes from the init.quick bundle; the spawn must use it. + assert.match(c, /subagent_type="gsd-code-reviewer",\s*\n\s*model="\{reviewer_model\}"/); + assert.doesNotMatch( + c, + /subagent_type="gsd-code-reviewer",\s*\n\s*model="\{executor_model\}"/, + 'reviewer must not reuse the executor model (own model_overrides would be ignored)', + ); + }); + + test('code-review-fix.md threads gsd-code-fixer model at both fixer spawns', () => { + const c = read('code-review-fix.md'); + assert.match(c, /resolve-model gsd-code-fixer/, 'must resolve the fixer model'); + const fixerSpawns = c.match(/subagent_type="gsd-code-fixer", model="\{FIXER_MODEL\}"/g) || []; + assert.strictEqual(fixerSpawns.length, 2, 'both gsd-code-fixer spawns must thread FIXER_MODEL'); + }); + + // Parity guard: EVERY spawn of the fixed routed agents across ALL workflows must + // carry a model= in its Agent(...) call, so a new silently-inert spawn cannot + // regress. Uses a quote/paren-aware scan of the WHOLE Agent(...) call, so it holds + // for single-line and multi-line calls, multiple spawns per file, and either param + // ordering (subagent_type= before OR after the prompt body). + test('no spawn of the fixed routed agents is missing a model= (parity guard)', () => { + const ROUTED = /subagent_type="(gsd-code-reviewer|gsd-assumptions-analyzer|gsd-code-fixer)"/; + const offenders = []; + for (const rel of allWorkflowMd()) { + for (const call of agentCalls(read(rel))) { + const routed = call.match(ROUTED); + if (routed && !/\bmodel\s*=/.test(call)) { + offenders.push(`${rel}: ${routed[1]} spawn missing model=`); + } + } + } + assert.deepEqual(offenders, [], `routed-agent spawn(s) missing model=:\n${offenders.join('\n')}`); + }); + + // The scanner itself must catch a prompt-first, un-threaded spawn (the exact blind + // spot a naive "params before prompt=" heuristic misses) — otherwise the guard + // above could pass vacuously. + test('parity guard detects a prompt-first spawn that omits model=', () => { + const synthetic = [ + 'Agent(', + ' prompt="""do the thing (with parens) and a " quote""",', + ' subagent_type="gsd-code-reviewer"', + ')', + ].join('\n'); + const [call] = agentCalls(synthetic); + assert.ok(/subagent_type="gsd-code-reviewer"/.test(call), 'scanner must capture the prompt-first subagent_type'); + assert.ok(!/\bmodel\s*=/.test(call), 'and correctly see that model= is absent'); + // A well-formed prompt-first spawn WITH model= must be accepted. + const ok = agentCalls(synthetic.replace(')', ' model="{reviewer_model}"\n)'))[0]; + assert.ok(/\bmodel\s*=/.test(ok)); + }); +}); diff --git a/tests/workflow-size-baseline.json b/tests/workflow-size-baseline.json index 945f3c59f..ac29869fe 100644 --- a/tests/workflow-size-baseline.json +++ b/tests/workflow-size-baseline.json @@ -11,13 +11,13 @@ "autonomous.md": 42474, "check-todos.md": 9475, "cleanup.md": 9941, - "code-review-fix.md": 23934, - "code-review.md": 31646, + "code-review-fix.md": 24320, + "code-review.md": 31916, "complete-milestone.md": 31071, "debug.md": 13549, "diagnose-issues.md": 12864, "discovery-phase.md": 8651, - "discuss-phase-assumptions.md": 27028, + "discuss-phase-assumptions.md": 27302, "discuss-phase-power.md": 11273, "discuss-phase.md": 31986, "do.md": 10353, @@ -59,7 +59,7 @@ "pr-branch.md": 15963, "profile-user.md": 21246, "progress.md": 30599, - "quick.md": 50452, + "quick.md": 50470, "reapply-patches.md": 20312, "remove-phase.md": 8513, "remove-workspace.md": 7551,