* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
182
gsd-core/workflows/sync-skills.md
Normal file
182
gsd-core/workflows/sync-skills.md
Normal file
@@ -0,0 +1,182 @@
|
||||
# sync-skills — Cross-Runtime GSD Skill Sync
|
||||
|
||||
**Command:** `/gsd-sync-skills`
|
||||
|
||||
Sync managed `gsd-*` skill directories from one canonical runtime's skills root to one or more destination runtime skills roots. Keeps multi-runtime installs aligned after a `gsd-update` on one runtime.
|
||||
|
||||
---
|
||||
|
||||
## Arguments
|
||||
|
||||
| Flag | Required | Default | Description |
|
||||
|------|----------|---------|-------------|
|
||||
| `--from <runtime>` | Yes | *(none)* | Source runtime — the canonical runtime to copy from |
|
||||
| `--to <runtime\|all>` | Yes | *(none)* | Destination runtime or `all` supported runtimes |
|
||||
| `--dry-run` | No | *on by default* | Preview changes without writing anything |
|
||||
| `--apply` | No | *off* | Execute the diff (overrides dry-run) |
|
||||
|
||||
If neither `--dry-run` nor `--apply` is specified, dry-run is the default.
|
||||
|
||||
**Supported runtime names:** `claude`, `codex`, `grok`, `copilot`, `cursor`, `windsurf`, `opencode`, `gemini`, `kilo`, `augment`, `trae`, `qwen`, `codebuddy`, `cline`, `antigravity` (grok uses the `~/.agents` layout)
|
||||
|
||||
---
|
||||
|
||||
## Step 1: Parse Arguments
|
||||
|
||||
```bash
|
||||
FROM_RUNTIME=""
|
||||
TO_RUNTIMES=()
|
||||
IS_APPLY=false
|
||||
|
||||
# Parse --from
|
||||
if [[ "$@" == *"--from"* ]]; then
|
||||
FROM_RUNTIME=$(echo "$@" | grep -oP '(?<=--from )\S+')
|
||||
fi
|
||||
|
||||
# Parse --to
|
||||
if [[ "$@" == *"--to all"* ]]; then
|
||||
TO_RUNTIMES=(claude codex grok copilot cursor windsurf opencode gemini kilo augment trae qwen codebuddy cline antigravity)
|
||||
elif [[ "$@" == *"--to"* ]]; then
|
||||
TO_RUNTIMES=( $(echo "$@" | grep -oP '(?<=--to )\S+') )
|
||||
fi
|
||||
|
||||
# Parse --apply
|
||||
if [[ "$@" == *"--apply"* ]]; then
|
||||
IS_APPLY=true
|
||||
fi
|
||||
```
|
||||
|
||||
**Validation:**
|
||||
- If `--from` is missing or unrecognized: print error and exit
|
||||
- If `--to` is missing or unrecognized: print error and exit
|
||||
- If `--from` == `--to` (single destination): print `[no-op: source and destination are the same runtime]` and exit
|
||||
|
||||
---
|
||||
|
||||
## Step 2: Resolve Skills Roots
|
||||
|
||||
Use `install.js --skills-root` to resolve paths — this reuses the single authoritative path table rather than duplicating it:
|
||||
|
||||
```bash
|
||||
INSTALL_JS="$(dirname "$0")/../gsd-core/bin/install.js"
|
||||
# If running from a global install, resolve relative to the GSD package
|
||||
INSTALL_JS_GLOBAL="$HOME/.claude/gsd-core/bin/install.js"
|
||||
[[ ! -f "$INSTALL_JS" ]] && INSTALL_JS="$INSTALL_JS_GLOBAL"
|
||||
|
||||
SRC_SKILLS_ROOT=$(node "$INSTALL_JS" --skills-root "$FROM_RUNTIME")
|
||||
|
||||
for DEST_RUNTIME in "${TO_RUNTIMES[@]}"; do
|
||||
DEST_SKILLS_ROOTS["$DEST_RUNTIME"]=$(node "$INSTALL_JS" --skills-root "$DEST_RUNTIME")
|
||||
done
|
||||
```
|
||||
|
||||
**Guard:** If the source skills root does not exist, print:
|
||||
```
|
||||
error: source skills root not found: <path>
|
||||
Is GSD installed globally for the '<runtime>' runtime?
|
||||
Run: node ~/.claude/gsd-core/bin/install.js --global --<runtime>
|
||||
```
|
||||
Then exit.
|
||||
|
||||
**Guard:** If `--to` contains the same runtime as `--from`, skip that destination silently.
|
||||
|
||||
---
|
||||
|
||||
## Step 3: Compute Diff Per Destination
|
||||
|
||||
For each destination runtime:
|
||||
|
||||
```bash
|
||||
# List gsd-* subdirectories in source
|
||||
SRC_SKILLS=$(ls -1 "$SRC_SKILLS_ROOT" 2>/dev/null | grep '^gsd-')
|
||||
|
||||
# List gsd-* subdirectories in destination (may not exist yet)
|
||||
DST_SKILLS=$(ls -1 "$DEST_ROOT" 2>/dev/null | grep '^gsd-')
|
||||
|
||||
# Diff:
|
||||
# CREATE — in SRC but not in DST
|
||||
# UPDATE — in both; content differs (compare recursively via checksums)
|
||||
# REMOVE — in DST but not in SRC (stale GSD skill no longer in source)
|
||||
# SKIP — in both; content identical (already up to date)
|
||||
```
|
||||
|
||||
**Non-GSD preservation:** Only `gsd-*` entries are ever created, updated, or removed. Entries in the destination that do not start with `gsd-` are never touched.
|
||||
|
||||
---
|
||||
|
||||
## Step 4: Print Diff Report
|
||||
|
||||
Always print the report, regardless of `--apply` or `--dry-run`:
|
||||
|
||||
```
|
||||
sync source: <runtime> (<src_skills_root>)
|
||||
sync targets: <dest1>, <dest2>
|
||||
|
||||
== <dest1> (<dest1_skills_root>) ==
|
||||
CREATE: gsd-help
|
||||
UPDATE: gsd-update
|
||||
REMOVE: gsd-old-command
|
||||
SKIP: gsd-plan-phase (up to date)
|
||||
(N changes)
|
||||
|
||||
== <dest2> (<dest2_skills_root>) ==
|
||||
CREATE: gsd-help
|
||||
(N changes)
|
||||
|
||||
dry-run only. use --apply to execute. ← omit this line if --apply
|
||||
```
|
||||
|
||||
If a destination root does not exist and `--apply` is true, print `CREATE DIR: <path>` before its entries.
|
||||
|
||||
If all destinations are already up to date:
|
||||
```
|
||||
All destinations are up to date. No changes needed.
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Step 5: Execute (only when --apply)
|
||||
|
||||
If `--dry-run` (or no flag): skip this step entirely and exit after printing the report.
|
||||
|
||||
For each destination with changes:
|
||||
|
||||
```bash
|
||||
mkdir -p "$DEST_ROOT"
|
||||
|
||||
for SKILL in $CREATE_LIST $UPDATE_LIST; do
|
||||
rm -rf "$DEST_ROOT/$SKILL"
|
||||
cp -r "$SRC_SKILLS_ROOT/$SKILL" "$DEST_ROOT/$SKILL"
|
||||
done
|
||||
|
||||
for SKILL in $REMOVE_LIST; do
|
||||
rm -rf "$DEST_ROOT/$SKILL"
|
||||
done
|
||||
```
|
||||
|
||||
**Idempotency:** Running `--apply` a second time with no intervening changes must report zero changes (all entries are SKIP).
|
||||
|
||||
**Atomicity:** Each skill directory is replaced as a unit (remove then copy). Partial updates of individual files within a skill are not performed — the whole directory is replaced.
|
||||
|
||||
After executing all destinations:
|
||||
|
||||
```
|
||||
Sync complete: <N> skills synced to <M> runtime(s).
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Safety Rules
|
||||
|
||||
1. **Only `gsd-*` directories** are created, updated, or removed. Any directory not starting with `gsd-` in a destination root is untouched.
|
||||
2. **Dry-run is the default.** `--apply` must be passed explicitly to write anything.
|
||||
3. **Source root must exist.** Never create the source root; it must have been created by a prior `gsd-update` or installer run.
|
||||
4. **No cross-runtime content transformation.** Sync copies files verbatim. It does not apply runtime-specific content transformations (those happen at install time). If a runtime requires transformed content (e.g. Augment's format differs), the developer should run the installer for that runtime instead of using sync.
|
||||
|
||||
---
|
||||
|
||||
## Limitations
|
||||
|
||||
- Sync copies files verbatim and does not apply runtime-specific content transformations. Use the GSD installer directly for runtimes that require format conversion.
|
||||
- Cross-project skills (`.agents/skills/`) are out of scope — this command only touches global runtime skills roots.
|
||||
- Bidirectional sync is not supported. Choose one canonical source with `--from`.
|
||||
Reference in New Issue
Block a user