* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -179,22 +179,22 @@ test('resolveBaseRef prefers explicit env override', () => {
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// NEW: Transitive test (RED against old code)
|
||||
// Fixture: tests/t.test.cjs -> ../get-shit-done/bin/lib/depA.cjs -> ./depB.cjs
|
||||
// Changed: get-shit-done/bin/lib/depB.cjs
|
||||
// Fixture: tests/t.test.cjs -> ../gsd-core/bin/lib/depA.cjs -> ./depB.cjs
|
||||
// Changed: gsd-core/bin/lib/depB.cjs
|
||||
// Expected: tests/t.test.cjs is selected
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
test('transitive: changing a deep dependency selects the test that depends on it', (t) => {
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/depB.cjs': `'use strict';\nmodule.exports = { b: 1 };\n`,
|
||||
'get-shit-done/bin/lib/depA.cjs': `'use strict';\nconst depB = require('./depB.cjs');\nmodule.exports = { a: depB };\n`,
|
||||
'tests/t.test.cjs': `'use strict';\nconst depA = require('../get-shit-done/bin/lib/depA.cjs');\n`,
|
||||
'gsd-core/bin/lib/depB.cjs': `'use strict';\nmodule.exports = { b: 1 };\n`,
|
||||
'gsd-core/bin/lib/depA.cjs': `'use strict';\nconst depB = require('./depB.cjs');\nmodule.exports = { a: depB };\n`,
|
||||
'tests/t.test.cjs': `'use strict';\nconst depA = require('../gsd-core/bin/lib/depA.cjs');\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/t.test.cjs']);
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/depB.cjs'],
|
||||
['gsd-core/bin/lib/depB.cjs'],
|
||||
['tests/t.test.cjs'],
|
||||
reverseIndex,
|
||||
);
|
||||
@@ -211,16 +211,16 @@ test('transitive: changing a deep dependency selects the test that depends on it
|
||||
|
||||
test('adversarial(a): cycle depA<->depB — changing depA selects test, no hang', (t) => {
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/depA.cjs': `'use strict';\nconst depB = require('./depB.cjs');\nmodule.exports = {};\n`,
|
||||
'get-shit-done/bin/lib/depB.cjs': `'use strict';\nconst depA = require('./depA.cjs');\nmodule.exports = {};\n`,
|
||||
'tests/cycle.test.cjs': `'use strict';\nconst depA = require('../get-shit-done/bin/lib/depA.cjs');\n`,
|
||||
'gsd-core/bin/lib/depA.cjs': `'use strict';\nconst depB = require('./depB.cjs');\nmodule.exports = {};\n`,
|
||||
'gsd-core/bin/lib/depB.cjs': `'use strict';\nconst depA = require('./depA.cjs');\nmodule.exports = {};\n`,
|
||||
'tests/cycle.test.cjs': `'use strict';\nconst depA = require('../gsd-core/bin/lib/depA.cjs');\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
|
||||
// Must complete without hanging
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/cycle.test.cjs']);
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/depA.cjs'],
|
||||
['gsd-core/bin/lib/depA.cjs'],
|
||||
['tests/cycle.test.cjs'],
|
||||
reverseIndex,
|
||||
);
|
||||
@@ -234,7 +234,7 @@ test('adversarial(a): cycle depA<->depB — changing depA selects test, no hang'
|
||||
test('adversarial(b): missing require (gone file) — null resolve, no crash', (t) => {
|
||||
const dir = makeFixture({
|
||||
// Requires a file that does not exist
|
||||
'tests/missing.test.cjs': `'use strict';\nconst x = require('../get-shit-done/bin/lib/gone.cjs');\n`,
|
||||
'tests/missing.test.cjs': `'use strict';\nconst x = require('../gsd-core/bin/lib/gone.cjs');\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
|
||||
@@ -246,7 +246,7 @@ test('adversarial(b): missing require (gone file) — null resolve, no crash', (
|
||||
|
||||
// Changing the missing file produces no selection (it doesn't exist, so no dependents)
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/gone.cjs'],
|
||||
['gsd-core/bin/lib/gone.cjs'],
|
||||
['tests/missing.test.cjs'],
|
||||
reverseIndex,
|
||||
);
|
||||
@@ -257,14 +257,14 @@ test('adversarial(b): missing require (gone file) — null resolve, no crash', (
|
||||
|
||||
test('adversarial(c): .json dependency — changing data.json selects the test', (t) => {
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/data.json': `{"key":"value"}`,
|
||||
'tests/json.test.cjs': `'use strict';\nconst data = require('../get-shit-done/bin/lib/data.json');\n`,
|
||||
'gsd-core/bin/lib/data.json': `{"key":"value"}`,
|
||||
'tests/json.test.cjs': `'use strict';\nconst data = require('../gsd-core/bin/lib/data.json');\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/json.test.cjs']);
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/data.json'],
|
||||
['gsd-core/bin/lib/data.json'],
|
||||
['tests/json.test.cjs'],
|
||||
reverseIndex,
|
||||
);
|
||||
@@ -277,15 +277,15 @@ test('adversarial(c): .json dependency — changing data.json selects the test',
|
||||
|
||||
test('adversarial(d): re-export chain — changing depB selects the test that requires the re-exporter', (t) => {
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/depB.cjs': `'use strict';\nmodule.exports = { deep: true };\n`,
|
||||
'get-shit-done/bin/lib/reexporter.cjs': `'use strict';\nmodule.exports = require('./depB.cjs');\n`,
|
||||
'tests/reexport.test.cjs': `'use strict';\nconst x = require('../get-shit-done/bin/lib/reexporter.cjs');\n`,
|
||||
'gsd-core/bin/lib/depB.cjs': `'use strict';\nmodule.exports = { deep: true };\n`,
|
||||
'gsd-core/bin/lib/reexporter.cjs': `'use strict';\nmodule.exports = require('./depB.cjs');\n`,
|
||||
'tests/reexport.test.cjs': `'use strict';\nconst x = require('../gsd-core/bin/lib/reexporter.cjs');\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/reexport.test.cjs']);
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/depB.cjs'],
|
||||
['gsd-core/bin/lib/depB.cjs'],
|
||||
['tests/reexport.test.cjs'],
|
||||
reverseIndex,
|
||||
);
|
||||
@@ -312,7 +312,7 @@ test('adversarial(e): bare and node: specifiers are ignored', () => {
|
||||
test('adversarial(f): WIDEN — changing a src file with no test dependents widens to unit/all', (t) => {
|
||||
// orphan.cjs is a source file no test file requires (statically)
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/orphan.cjs': `'use strict';\nmodule.exports = {};\n`,
|
||||
'gsd-core/bin/lib/orphan.cjs': `'use strict';\nmodule.exports = {};\n`,
|
||||
'tests/unrelated.test.cjs': `'use strict';\n// requires nothing\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
@@ -320,7 +320,7 @@ test('adversarial(f): WIDEN — changing a src file with no test dependents wide
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/unrelated.test.cjs']);
|
||||
|
||||
// Verify orphan.cjs has no dependents in the index
|
||||
const dependents = reverseIndex.get('get-shit-done/bin/lib/orphan.cjs');
|
||||
const dependents = reverseIndex.get('gsd-core/bin/lib/orphan.cjs');
|
||||
assert.ok(
|
||||
!dependents || dependents.size === 0,
|
||||
'orphan.cjs must have no transitive test dependents',
|
||||
@@ -328,7 +328,7 @@ test('adversarial(f): WIDEN — changing a src file with no test dependents wide
|
||||
|
||||
// The widen backstop is tested via the WIDEN_SIGNAL attached to pickAffectedTests result
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/orphan.cjs'],
|
||||
['gsd-core/bin/lib/orphan.cjs'],
|
||||
['tests/unrelated.test.cjs'],
|
||||
reverseIndex,
|
||||
{ detectWiden: true },
|
||||
@@ -344,7 +344,7 @@ test('adversarial(g): dynamic require in changed file with no static dependents
|
||||
// dynamic.cjs uses a template literal require — not statically parseable
|
||||
// No test requires dynamic.cjs statically
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/dynamic.cjs': `'use strict';\nconst x = 'foo';\nconst m = require(\`./\${x}\`);\nmodule.exports = {};\n`,
|
||||
'gsd-core/bin/lib/dynamic.cjs': `'use strict';\nconst x = 'foo';\nconst m = require(\`./\${x}\`);\nmodule.exports = {};\n`,
|
||||
'tests/unrelated.test.cjs': `'use strict';\n// does not require dynamic.cjs\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
@@ -352,7 +352,7 @@ test('adversarial(g): dynamic require in changed file with no static dependents
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, ['tests/unrelated.test.cjs']);
|
||||
|
||||
const selected = pickAffectedTests(
|
||||
['get-shit-done/bin/lib/dynamic.cjs'],
|
||||
['gsd-core/bin/lib/dynamic.cjs'],
|
||||
['tests/unrelated.test.cjs'],
|
||||
reverseIndex,
|
||||
{ detectWiden: true },
|
||||
@@ -531,7 +531,7 @@ test('regression(delete-only-source): deleting a source file triggers widen, nev
|
||||
// must trigger the widen backstop — gone.cjs has no static dependents because
|
||||
// it was never built into the forward graph (it doesn't exist).
|
||||
const dir = makeFixture({
|
||||
'get-shit-done/bin/lib/other.cjs': `'use strict';\nmodule.exports = {};\n`,
|
||||
'gsd-core/bin/lib/other.cjs': `'use strict';\nmodule.exports = {};\n`,
|
||||
'tests/unrelated.test.cjs': `'use strict';\n// requires nothing from gone.cjs\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
@@ -541,7 +541,7 @@ test('regression(delete-only-source): deleting a source file triggers widen, nev
|
||||
const reverseIndex = buildTransitiveReverseIndex(dir, allTests);
|
||||
|
||||
// gone.cjs does not exist in the fixture — simulates a delete-only PR.
|
||||
const changedFiles = ['get-shit-done/bin/lib/gone.cjs'];
|
||||
const changedFiles = ['gsd-core/bin/lib/gone.cjs'];
|
||||
|
||||
const selected = pickAffectedTests(changedFiles, allTests, reverseIndex, { detectWiden: true });
|
||||
|
||||
@@ -590,8 +590,8 @@ test('regression(rename-stale-old-path): deleted old path triggers widen, protec
|
||||
// dependents → widen backstop fires → mode:suites (PR_FULL_SUITES).
|
||||
const dir = makeFixture({
|
||||
// newname.cjs exists; oldname.cjs intentionally absent (it was renamed away)
|
||||
'get-shit-done/bin/lib/newname.cjs': `'use strict';\nmodule.exports = { v: 2 };\n`,
|
||||
'tests/newname.test.cjs': `'use strict';\nconst x = require('../get-shit-done/bin/lib/newname.cjs');\n`,
|
||||
'gsd-core/bin/lib/newname.cjs': `'use strict';\nmodule.exports = { v: 2 };\n`,
|
||||
'tests/newname.test.cjs': `'use strict';\nconst x = require('../gsd-core/bin/lib/newname.cjs');\n`,
|
||||
'tests/unrelated.test.cjs': `'use strict';\n// no dependency on oldname or newname\n`,
|
||||
});
|
||||
t.after(() => cleanup(dir));
|
||||
@@ -603,12 +603,12 @@ test('regression(rename-stale-old-path): deleted old path triggers widen, protec
|
||||
// changedFiles mirrors what --no-renames git diff emits for a rename:
|
||||
// Delete(old) + Add(new)
|
||||
const changedFiles = [
|
||||
'get-shit-done/bin/lib/oldname.cjs', // deleted old path — absent from disk
|
||||
'get-shit-done/bin/lib/newname.cjs', // added new path — present on disk
|
||||
'gsd-core/bin/lib/oldname.cjs', // deleted old path — absent from disk
|
||||
'gsd-core/bin/lib/newname.cjs', // added new path — present on disk
|
||||
];
|
||||
|
||||
// Assert: oldname.cjs must have zero static dependents (not in graph)
|
||||
const oldDependents = reverseIndex.get('get-shit-done/bin/lib/oldname.cjs');
|
||||
const oldDependents = reverseIndex.get('gsd-core/bin/lib/oldname.cjs');
|
||||
assert.ok(
|
||||
!oldDependents || oldDependents.size === 0,
|
||||
`oldname.cjs must have no static dependents (absent from disk), got: ${JSON.stringify(oldDependents && [...oldDependents])}`,
|
||||
|
||||
Reference in New Issue
Block a user