* fix(#3726): require --confirm before milestone complete mutates `milestone complete <version>` is a one-way door — ROADMAP.md and REQUIREMENTS.md archived, every phase directory in the milestone MOVED, STATE.md rewritten — and ran unconditionally on first invocation through every invocation path, including `query milestone.complete <version>`, whose `query` meta-prefix reads as a read-only namespace but performs no filtering (#167's invocation-compatibility shim + #3243's dotted-form normalization). The gate lives on the destructive command itself, not on the `query` prefix (the prefix is an intentional invocation mechanism, not a permission boundary — restricting it would break dozens of shipped workflow callers). Without --confirm and without --dry-run the command now refuses via error() before reading anything beyond its arg checks, so an unconfirmed invocation is a guaranteed no-op on disk. --dry-run still previews with no confirmation needed and is now documented in the usage block (it was only documented for the sibling archive-quick). --force keeps its narrow meaning — bypassing the TRUNCATED-scope and unstarted-phase guards — and does not double as the mutation opt-in. --confirm follows the existing `phases clear --confirm` idiom in the same module. complete-milestone.md's two invocations pass --confirm (the workflow has gathered explicit user intent by that step). Existing tests get --confirm appended — pre-change behavior is exactly confirmed behavior — and a #3726 regression block covers: refusal + full-tree byte-identity on both invocation forms, --force not satisfying the gate, --dry-run still passing without confirmation, and --confirm proceeding. The refusal tests fail against pre-fix code (negative control run). Fixes #3726 * docs(#3726): document the --confirm requirement in CLI-TOOLS and COMMANDS Cross-AI review of the fix diff (codex, pre-create) caught three shipped doc sites still instructing the now-refused bare invocation: the CLI-TOOLS.md milestone-complete synopsis + flag table, and COMMANDS.md's two guard-override instructions (`--force` alone now refuses without --confirm). Localized CLI-TOOLS copies already lag the English synopsis (no --force/--dry-run either) and follow the translation pipeline, not this fix. * chore(#3726): set changeset fragment pr to 3774 * test(#3726): confirm-gate CI repairs — QA scenario caller + growth ack Two CI reds from the --confirm gate, both this branch's own misses: - tests/qa/scenarios/milestone-rollover.json invoked `milestone complete 1.0 --force` as a JSON arg-array fixture — a caller shape the test sweep (which grepped runGsdTools/runSdkQuery in tests/*.cjs) never enumerated. Adds --confirm; the scenario's boundary-crossing contract is otherwise untouched. - complete-milestone.md's +420-byte --confirm note trips the emitted-attribution growth ratchet. Acknowledged as a #3726 append to the existing complete-milestone.md entry in 3409-unreachable-guard-arms.json (two ack sources may never name the same path, per that fragment's own precedent). Local: lint-emitted-drift-ack ok; loop-walk.qa 115/115 green sandboxed. * docs(#3726): CLI-TOOLS.md guard-override sentences say --force --confirm Review Major 1: the truncated-window and unstarted-phase guard paragraphs still told the reader to "Pass `--force` to override", which now refuses (--force alone does not satisfy the confirmation gate), while the flag table 470 lines later said the opposite. Mirror the docs/COMMANDS.md pair so the file no longer contradicts itself. * docs(#3726): synopsis renders --confirm and --dry-run as alternatives Review Nit 1: `milestone complete <version> --confirm [--dry-run]` read as "a dry run still needs --confirm", the opposite of AC 3. Render the pair as `(--confirm | --dry-run)` in the CLI-TOOLS.md synopsis and the usage docblock, and let the flag rows carry the rule. * test(#3726): pass --confirm in base-added milestone fixtures; re-file the growth ack Rebase onto next (26 commits) surfaced three tests the gate now refuses: the #3685 write-flag contract pair in tests/milestone.test.cjs and the `milestone complete` boundary fixture in tests/state-contract.test.cjs all invoke the command bare. Each now passes --confirm (a mutating run is exactly what they assert on). The +420 byte complete-milestone.md growth ack rode on 3409-unreachable-guard-arms.json, which #3078 swept from next as fully spent — hence the modify/delete conflict. Re-filed under a fresh fragment named for this issue, never resurrecting the swept one. * test(#3726): pin the present-but-falsy arm of the confirmation gate Review Minor 1: the boundary triple covered absent and present but not present-but-falsy. The gate is an exact-token match, so --confirm=false and --confirm=0 refuse today — pinned (canonical + query forms, whole .planning/ tree byte-identical) so a future `=`-aware or prefix-matching parser cannot silently turn --confirm=false into a confirmed run of an irreversible command. * test(#3726): drop --confirm from dry-run-only invocations Review Nit 2: --confirm was mass-appended to 14 pre-existing --dry-run invocations that never needed it, so each stopped standing as incidental proof that a preview needs no confirmation. Reverted to the pre-PR form; the dedicated AC-3 test carries the explicit assertion. * docs(#3726): sync the localized CLI-TOOLS synopsis with the confirm gate REQ-I18N-02 (docs/features/internationalized-documentation.md) requires translations to stay synchronized with the English source. The four localized CLI-TOOLS.md guides still advertised a bare `milestone complete <version>`, which now exits 1. Render the English synopsis verbatim — `(--confirm | --dry-run)` plus the `[--force]` and `[--archive-quick]` flags the translations had also fallen behind on. * test(#3726): drop --confirm from the remaining preview-only invocations Round 2 reverted the --confirm appends on --dry-run-only invocations in tests/milestone.test.cjs, but four more sat in two files the sweep missed: tests/milestone-archive.test.cjs (three) and tests/milestone-window-single-owner.test.cjs (one). Each is a preview run whose whole purpose is to document that a preview mutates nothing, so `--dry-run ... --confirm` contradicted the semantics the test exists to pin. Dropping the token restores each as incidental proof that a preview needs no confirmation; the dedicated AC-3 test keeps the explicit assertion. No assertion added, relaxed, or removed — the change is four tokens. * chore(#3726): migrate the emitted-drift ack from a fragment to a commit trailer #3954 (ADR-3942) moved emitted-drift acknowledgments out of tests/emitted-drift-acks/ and into git commit trailers, and the fragment directory no longer exists on next. The reason this PR's fragment carried moves verbatim into the Emitted-Drift-Ack-Growth trailer on this commit; the fragment file is removed rather than resurrected. Emitted-Drift-Ack-Growth: complete-milestone.md — #3726: +420 bytes (40186 -> 40606). The archive_milestone step's two `milestone complete` invocations now pass the required --confirm flag (the command refuses to mutate without it — the archive is irreversible), with a note explaining the flag and pointing at --dry-run for previews. Deliberate runtime-loaded workflow text for the new gate, not converter drift. * fix(#3726): name --confirm in the version-required refusal The documented arg-discovery path (gsd-tools.cjs top-level usage: invoke the command without args and the error lists what is required) stopped at `version required for milestone complete (e.g., v1.0)` — one required argument short. Discovering --confirm took a second round trip through the gate. The refusal now reads `… — and --confirm to mutate`, pinned by a test that also asserts the version-less invocation leaves .planning/ untouched. * test(#3726): pin the milestone complete docs against a silent regression The changeset is `type: Fixed`, which the docs-required lint exempts, so nothing in CI would notice a later edit that reinstated the bare-`--force` override prose or dropped `--confirm` from the synopsis. Four tests in tests/milestone.test.cjs now pin: the synopsis line in docs/CLI-TOOLS.md and its four localized mirrors; the `--confirm` flag row; both guard-override instructions in docs/CLI-TOOLS.md and docs/COMMANDS.md, by guard name (a substring match on each instruction's `--force --confirm` text); and — as an identity ratchet over the milestone-complete sections — every `--force` sentence or clause that lacks `--confirm`, so a new bare instruction in its own sentence or clause fails whatever its wording. Named residual: a bare instruction spliced into the same clause as a compliant one coalesces with it and passes the ratchet; the by-name pins are what keep the four known instructions from losing the pairing that way. The file is registered in scripts/docs-guard-registry.cjs so the pin runs on the PR that changes those docs, not only after merge. --------- Co-authored-by: CI Rebase Check <ci@gsd-redux> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
@@ -49,7 +49,7 @@ describe('bug #2684: milestone.complete forwards version to phases.archive', ()
|
||||
);
|
||||
fs.mkdirSync(path.join(tmpDir, '.planning', 'phases', '01-foundation'), { recursive: true });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete should succeed, got error: ${result.error}`);
|
||||
assert.ok(
|
||||
!result.error || !result.error.includes('version required'),
|
||||
@@ -67,7 +67,7 @@ describe('bug #2684: milestone.complete forwards version to phases.archive', ()
|
||||
// the guard, so give Phase 1 a real directory so the scan is satisfied.
|
||||
fs.mkdirSync(path.join(tmpDir, '.planning', 'phases', '01-foundation'), { recursive: true });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v2.5'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v2.5', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.version, 'v2.5');
|
||||
});
|
||||
@@ -82,7 +82,7 @@ describe('bug #2684: milestone.complete forwards version to phases.archive', ()
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-PLAN.md'), '# Plan');
|
||||
fs.writeFileSync(path.join(phaseDir, '01-01-SUMMARY.md'), '# Summary');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-phases'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-phases', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete --archive-phases failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.version, 'v1.0');
|
||||
assert.ok(result.data.archived.phases === true, 'phases should be archived');
|
||||
@@ -580,7 +580,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
});
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'STATE.md'), quickTasksStateWithRows(1));
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, false, 'archived.quick must be false when --archive-quick is absent');
|
||||
assert.ok(fs.existsSync(quickDir), 'quick task directory must remain in place');
|
||||
@@ -601,7 +601,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
for (const name of names) writeQuickTaskDir(tmpDir, name);
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'STATE.md'), quickTasksStateWithRows(3));
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete --archive-quick failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, true);
|
||||
|
||||
@@ -631,7 +631,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
test('noOpsWhenQuickDirectoryAbsent', () => {
|
||||
setupQuickArchiveRoadmap(tmpDir);
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, false);
|
||||
assert.ok(!fs.existsSync(path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick')));
|
||||
@@ -641,7 +641,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
setupQuickArchiveRoadmap(tmpDir);
|
||||
fs.mkdirSync(path.join(tmpDir, '.planning', 'quick'), { recursive: true });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, false, 'boundary 0: an empty quick dir must not count as archived');
|
||||
assert.ok(
|
||||
@@ -654,7 +654,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
setupQuickArchiveRoadmap(tmpDir);
|
||||
writeQuickTaskDir(tmpDir, '2026-02-01-only-one');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, true, 'boundary 1: a single quick task dir must archive');
|
||||
assert.ok(fs.existsSync(path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick', '2026-02-01-only-one')));
|
||||
@@ -665,7 +665,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
writeQuickTaskDir(tmpDir, '2026-02-01-first');
|
||||
writeQuickTaskDir(tmpDir, '2026-02-02-second');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, true, 'boundary 2: multiple quick task dirs must archive');
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
@@ -678,7 +678,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
writeQuickTaskDir(tmpDir, '2026-03-01-no-section');
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'STATE.md'), '# STATE\n\n### Blockers/Concerns\nNone\n');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete must succeed even without a Quick Tasks Completed section: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, true);
|
||||
assert.ok(fs.existsSync(path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick', '2026-03-01-no-section')));
|
||||
@@ -709,7 +709,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
].join('\n');
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'STATE.md'), nonCanonicalState);
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete must succeed even when the reset is refused: ${result.error}`);
|
||||
// The quick directories still move — only the STATE.md table reset is refused.
|
||||
assert.strictEqual(result.data.archived.quick, true);
|
||||
@@ -741,7 +741,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
fs.mkdirSync(path.join(archiveDir, name), { recursive: true });
|
||||
fs.writeFileSync(path.join(archiveDir, name, 'existing-marker.txt'), 'prior run\n');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.ok(fs.existsSync(path.join(archiveDir, name, 'existing-marker.txt')), 'prior archive entry must survive');
|
||||
assert.strictEqual(
|
||||
@@ -761,7 +761,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
const name = '2026-05-01-per-task-summary';
|
||||
writeQuickTaskDir(tmpDir, name, { [`${name}-SUMMARY.md`]: '# Summary\nDid the thing.\n' });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
assert.ok(fs.statSync(path.join(archiveDir, 'README.md')).isFile(), 'README.md index must be generated');
|
||||
@@ -788,7 +788,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
const name = '2026-05-02-bare-summary';
|
||||
writeQuickTaskDir(tmpDir, name, { 'SUMMARY.md': '# Summary\nDid the other thing.\n' });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
assert.ok(fs.statSync(path.join(archiveDir, 'README.md')).isFile(), 'README.md index must be generated');
|
||||
@@ -807,7 +807,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
const name = '2026-05-03-no-summary';
|
||||
writeQuickTaskDir(tmpDir, name); // no files at all
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
assert.ok(fs.statSync(path.join(archiveDir, 'README.md')).isFile(), 'README.md index must be generated');
|
||||
@@ -823,7 +823,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'quick', 'stray-notes.txt'), 'not a task dir\n');
|
||||
writeQuickTaskDir(tmpDir, '2026-06-01-real-task');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.ok(
|
||||
fs.existsSync(path.join(tmpDir, '.planning', 'quick', 'stray-notes.txt')),
|
||||
@@ -864,7 +864,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
setupQuickArchiveRoadmap(tmpDir);
|
||||
writeQuickTaskDir(tmpDir, '2026-08-01-evil-version');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', '../evil', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', '../evil', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.strictEqual(result.success, false, 'a version containing a path separator must be rejected');
|
||||
assert.ok(!fs.existsSync(path.join(tmpDir, '..', 'evil')), 'nothing must be created outside the temp fixture root');
|
||||
const milestonesDir = path.join(tmpDir, '.planning', 'milestones');
|
||||
@@ -884,7 +884,7 @@ describe('#2142: quick task archival at milestone close-out', () => {
|
||||
const name = '2026-01-01-café report';
|
||||
writeQuickTaskDir(tmpDir, name);
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.ok(
|
||||
fs.existsSync(path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick', name)),
|
||||
@@ -924,7 +924,7 @@ describe('#2142 escalation: milestone.archive-quick — narrow archival entry po
|
||||
fs.writeFileSync(path.join(tmpDir, '.planning', 'milestones', 'v1.0-ROADMAP.md'), archivedRoadmap);
|
||||
|
||||
// Confirm the premise this command exists to fix.
|
||||
const milestoneCompleteResult = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const milestoneCompleteResult = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.strictEqual(
|
||||
milestoneCompleteResult.success,
|
||||
false,
|
||||
@@ -1078,7 +1078,7 @@ describe('#2142 review: README injection, symlink escape, dry-run/real-run parit
|
||||
throw err;
|
||||
}
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
@@ -1121,7 +1121,7 @@ describe('#2142 review: README injection, symlink escape, dry-run/real-run parit
|
||||
try {
|
||||
writeQuickTaskDir(tmpDir, '2026-10-02-real-task');
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete failed: ${result.error}`);
|
||||
assert.strictEqual(result.data.archived.quick, true, 'the real task dir must still archive');
|
||||
|
||||
@@ -1182,7 +1182,7 @@ describe('#2142 review: README injection, symlink escape, dry-run/real-run parit
|
||||
'the skipped symlink entry must not appear in the dry-run preview',
|
||||
);
|
||||
|
||||
const real = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick'], tmpDir);
|
||||
const real = runSdkQuery(['milestone.complete', 'v1.0', '--archive-quick', '--confirm'], tmpDir);
|
||||
assert.ok(real.success, `real run failed: ${real.error}`);
|
||||
const archiveDir = path.join(tmpDir, '.planning', 'milestones', 'v1.0-quick');
|
||||
const archivedNames = fs
|
||||
@@ -1252,7 +1252,7 @@ describe('#3597: milestone complete refuses to archive on a non-COMPLETE window
|
||||
test('archives NOTHING and leaves every phase dir on disk when the workstream has no ROADMAP.md', () => {
|
||||
const alphaPhases = seedUnreadableWorkstream(tmpDir);
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete should still succeed (UNREADABLE is not a whole-command refusal): ${result.error}`);
|
||||
|
||||
assert.strictEqual(result.data.archived.phases, false, 'phases must NOT be reported as archived');
|
||||
@@ -1311,7 +1311,7 @@ describe('#3597: milestone complete refuses to archive on a non-COMPLETE window
|
||||
fs.mkdirSync(path.join(betaPhases, '01-foo'), { recursive: true });
|
||||
fs.mkdirSync(path.join(betaPhases, '02-out-of-window'), { recursive: true });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete should succeed: ${result.error}`);
|
||||
|
||||
assert.strictEqual(result.data.archived.phases, true, 'phases must be reported as archived');
|
||||
@@ -1346,7 +1346,7 @@ describe('#3597: milestone complete refuses to archive on a non-COMPLETE window
|
||||
fs.mkdirSync(path.join(phasesDir, '01-parser'), { recursive: true });
|
||||
fs.mkdirSync(path.join(phasesDir, '02-printable-output'), { recursive: true });
|
||||
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--force'], tmpDir);
|
||||
const result = runSdkQuery(['milestone.complete', 'v1.0', '--force', '--confirm'], tmpDir);
|
||||
assert.ok(result.success, `milestone.complete should succeed: ${result.error}`);
|
||||
|
||||
assert.strictEqual(result.data.archived.phases, true, 'phases must still be archived for an UNSCOPED (not UNREADABLE) window');
|
||||
|
||||
Reference in New Issue
Block a user