fix(commands): normalize gsd slash namespace drift (#2858)
* fix(commands): normalize gsd slash namespace drift * fix(#2855): address CodeRabbit findings on namespace drift PR Three CR findings, all valid: 1. autonomous.md line 783 still had `gsd:discuss-phase` (the PR's own normalization missed this line). Switched to `gsd-discuss-phase` and updated the matching test in autonomous-interactive.test.cjs that was asserting the now-retired colon form. 2. tests/bug-2543-gsd-slash-namespace.test.cjs source-grepped the fix-slash-commands.cjs script with .includes() rather than driving its transform behaviour. Refactored fix-slash-commands.cjs to export a pure transformContent(src, cmdNames) function, kept the CLI behaviour unchanged via require.main, and replaced the source-grep block with five behavioural cases: rewrite, multi-occurrence, idempotence on canonical input, no-op on gsd-sdk/gsd-tools, and word-boundary safety. 3. tests/bug-2808-skill-hyphen-name.test.cjs matched `name:` anywhere in SKILL.md; a stray name: in the body could satisfy the assertion. Scoped the lookup to the YAML frontmatter block via the suggested diff (parse the leading --- ... --- region first, then find name: inside it). Full suite: 5854/5854 passing. * fix(#2855): address remaining CodeRabbit findings on PR #2858 Three structural concerns flagged on the namespace-drift fix PR: 1. scripts/fix-slash-commands.cjs:24 — `buildPattern([])` compiled `/gsd:()(?=[^a-zA-Z0-9_-]|$)/g`. The empty capture group still matches any `/gsd:` token followed by a non-word boundary (whitespace, EOL, punctuation), rewriting it to a stray `/gsd-`. Verified live: `transformContent("/gsd:", [])` → `"/gsd-"`. Added a guard returning null from `buildPattern` on empty input and updated `transformContent` and `processDir` to no-op when the pattern is null. 2. tests/autonomous-interactive.test.cjs:44-47 — assertion was `content.includes('gsd-discuss-phase') && content.includes('INTERACTIVE')`, which would false-pass on any unrelated co-occurrence (e.g. `INTERACTIVE=""` initialization plus a stray `gsd-discuss-phase` prose mention). Replaced with a structural extraction: locate the `**If \`INTERACTIVE\` is set:**` branch, bound it by the next `**If` / `<step>` boundary, and assert the `Skill(skill="gsd-discuss-phase", ...)` invocation lives inside that region. Tolerates whitespace around `(`, `skill`, and `=`. 3. tests/bug-2808-skill-hyphen-name.test.cjs:104 — colon-call regex was `Skill\(skill=...` and missed valid formatting like `Skill(skill = "gsd:cmd")` or `Skill( skill = ...)`. Loosened to `Skill\(\s*skill\s*=\s*...` so reformatting drift can't slip past the namespace guard. Verification: 5854/5854 pass on `npm test` from the rebased branch. * fix(#2855): drop pre-validation filter that hid namespace drift CR finding on tests/bug-2808-skill-hyphen-name.test.cjs:128: the test collected generated skill directories with `.filter(entry => entry.isDirectory() && entry.name.startsWith('gsd-'))`, then validated namespace invariants over that filtered list. Anything that violated the prefix invariant — `gsd:extract-learnings` (colon form), `extract_learnings` without prefix, `Gsd-foo` mis-cased — would silently disappear from the iteration and the test would falsely pass. Drop the `startsWith('gsd-')` filter so every generated directory shows up. Add explicit assertions before the existing per-skill loop: - directory list is non-empty (catches a broken converter that produces nothing) - every directory begins with `gsd-` - every directory contains no `:` - every directory contains no `_` Re-audited the full PR diff for the same anti-pattern: only this one site filtered before validating the namespace; bug-2643 and commands-doc-parity also use `readdirSync().filter()` but only by file extension, which is correct. 5854/5854 on `npm test`. * fix(#2855): address remaining CR findings (1 active + 2 nitpicks) Three findings on PR #2858, all the same root cause: input narrowing before validation lets drift slip past the guards. 1. tests/bug-2808-...:104 (active) — `colonCallRe` captured local names with `[a-z0-9-]+`, which excluded the underscore. A drift like `Skill(skill="gsd:extract_learnings")` (deprecated colon syntax with the old underscore filename) silently slid through. Broadened the capture to `[^'"\s)]+` so any malformed local name is surfaced; surrounding pattern (whitespace tolerance, escape support, flags) unchanged. 2. tests/bug-2643-...:43 (nitpick) — `extractSkillNamesHyphen` and `extractSkillNamesColon` had the same over-strict capture plus relied on a single regex over raw bytes, which the project test- rigor memory bans (`feedback_no_source_grep_tests.md`). Replaced with `extractSkillCalls(content)` — a small structural extractor that walks `Skill(` openers, locates each call's matching `)`, parses the body's `skill = "..."` keyword argument with permissive whitespace + quoting + escape handling, and returns `{ name, raw }` records. The two namespace-form helpers become thin filters over the structured output. Tightened the body class to `[^'"\\]+` so a trailing escape `\` before the closing quote (as in `Skill(skill=\"gsd-foo\", …)` written inside another string context) doesn't get included in the captured name. 3. tests/bug-2543-...:44 (nitpick) — `DOC_SEARCH_FILES` was a hand- curated 7-entry array. Every doc added in the future would silently weaken drift detection until someone remembered to extend the list. Replaced with `discoverDocSearchFiles(ROOT)`: globs every `.md` under `docs/` and adds `README.md` if present. New docs are picked up automatically. Re-audited the diff surface for similar narrowings; no other sites filter or constrain before validating namespace invariants. 5854/5854 on `npm test`. * fix(#2855): recurse docs/ tree so localized translations are scanned too CR finding: discoverDocSearchFiles() stopped at docs/*.md, leaving localized translation trees (docs/ja-JP/, docs/zh-CN/, docs/ko-KR/, docs/pt-BR/) and other nested doc collections (docs/skills/, docs/superpowers/) invisible to the namespace-drift invariant. Verified the gap: docs/ has 6 nested directories with ~30 .md files that the previous top-level-only scan was skipping. None contain /gsd: references today, but a future translation update or new doc subdir could leak drift. Switch to an iterative stack walk so every .md under docs/ is scanned regardless of depth. Stack form (rather than recursion) avoids the risk of running into the call-stack limit on deep doc trees. 5854/5854 on `npm test`. --------- Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
Jeremy McSpadden
@@ -38,10 +38,40 @@ describe('autonomous --interactive flag (#1413)', () => {
|
||||
});
|
||||
|
||||
test('workflow uses discuss-phase skill in interactive mode', () => {
|
||||
// Per #2697 the user-facing form is the hyphen invariant gsd-discuss-phase;
|
||||
// the colon form was retired and is enforced absent by bug-2543 tests.
|
||||
//
|
||||
// Don't `.includes()` against the full file — both tokens could appear in
|
||||
// unrelated sections (e.g. INTERACTIVE="" initialization + a stray
|
||||
// gsd-discuss-phase mention in prose) and falsely pass. Instead, isolate
|
||||
// the structural region that gates on INTERACTIVE and assert the Skill
|
||||
// invocation lives inside it.
|
||||
const content = fs.readFileSync(workflowPath, 'utf8');
|
||||
const interactiveMarker = '**If `INTERACTIVE` is set:**';
|
||||
const branchStart = content.indexOf(interactiveMarker);
|
||||
assert.notStrictEqual(
|
||||
branchStart, -1,
|
||||
`workflow must define an explicit '${interactiveMarker}' branch`,
|
||||
);
|
||||
// Bound the branch by the next "**If `..." prose marker (the non-interactive
|
||||
// sibling) or, failing that, the next `<step ...>`/`</step>` boundary.
|
||||
const afterStart = branchStart + interactiveMarker.length;
|
||||
const candidates = [
|
||||
content.indexOf('**If `INTERACTIVE` is NOT set', afterStart),
|
||||
content.indexOf('**If `', afterStart),
|
||||
content.indexOf('</step>', afterStart),
|
||||
content.indexOf('<step ', afterStart),
|
||||
].filter((i) => i !== -1);
|
||||
assert.ok(candidates.length > 0, 'INTERACTIVE branch must have a closing boundary');
|
||||
const branchEnd = Math.min(...candidates);
|
||||
const branch = content.slice(branchStart, branchEnd);
|
||||
|
||||
// The branch must invoke the hyphen-form Skill. Tolerate whitespace
|
||||
// around `(`, `skill`, and `=` so harmless reformatting doesn't break this.
|
||||
const skillCall = /Skill\(\s*skill\s*=\s*['"]gsd-discuss-phase['"]/.test(branch);
|
||||
assert.ok(
|
||||
content.includes('gsd:discuss-phase') && content.includes('INTERACTIVE'),
|
||||
'workflow should invoke gsd:discuss-phase when INTERACTIVE is set'
|
||||
skillCall,
|
||||
`INTERACTIVE branch must invoke Skill(skill="gsd-discuss-phase"). Got branch:\n${branch}`,
|
||||
);
|
||||
});
|
||||
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
'use strict';
|
||||
|
||||
// allow-test-rule: structural-regression-guard
|
||||
|
||||
/**
|
||||
* Slash-command namespace invariant (#2543, updated by #2697).
|
||||
*
|
||||
@@ -14,8 +16,8 @@
|
||||
*
|
||||
* Invariant enforced here:
|
||||
* No `/gsd:<cmd>` pattern in user-facing source text.
|
||||
* `Skill(skill="gsd:<cmd>")` calls (no leading slash) are ALLOWED — they use
|
||||
* frontmatter `name:` resolution internally and are not user-typed commands.
|
||||
* `Skill(skill="gsd:<cmd>")` calls are checked by the skill frontmatter
|
||||
* parity tests and should use `Skill(skill="gsd-<cmd>")`.
|
||||
*
|
||||
* Exceptions:
|
||||
* - CHANGELOG.md: historical entries document commands under their original names.
|
||||
@@ -39,6 +41,45 @@ const SEARCH_DIRS = [
|
||||
COMMANDS_DIR,
|
||||
];
|
||||
|
||||
// Discover user-facing markdown surfaces dynamically so a freshly added
|
||||
// doc (a new RELEASE-*.md, a new top-level guide) is automatically scanned
|
||||
// for namespace drift. A hand-curated list silently weakens drift detection
|
||||
// over time — every time a doc is added, someone has to remember to extend
|
||||
// the list, and the failure mode is invisible: the test passes but doesn't
|
||||
// actually inspect the new file. We scan every .md under docs/ plus
|
||||
// README.md at the repo root.
|
||||
function discoverDocSearchFiles(root) {
|
||||
const out = [];
|
||||
const readme = path.join(root, 'README.md');
|
||||
if (fs.existsSync(readme)) out.push(readme);
|
||||
// Walk docs/ recursively. Localized translation trees (docs/ja-JP/,
|
||||
// docs/zh-CN/, docs/ko-KR/, docs/pt-BR/) and nested doc collections
|
||||
// (docs/skills/, docs/superpowers/) all carry user-facing markdown that
|
||||
// can drift; a top-level-only scan would silently exclude them. Iterative
|
||||
// stack walk avoids recursion limits on deep trees.
|
||||
const stack = [path.join(root, 'docs')];
|
||||
while (stack.length > 0) {
|
||||
const dir = stack.pop();
|
||||
let entries;
|
||||
try {
|
||||
entries = fs.readdirSync(dir, { withFileTypes: true });
|
||||
} catch {
|
||||
continue;
|
||||
}
|
||||
for (const entry of entries) {
|
||||
const full = path.join(dir, entry.name);
|
||||
if (entry.isDirectory()) {
|
||||
stack.push(full);
|
||||
} else if (entry.isFile() && entry.name.endsWith('.md')) {
|
||||
out.push(full);
|
||||
}
|
||||
}
|
||||
}
|
||||
return out.sort();
|
||||
}
|
||||
|
||||
const DOC_SEARCH_FILES = discoverDocSearchFiles(ROOT);
|
||||
|
||||
const EXTENSIONS = new Set(['.md', '.cjs', '.js']);
|
||||
|
||||
function collectFiles(dir, results = []) {
|
||||
@@ -62,6 +103,7 @@ const cmdNames = fs.readdirSync(COMMANDS_DIR)
|
||||
const retiredPattern = new RegExp(`/gsd:(${cmdNames.join('|')})(?=[^a-zA-Z0-9_-]|$)`);
|
||||
|
||||
const allFiles = SEARCH_DIRS.flatMap(d => collectFiles(d));
|
||||
const allUserFacingFiles = allFiles.concat(DOC_SEARCH_FILES.filter((file) => fs.existsSync(file)));
|
||||
|
||||
describe('slash-command namespace invariant (#2697)', () => {
|
||||
test('commands/gsd/ directory contains known command files', () => {
|
||||
@@ -72,7 +114,7 @@ describe('slash-command namespace invariant (#2697)', () => {
|
||||
|
||||
test('no /gsd:<cmd> retired syntax in user-facing source files', () => {
|
||||
const violations = [];
|
||||
for (const file of allFiles) {
|
||||
for (const file of allUserFacingFiles) {
|
||||
const src = fs.readFileSync(file, 'utf-8');
|
||||
const lines = src.split('\n');
|
||||
for (let i = 0; i < lines.length; i++) {
|
||||
@@ -88,6 +130,58 @@ describe('slash-command namespace invariant (#2697)', () => {
|
||||
);
|
||||
});
|
||||
|
||||
test('command filenames use canonical hyphenated command slugs', () => {
|
||||
const underscoreFiles = fs.readdirSync(COMMANDS_DIR)
|
||||
.filter((f) => f.endsWith('.md') && f.includes('_'));
|
||||
assert.deepStrictEqual(
|
||||
underscoreFiles,
|
||||
[],
|
||||
'command filenames feed generated skill/autocomplete names and must not contain underscores',
|
||||
);
|
||||
});
|
||||
|
||||
describe('fix-slash-commands transformer behavior', () => {
|
||||
const { transformContent } = require(path.join(ROOT, 'scripts', 'fix-slash-commands.cjs'));
|
||||
// Use the live command names so the transformer matches the same surface
|
||||
// the production CLI rewrites.
|
||||
const liveCmdNames = cmdNames;
|
||||
|
||||
test('rewrites /gsd:<cmd> to /gsd-<cmd>', () => {
|
||||
const out = transformContent('See /gsd:plan-phase for details.', liveCmdNames);
|
||||
assert.ok(out.includes('/gsd-plan-phase'), `expected /gsd-plan-phase, got: ${out}`);
|
||||
assert.ok(!out.includes('/gsd:plan-phase'), `colon form must not survive, got: ${out}`);
|
||||
});
|
||||
|
||||
test('rewrites multiple occurrences in one pass', () => {
|
||||
const out = transformContent('Run /gsd:plan-phase then /gsd:execute-phase.', liveCmdNames);
|
||||
assert.ok(out.includes('/gsd-plan-phase'));
|
||||
assert.ok(out.includes('/gsd-execute-phase'));
|
||||
assert.ok(!out.match(/\/gsd:[a-z]/), `no colon form may remain, got: ${out}`);
|
||||
});
|
||||
|
||||
test('does not rewrite canonical hyphen form (idempotent)', () => {
|
||||
const input = '/gsd-plan-phase is the canonical name.';
|
||||
assert.strictEqual(transformContent(input, liveCmdNames), input,
|
||||
'transformer must be a no-op when input is already canonical');
|
||||
});
|
||||
|
||||
test('does not rewrite gsd-sdk or gsd-tools (not slash commands)', () => {
|
||||
// Edge case: even though sdk/tools aren't in cmdNames, defensively check
|
||||
// that strings like "/gsd:sdk" pass through untouched.
|
||||
const input = 'Run /gsd:sdk query and /gsd:tools init.';
|
||||
assert.strictEqual(transformContent(input, liveCmdNames), input,
|
||||
'transformer must leave non-command identifiers alone');
|
||||
});
|
||||
|
||||
test('respects word boundary — does not rewrite /gsd:plan-phase-extra', () => {
|
||||
// The trailing -extra means this is NOT the plan-phase command.
|
||||
// The negative lookahead `[^a-zA-Z0-9_-]|$` should prevent the match.
|
||||
const out = transformContent('/gsd:plan-phase-extra', liveCmdNames);
|
||||
assert.strictEqual(out, '/gsd:plan-phase-extra',
|
||||
'word-boundary lookahead must prevent partial matches');
|
||||
});
|
||||
});
|
||||
|
||||
test('gsd-sdk and gsd-tools identifiers are not rewritten', () => {
|
||||
for (const file of allFiles) {
|
||||
const src = fs.readFileSync(file, 'utf-8');
|
||||
|
||||
@@ -40,20 +40,63 @@ function collectFiles(dir, results) {
|
||||
return results;
|
||||
}
|
||||
|
||||
/**
|
||||
* Extract every `Skill(skill="<name>")` invocation as a structured record.
|
||||
*
|
||||
* Per project test rigor (`feedback_no_source_grep_tests.md`), this parses
|
||||
* each call as a unit instead of leaning on a single regex over raw bytes.
|
||||
* The flow is:
|
||||
*
|
||||
* 1. Strip HTML comments so commented-out examples don't count as drift.
|
||||
* 2. Walk the content for `Skill(` openers; for each, find the matching
|
||||
* `)` closer (Skill bodies are simple kwarg lists, no nesting).
|
||||
* 3. Parse the call body for the `skill = "..."` keyword argument.
|
||||
* Permissive whitespace around the keyword and `=`, permissive
|
||||
* single/double quoting (with optional `\` escapes from string-
|
||||
* embedded examples), permissive name body — so malformed drift like
|
||||
* `Skill(skill="gsd:extract_learnings")` is surfaced rather than
|
||||
* silently skipped by an over-strict character class.
|
||||
*
|
||||
* Returns `[{ name, raw }]` per call. Filtering by namespace (gsd- vs gsd:)
|
||||
* happens at the call site so the extractor stays neutral.
|
||||
*/
|
||||
function extractSkillCalls(content) {
|
||||
const stripped = content.replace(/<!--[\s\S]*?-->/g, '');
|
||||
const calls = [];
|
||||
// Body class excludes backslash so the extractor doesn't include an
|
||||
// escape character that precedes the closing quote in embedded examples
|
||||
// (e.g. `Skill(skill=\"gsd-plan-phase\", …)` written inside a string
|
||||
// context). A trailing `\` is permitted on the closing-quote side via the
|
||||
// optional `\\?` so both `\"` and `"` close the value cleanly.
|
||||
const argRe = /^\s*skill\s*=\s*\\?(['"])([^'"\\]+)\\?\1/i;
|
||||
let i = 0;
|
||||
while (i < stripped.length) {
|
||||
const open = stripped.indexOf('Skill(', i);
|
||||
if (open === -1) break;
|
||||
const close = stripped.indexOf(')', open);
|
||||
if (close === -1) break;
|
||||
const body = stripped.slice(open + 'Skill('.length, close);
|
||||
const match = body.match(argRe);
|
||||
if (match) calls.push({ name: match[2], raw: stripped.slice(open, close + 1) });
|
||||
i = close + 1;
|
||||
}
|
||||
return calls;
|
||||
}
|
||||
|
||||
function extractSkillNamesHyphen(content) {
|
||||
const names = new Set();
|
||||
const rx = /Skill\(skill=['"]gsd-([a-z0-9-]+)['"]/gi;
|
||||
let m;
|
||||
while ((m = rx.exec(content)) !== null) names.add('gsd-' + m[1]);
|
||||
return names;
|
||||
return new Set(
|
||||
extractSkillCalls(content)
|
||||
.map((c) => c.name)
|
||||
.filter((n) => n.startsWith('gsd-')),
|
||||
);
|
||||
}
|
||||
|
||||
function extractSkillNamesColon(content) {
|
||||
const names = new Set();
|
||||
const rx = /Skill\(skill=['"]gsd:([a-z0-9-]+)['"]/gi;
|
||||
let m;
|
||||
while ((m = rx.exec(content)) !== null) names.add('gsd:' + m[1]);
|
||||
return names;
|
||||
return new Set(
|
||||
extractSkillCalls(content)
|
||||
.map((c) => c.name)
|
||||
.filter((n) => n.startsWith('gsd:')),
|
||||
);
|
||||
}
|
||||
|
||||
describe('skill frontmatter name parity (#2643 / #2808)', () => {
|
||||
|
||||
@@ -11,7 +11,7 @@
|
||||
* #2643. Since then, workflows have been updated to use hyphen form (#2808).
|
||||
*
|
||||
* Fix: skillFrontmatterName() now returns the hyphen form unchanged.
|
||||
* Four workflow Skill() colon calls updated to hyphen.
|
||||
* Workflow Skill() colon calls are updated to hyphen.
|
||||
*
|
||||
* This test verifies:
|
||||
* 1. skillFrontmatterName returns hyphen form (not colon).
|
||||
@@ -27,9 +27,10 @@ const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('node:fs');
|
||||
const path = require('node:path');
|
||||
const { cleanup, createTempDir } = require('./helpers.cjs');
|
||||
|
||||
const ROOT = path.join(__dirname, '..');
|
||||
const { convertClaudeCommandToClaudeSkill, skillFrontmatterName } =
|
||||
const { convertClaudeCommandToClaudeSkill, copyCommandsAsClaudeSkills, skillFrontmatterName } =
|
||||
require(path.join(ROOT, 'bin', 'install.js'));
|
||||
|
||||
const WORKFLOWS_DIR = path.join(ROOT, 'get-shit-done', 'workflows');
|
||||
@@ -100,7 +101,16 @@ describe('bug-2808: SKILL.md name: uses hyphen form', () => {
|
||||
// Parsing line-by-line is more precise than a multi-line regex
|
||||
// and avoids false positives from incidental matches in prose.
|
||||
for (const line of stripped.split('\n')) {
|
||||
const colonCallRe = /Skill\(skill=['"]gsd:([a-z0-9-]+)['"]/gi;
|
||||
// Tolerate whitespace around the parenthesis, the `skill` keyword,
|
||||
// and the `=` so variants like `Skill( skill = "gsd:foo" )` are still
|
||||
// flagged. Without the `\s*` allowances, drift slips through this guard.
|
||||
//
|
||||
// The local-name capture must be permissive (`[^'"\s)]+`, not
|
||||
// `[a-z0-9-]+`) — the whole purpose of this guard is to surface
|
||||
// *malformed* drift, including legacy underscore-form names like
|
||||
// `gsd:extract_learnings`. A character-class that excludes the very
|
||||
// characters we need to flag would silently let drift through.
|
||||
const colonCallRe = /Skill\(\s*skill\s*=\s*\\?['"]gsd:([^'"\s)]+)\\?['"]/gi;
|
||||
let m;
|
||||
while ((m = colonCallRe.exec(line)) !== null) {
|
||||
colonCalls.push(`${path.basename(f)}: Skill(skill="gsd:${m[1]}")`);
|
||||
@@ -113,4 +123,55 @@ describe('bug-2808: SKILL.md name: uses hyphen form', () => {
|
||||
'deprecated colon-form Skill() calls found — update to gsd-<cmd>: ' + colonCalls.join(', ')
|
||||
);
|
||||
});
|
||||
|
||||
test('generated autocomplete skill surface uses hyphen names without underscores', (t) => {
|
||||
const tmp = createTempDir('gsd-autocomplete-surface-');
|
||||
t.after(() => cleanup(tmp));
|
||||
const skillsDir = path.join(tmp, 'skills');
|
||||
copyCommandsAsClaudeSkills(COMMANDS_DIR, skillsDir, 'gsd', '$HOME/.claude/', 'claude', true);
|
||||
|
||||
// Don't filter the directory listing by `startsWith('gsd-')` — that
|
||||
// would silently hide exactly the kind of drift this test exists to
|
||||
// catch (a `gsd:extract-learnings` colon variant or a bare
|
||||
// `extract-learnings` without the namespace prefix would never be
|
||||
// collected, and the loop below would never see them). Capture every
|
||||
// generated directory and assert the namespace invariants explicitly.
|
||||
const skillDirs = fs.readdirSync(skillsDir, { withFileTypes: true })
|
||||
.filter((entry) => entry.isDirectory())
|
||||
.map((entry) => entry.name)
|
||||
.sort();
|
||||
|
||||
assert.ok(skillDirs.length > 0, 'expected generated skill directories under skillsDir');
|
||||
for (const dir of skillDirs) {
|
||||
assert.ok(
|
||||
dir.startsWith('gsd-'),
|
||||
`${dir}: generated skill directory must start with the canonical 'gsd-' namespace`,
|
||||
);
|
||||
assert.ok(
|
||||
!dir.includes(':'),
|
||||
`${dir}: generated skill directory must not contain the retired colon namespace separator`,
|
||||
);
|
||||
assert.ok(
|
||||
!dir.includes('_'),
|
||||
`${dir}: generated skill directory must use hyphens, not underscores`,
|
||||
);
|
||||
}
|
||||
|
||||
assert.ok(skillDirs.includes('gsd-extract-learnings'), 'autocomplete surface must include gsd-extract-learnings');
|
||||
assert.ok(!skillDirs.includes('gsd-extract_learnings'), 'autocomplete surface must not include gsd-extract_learnings');
|
||||
|
||||
for (const skillDir of skillDirs) {
|
||||
const skillContent = fs.readFileSync(path.join(skillsDir, skillDir, 'SKILL.md'), 'utf-8');
|
||||
// Scope the name: lookup to the YAML frontmatter block so a stray
|
||||
// `name:` line in the body cannot satisfy the assertion.
|
||||
const fmMatch = skillContent.match(/^---\n([\s\S]*?)\n---/);
|
||||
assert.ok(fmMatch, `${skillDir}: generated SKILL.md must include frontmatter`);
|
||||
const nameLine = fmMatch[1].split('\n').find((l) => /^name:\s*/.test(l));
|
||||
assert.ok(nameLine, `${skillDir}: generated SKILL.md is missing name: frontmatter`);
|
||||
const name = nameLine.replace(/^name:\s*/, '').trim();
|
||||
assert.ok(name.startsWith('gsd-'), `${skillDir}: autocomplete name must start with gsd-, got ${name}`);
|
||||
assert.ok(!name.includes(':'), `${skillDir}: autocomplete name must not contain colon, got ${name}`);
|
||||
assert.ok(!name.includes('_'), `${skillDir}: autocomplete name must not contain underscore, got ${name}`);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
@@ -35,9 +35,7 @@ function mentionedInInventory(slug) {
|
||||
|
||||
describe('every shipped command is documented somewhere', () => {
|
||||
for (const file of commandFiles) {
|
||||
// Command files may use `_` in their filename (e.g. extract_learnings.md)
|
||||
// while the user-facing slash command uses `-` (/gsd-extract-learnings).
|
||||
const slug = file.replace(/\.md$/, '').replace(/_/g, '-');
|
||||
const slug = file.replace(/\.md$/, '');
|
||||
test(`/gsd-${slug}`, () => {
|
||||
const inCommandsDoc = mentionedInCommandsDoc(slug);
|
||||
const inInventory = mentionedInInventory(slug);
|
||||
|
||||
@@ -11,12 +11,12 @@ const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
|
||||
const COMMAND_PATH = path.join(__dirname, '..', 'commands', 'gsd', 'extract_learnings.md');
|
||||
const COMMAND_PATH = path.join(__dirname, '..', 'commands', 'gsd', 'extract-learnings.md');
|
||||
const WORKFLOW_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'extract_learnings.md');
|
||||
|
||||
describe('extract-learnings command', () => {
|
||||
test('command file exists', () => {
|
||||
assert.ok(fs.existsSync(COMMAND_PATH), 'commands/gsd/extract_learnings.md should exist');
|
||||
assert.ok(fs.existsSync(COMMAND_PATH), 'commands/gsd/extract-learnings.md should exist');
|
||||
});
|
||||
|
||||
test('command file has correct name frontmatter', () => {
|
||||
|
||||
Reference in New Issue
Block a user