fix(#3309): make the lint guard's W024 exemption explicit, not accidental

W024's committed rule (state-consistency.cts) is a documented permanent
no-op — its real check runs in cmdValidateHealth itself, outside the
rule table, since readStateHeadFreshness needs a git-log shell-out no
Rule.check may perform. The guard's §8.5 fixture-proof check previously
"passed" for W024 only because some test file's title happened to
contain the string "W024" — not because any fixture actually proves it
fires, which it structurally never can. Found by the Spec-axis
orthogonal review.

Adds an explicit PERMANENTLY_INERT_CODES map (currently just W024,
with its reason recorded) that checkFixtureProofInvariant reports
separately from real coverage. The guard's PASS output now says
"30 covered by a real fixture, 1 exempted" instead of implying uniform
proof — a code with no coverage and no exemption entry still fails.
This commit is contained in:
sim
2026-08-13 02:56:47 -04:00
parent 8e1ff76204
commit 4f9e5cf2ed
2 changed files with 122 additions and 7 deletions

View File

@@ -21,6 +21,7 @@ const {
checkOneToOneInvariant,
checkFixtureProofInvariant,
findHealthDiagnosticTestFiles,
PERMANENTLY_INERT_CODES,
} = guard;
const FAKE_SEVERITY = Object.freeze({ ERROR: 'error', WARNING: 'warning', INFO: 'info' });
@@ -151,6 +152,75 @@ describe('checkFixtureProofInvariant (§8.5)', () => {
});
});
// ─── Check 2b — §8.5 EXCEPTION: PERMANENTLY_INERT_CODES ────────────────────
//
// A code whose `check` is a documented permanent no-op (W024 — see
// `scripts/lint-health-diagnostic-rule-table.cjs`'s own `PERMANENTLY_INERT_CODES`
// comment) can never satisfy a real fixture-proof. It must be reported as
// `exempted`, separately from genuinely-covered codes, and must NEVER land in
// `uncovered` — regardless of whether any test file happens to mention it.
describe('checkFixtureProofInvariant — PERMANENTLY_INERT_CODES exemption (§8.5 exception)', () => {
test('an exempted code with ZERO test coverage anywhere still passes (not uncovered), and is reported as exempted', (t) => {
const dir = createTempDir('gsd-lint-hd-rt-exempt-nomention-');
t.after(() => cleanup(dir));
const file = writeTempTestFile(dir, 'fake.test.cjs', "describe('unrelated', () => {});\n");
const rules = [{ code: 'W024' }];
const inertCodes = new Map([['W024', 'permanent no-op, real check lives outside the rule table']]);
const { uncovered, exempted } = checkFixtureProofInvariant(rules, [file], inertCodes);
assert.deepEqual(uncovered, [], 'an exempted code must never be reported as uncovered');
assert.deepEqual(exempted, ['W024']);
});
test('a code NOT in the exemption map, with zero test coverage, still fails as uncovered', (t) => {
const dir = createTempDir('gsd-lint-hd-rt-not-exempt-');
t.after(() => cleanup(dir));
const file = writeTempTestFile(dir, 'fake.test.cjs', "describe('unrelated', () => {});\n");
const rules = [{ code: 'W998' }];
const inertCodes = new Map([['W024', 'permanent no-op']]); // W998 is NOT in this map
const { uncovered, exempted } = checkFixtureProofInvariant(rules, [file], inertCodes);
assert.deepEqual(uncovered, ['W998'], 'a non-exempted, uncovered code must still fail the guard');
assert.deepEqual(exempted, []);
});
test('an exempted code is reported as exempted even when a test file DOES happen to mention it in a titled block', (t) => {
const dir = createTempDir('gsd-lint-hd-rt-exempt-mentioned-');
t.after(() => cleanup(dir));
const file = writeTempTestFile(
dir,
'fake.test.cjs',
"test('exports exactly 1 rule: W024', () => {});\n",
);
const rules = [{ code: 'W024' }];
const inertCodes = new Map([['W024', 'permanent no-op']]);
const { uncovered, exempted } = checkFixtureProofInvariant(rules, [file], inertCodes);
assert.deepEqual(uncovered, []);
assert.deepEqual(exempted, ['W024'], 'must be classified as exempted, not folded into ordinary coverage');
});
test('W024 is exempted (not uncovered, not silently "covered") against the real tests/ tree and the real PERMANENTLY_INERT_CODES map', () => {
const testFiles = findHealthDiagnosticTestFiles();
const { uncovered, exempted } = checkFixtureProofInvariant([{ code: 'W024' }], testFiles);
assert.deepEqual(uncovered, []);
assert.deepEqual(exempted, ['W024']);
});
test('PERMANENTLY_INERT_CODES locks exactly W024 with a non-empty, auditable reason', () => {
assert.deepEqual([...PERMANENTLY_INERT_CODES.keys()], ['W024']);
const reason = PERMANENTLY_INERT_CODES.get('W024');
assert.equal(typeof reason, 'string');
assert.ok(reason.length > 0);
assert.ok(/ambient I\/O|§8\.1/i.test(reason), 'reason should explain the §8.1 rule 1 constraint');
});
});
// ─── findHealthDiagnosticTestFiles ─────────────────────────────────────────
describe('findHealthDiagnosticTestFiles', () => {