* fix(#2305): stage shared guard hooks for Kilo — drop skipSharedHooksInstall Kilo's capability descriptor declared BOTH hostBehaviors.nativePlugin (a plugin that spawns the shared PreToolUse guard scripts as subprocesses) AND hostBehaviors.skipSharedHooksInstall:true, which suppresses staging of hooks/*.js into the Kilo config dir. The plugin's runHook treats an absent hook script as a silent allow, so every guard it spawned (gsd-prompt-guard, gsd-read-guard, gsd-worktree-path-guard) no-opped on every Kilo install. OpenCode uses the byte-identical plugin with hook staging on and is unaffected — it is the reference shape. The skip flag predates Kilo's plugin surface: it dates to #1821 (hooks were dead weight for a runtime with no hook consumer), and #2093 added the hooks-dependent nativePlugin without revisiting it. - capabilities/kilo/capability.json: remove skipSharedHooksInstall (regenerated gsd-core/bin/lib/capability-registry.cjs accordingly) - bin/install.js: correct the stale #1821 comments claiming Kilo has no plugin surface - tests/kilo-upgrades.test.cjs: install-fixture tests (global + local) asserting the guard scripts land where the plugin's walk-up resolves them; an end-to-end test driving a disallowed out-of-worktree write through the REAL installed Kilo tree and asserting the guard rejects it; a cross-runtime descriptor invariant (nativePlugin and skipSharedHooksInstall:true must never coexist) - tests/kilo-imperative-reference.test.cjs: flip the pinned assertion - golden fixtures regenerated (kilo now stages the 24 hook files, same set as OpenCode) Fixes #2305 * fix(#2305): warn loudly when a guard hook script is missing (runHook) runHook's absent-file branch returned a silent exit-0 allow — the mechanism that let #2305 ship undetected: with the hooks bundle never staged on Kilo, every PreToolUse guard the plugin spawned resolved to "file not found → allow" with zero signal anywhere. Keep the adapter's design contract (a missing hook must never break the tool call — pinned by the existing adapter test) but make the absence loud: console.error once per hook file, naming the unresolved path and the remediation. Applied identically to .kilo/ and .opencode/ plugin copies (byte-parity guard). Golden parity fixtures regenerated (the installed plugin file's hash changed). Fixes #2305 * chore(#2305): add changeset fragment * test(#2305): include gsd-workflow-guard.js in the staged-guards regression list The native plugin spawns four guards on write-like tool calls — the regression test's PLUGIN_GUARD_HOOKS list covered three. Staging itself was already asserted via the golden fixtures (the full bundle), but the named per-guard assertion should cover every guard the plugin actually dispatches. Surfaced by cross-AI review of PR #2327. * test(#2305): update the #1821 tests that encoded Kilo's false no-plugin premise The #1821 hook-copy test asserted Kilo must receive no staged hooks — the exact behavior this PR reverses (and the cause of all 8 CI failures). Kilo moves from the ZCode "no dead hooks" loop to the OpenCode group, with positive assertions on the new contract: the three guard hooks the plugin spawns, hooks/lib/git-cmd.js, and plugins/gsd-core.js all staged. The integration runtime contract flips kilo packageJson to true (the CommonJS marker ships with the bundle), and the pi contract comment no longer cites Kilo as a no-plugin runtime. * chore(#2305): scope the queued #1821 changeset fragment to ZCode only The fragment still claimed the installer skips hooks for Kilo — rendering both it and this PR's fragment into the same release would ship two contradictory statements about Kilo's install behavior. It now claims ZCode only and notes that #2327 reverses the Kilo half. * chore(#2305): rename changeset fragment to the generator naming convention 2305-kilo-stage-guard-hooks.md -> loud-guard-hooks.md, matching the <adjective>-<noun>-<noun> shape npm run changeset generates (review nit). --------- Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
@@ -11059,13 +11059,15 @@ function install(isGlobal, runtime = DEFAULT_RUNTIME, options = {}) {
|
||||
}
|
||||
|
||||
// Gate hooks/lib/ install on the same set of runtimes that receive hooks/.
|
||||
// Codex/Copilot/Cursor/Windsurf/Trae/Cline/Kilo do not use the shared
|
||||
// Codex/Copilot/Cursor/Windsurf/Trae/Cline do not use the shared
|
||||
// hooks/lib/ helpers (Cursor uses standalone .js hook scripts registered
|
||||
// via hooks.json — gated descriptor-driven via
|
||||
// hostBehaviors.skipSharedHooksInstall, #2089; Cline likewise #2090; Kilo
|
||||
// likewise #2093; Trae likewise #2094; Codex uses hooks.json directly;
|
||||
// the others skip hooks entirely); Kilo and ZCode also skip hooks entirely
|
||||
// (hooksSurface:'none' with no plugin surface — #1821). None of the
|
||||
// hostBehaviors.skipSharedHooksInstall, #2089; Cline likewise #2090;
|
||||
// Trae likewise #2094; Codex uses hooks.json directly;
|
||||
// the others skip hooks entirely); ZCode also skips hooks entirely
|
||||
// (hooksSurface:'none' with no plugin surface — #1821). Kilo is NOT
|
||||
// excluded since #2305: its native plugin adapter (#2093) spawns the
|
||||
// staged hooks/*.js scripts, same as OpenCode. None of the
|
||||
// excluded runtimes must receive the hooks/lib/ helpers — otherwise the
|
||||
// Codex comment downstream ("we deliberately do *not* copy hooks/lib/ for
|
||||
// Codex") is contradicted in practice. (Gating lives at the call sites
|
||||
@@ -11081,18 +11083,21 @@ function install(isGlobal, runtime = DEFAULT_RUNTIME, options = {}) {
|
||||
return hooksOk;
|
||||
}
|
||||
|
||||
// #1821: Kilo and ZCode declare hooksSurface:'none' AND have no plugin surface,
|
||||
// so the staged hook scripts are dead weight for them — exclude both here.
|
||||
// #1821: ZCode declares hooksSurface:'none' AND has no plugin surface,
|
||||
// so the staged hook scripts are dead weight for it — excluded here.
|
||||
// OpenCode also declares hooksSurface:'none' but is deliberately NOT excluded:
|
||||
// its native plugin adapter (#1914, installed above under plugins/gsd-core.js)
|
||||
// spawns the staged hooks/*.js scripts via OpenCode's event bus and needs both
|
||||
// them and the CommonJS package.json marker written below.
|
||||
// them and the CommonJS package.json marker written below. Kilo is the same
|
||||
// shape since #2093 (a nativePlugin spawning the staged hooks), so it must
|
||||
// NOT skip either — declaring skipSharedHooksInstall:true alongside a
|
||||
// nativePlugin left every guard the plugin spawns a silent no-op (#2305).
|
||||
// #2089: Cursor's exclusion is now descriptor-driven via
|
||||
// hostBehaviors.skipSharedHooksInstall (was hardcoded !isCursor).
|
||||
// #2090: Cline's exclusion is likewise descriptor-driven (cline declares
|
||||
// skipSharedHooksInstall:true) — the redundant `&& !isCline` was removed.
|
||||
// #2093: Kilo's exclusion is likewise descriptor-driven (kilo declares
|
||||
// skipSharedHooksInstall:true) — the redundant `&& !isKilo` was removed.
|
||||
// #2093/#2305: Kilo's former exclusion (descriptor-driven via
|
||||
// skipSharedHooksInstall:true) was removed in #2305 — see above.
|
||||
// #2094: Trae's exclusion is likewise descriptor-driven (trae declares
|
||||
// skipSharedHooksInstall:true) — the redundant `&& !isTrae` was removed.
|
||||
// #2101: ZCode's exclusion is likewise descriptor-driven (zcode declares
|
||||
|
||||
Reference in New Issue
Block a user