From 578a7fbc1766f4e21fa03f236da55b8942378657 Mon Sep 17 00:00:00 2001
From: Tom Boucher <trekkie@nomorestars.com>
Date: Sun, 12 Jul 2026 15:10:54 -0400
Subject: [PATCH] test(#2150): cover UI hint yes/no authority in
 checkUiPresence

Adds the divergent input the green suite lacked: the documented `**UI hint**:
no` metadata line. Asserts hint:no is authoritative non-frontend (no false
positive), hint:yes is authoritative frontend, a malformed hint is stripped so
its bare UI token does not fire, and hint:no overrides genuine UI language.
---
 tests/ui-safety-gate.test.cjs | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tests/ui-safety-gate.test.cjs b/tests/ui-safety-gate.test.cjs
index 2111aca9b..6d5810f91 100644
--- a/tests/ui-safety-gate.test.cjs
+++ b/tests/ui-safety-gate.test.cjs
@@ -80,4 +80,34 @@ describe('checkUiPresence', () => {
     assert.ok(result.tokens.includes('dashboard'));
     assert.ok(result.tokens.includes('form'));
   });
+
+  // ── #2150: the `**UI hint**: yes|no` metadata line must not false-positive ──
+
+  test('#2150 `**UI hint**: no` is authoritative non-frontend (no false positive)', () => {
+    const result = checkUiPresence('**UI hint**: no\n\nBackend-only spike for RBAC/Entra.\n');
+    assert.strictEqual(result.hasUI, false,
+      'a phase that explicitly declares UI hint: no must not be flagged as UI');
+    assert.deepStrictEqual(result.tokens, []);
+  });
+
+  test('#2150 `**UI hint**: yes` is authoritative frontend', () => {
+    const result = checkUiPresence('**UI hint**: yes\n\nRefactor the login screen layout.\n');
+    assert.strictEqual(result.hasUI, true,
+      'a phase that explicitly declares UI hint: yes must be flagged as UI');
+  });
+
+  test('#2150 a hint line without yes/no is stripped (bare UI token does not fire)', () => {
+    // A malformed hint (`UI hint: maybe`) must not false-positive on the bare
+    // `UI` token in the line itself; other UI tokens elsewhere still detect.
+    const result = checkUiPresence('**UI hint**: maybe\n\nBackend REST API only.\n');
+    assert.strictEqual(result.hasUI, false,
+      'the bare UI token in a UI hint line must not count as a UI indicator');
+  });
+
+  test('#2150 hint: no overrides even genuine UI language elsewhere', () => {
+    // The explicit declaration is authoritative — the author owns it.
+    const result = checkUiPresence('**UI hint**: no\n\nBuild a dashboard component.\n');
+    assert.strictEqual(result.hasUI, false,
+      'an explicit UI hint: no overrides token-sniffing');
+  });
 });