golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#4786): plan-row detection accepts the bare planId stem — suffix-less hand-written lists tick in place (#4880)

Browse Source 
* test(#4786): failing-first — a suffix-less hand-written plan list is ticked in place, never duplicated

* fix(#4786): plan-row detection accepts the bare planId stem — a suffix-less hand-written list is ticked in place, never duplicated

* chore(#4786): backfill changeset PR number (4880)

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-09-19 21:06:05 -04:00
committed by GitHub
parent 6dcc0428dd
commit 5906a24ede
3 changed files with 142 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/roadmap.cts
View File

@@ -1274,9 +1274,28 @@ function cmdRoadmapUpdatePlanProgress(cwd: string, phaseNum: string | null | und
// Detection is scoped to the active region so a plan that appears in an
// archived <details> block is still correctly detected as missing from the
// active milestone section.
//
// #4786: a plan row may be written WITH the `-PLAN.md` suffix (canonical
// template form) or WITHOUT it (hand-written form: `- [x] 659-01 — desc`).
// The tick loop above keys on the bare planId stem with a PREFIX match
// (pre-existing, out of scope here), while detection required the full
// `-PLAN.md` filename — so every suffix-less row was counted missing and
// the insertion fired BESIDE the recognized list — 32 checkbox lines for
// 16 plans, exit 0. The stem arm below accepts the bare id only up to a
// boundary (whitespace / `:` / dashes / `-PLAN.md` / `.md` / `**` / `)`),
// so `5-011` never satisfies `5-01`. Deliberately NOT in the boundary set:
// `.` — a dotted sub-id (`5-01.5`) is a real distinct plan, and counting
// its row as 5-01's presence would suppress a genuine insertion.
const missingPlans = phaseInfo!.plans.filter((planFile) => {
const planEscaped = escapeRegex(planFile);
return !new RegExp(`-\\s*\\[[x ]\\]\\s*(?:\\*\\*)?${planEscaped}`, 'i').test(activeRegion);
if (new RegExp(`-\\s*\\[[x ]\\]\\s*(?:\\*\\*)?${planEscaped}`, 'i').test(activeRegion)) return false;
const stem = planFile.replace(/-PLAN\.md$/i, '');
const stemEscaped = escapeRegex(stem);
const stemPresent = new RegExp(
`-\\s*\\[[x ]\\]\\s*(?:\\*\\*)?${stemEscaped}(?=$|\\s|:|—|–|-PLAN\\.md|\\.md|\\*\\*|\\))`,
'i'
).test(activeRegion);
return !stemPresent;
});
if (missingPlans.length > 0) {