refactor(query): extract command catalog seam for registry wiring (#3060)
* refactor(sdk): extract gsdtools transport seam with per-command policy * refactor(query): centralize registry command catalog wiring * refactor(query): unify command resolution seam across sdk callers * fix(sdk): address CodeRabbit transport policy and timeout findings * refactor(query): extract mutation event mapper seam * refactor(query): converge mutation and transport policy data * refactor(query): share fallback orchestration across cli and sdk * refactor(query): split static registry catalog by domain clusters * refactor(query): extract mutation event emission decorator seam * refactor(query): extract alias-family handler catalog module * refactor(query): extract cjs fallback execution adapter * refactor(query): deepen command semantics seam * refactor(query): extract deep dispatch seam * refactor(query): deepen cjs fallback execution seam * refactor(query): merge routing plan into dispatch seam * fix(query): address CodeRabbit review findings on PR #3060 Critical: prevent double-execution race by checking timeout errors before subprocess fallback (gsd-transport.ts). Major: fix execRaw() to respect transport policy outputMode instead of hardcoding 'raw' (gsd-tools.ts). Major: add explicit 30s timeout to subprocess fallback execution (query-fallback-executor.ts). Major: remove raw args from stderr banner to prevent secret leakage (query-fallback-executor.ts). Minor: ensure native text output has trailing newline for CLI parity (query-dispatch.ts). Update gsd-tools.test.ts to match new execRaw() behavior. * fix(tests): update CLI integration tests for catalog-based registration The refactoring moved handler registration from inline registry.register() calls to catalog-based registration (registerStaticCatalog/registerAliasCatalog). - gsd-sdk-query-registry-integration.test.cjs: collectRegisteredNames() now also scans catalog files for handler names registered via the new system. - bug-2492-context-coverage-gate.test.cjs: checks for catalog-based registration (DECISION_ROUTING_STATIC_CATALOG) instead of inline strings. - bug-2524-sdk-query-ws-flag.test.cjs: checks for dispatchNative callback pattern instead of direct registry.dispatch() call. * fix(query): address remaining CodeRabbit review findings - query-command-semantics.ts: guard stats/progress rewrite so option tokens (e.g. --pick) are not turned into subcommands, preserving the top-level handler dispatch. - query-dispatch.ts: formatOutput now skips --pick for text-format responses (matching CJS fallback behavior) and surfaces a proper error when extractField returns undefined instead of silently producing 'undefined'. - query-dispatch.ts: fix backwards error message — 'registered' is the restrictive policy that disables fallback, not enables it. - tests/bug-2492-context-coverage-gate.test.cjs: check VERIFY_DECISION_STATIC_CATALOG (the correct catalog for plan-gate handlers) instead of DECISION_ROUTING_STATIC_CATALOG. - tests/gsd-sdk-query-registry-integration.test.cjs: resolve catalog variable before loading entries so the drift guard checks each referenced catalog individually. * refactor(query): deepen registry assembly module with strict invariants - extract registry assembly into dedicated module - split build vs mutation decoration internals - add strict assembly invariants: 1) no duplicate keys 2) alias canonicals must have handlers 3) mutation commands must be registered 4) raw-output policy commands must be registered - slim query index to thin re-export seam - add focused registry assembly tests - update drift-guard tests to target new seam * test(query): add thin-seam coverage for query index re-exports * fix(query): return structured native dispatch errors + tighten decisions.parse guard - runQueryDispatch native path now catches adapter errors and returns QueryDispatchResult.error instead of throwing. - preserve legacy CLI exit contract by using code=1 for native dispatch failures. - strengthen bug-2492 guard: decisions.parse assertion now checks VERIFY_DECISION_STATIC_CATALOG OR explicit command token.
This commit is contained in:
98
sdk/src/query/command-static-catalog-foundation.ts
Normal file
98
sdk/src/query/command-static-catalog-foundation.ts
Normal file
@@ -0,0 +1,98 @@
|
||||
import type { QueryHandler } from './utils.js';
|
||||
import { generateSlug, currentTimestamp } from './utils.js';
|
||||
import { frontmatterGet } from './frontmatter.js';
|
||||
import { configGet, configPath, resolveModel } from './config-query.js';
|
||||
import { stateSnapshot } from './state.js';
|
||||
import { findPhase, phasePlanIndex } from './phase.js';
|
||||
import { planTaskStructure } from './plan-task-structure.js';
|
||||
import { requirementsExtractFromPlans } from './requirements-extract-from-plans.js';
|
||||
import { progressJson } from './progress.js';
|
||||
import { frontmatterSet, frontmatterMerge, frontmatterValidate } from './frontmatter-mutation.js';
|
||||
import { configSet, configSetModelProfile, configNewProject, configEnsureSection } from './config-mutation.js';
|
||||
import { commit, checkCommit } from './commit.js';
|
||||
import { templateFill, templateSelect } from './template.js';
|
||||
import { verifySummary, verifyPathExists } from './verify.js';
|
||||
import { decisionsParse } from './decisions.js';
|
||||
import { checkDecisionCoveragePlan, checkDecisionCoverageVerify } from './check-decision-coverage.js';
|
||||
import { checkConfigGates } from './config-gates.js';
|
||||
import { checkAutoMode } from './check-auto-mode.js';
|
||||
import { checkPhaseReady } from './phase-ready.js';
|
||||
import { routeNextAction } from './route-next-action.js';
|
||||
import { detectPhaseType } from './detect-phase-type.js';
|
||||
import { checkCompletion } from './check-completion.js';
|
||||
import { checkGates } from './check-gates.js';
|
||||
import { checkVerificationStatus } from './check-verification-status.js';
|
||||
import { checkShipReady } from './check-ship-ready.js';
|
||||
|
||||
export const FOUNDATION_STATIC_CATALOG: ReadonlyArray<readonly [string, QueryHandler]> = [
|
||||
['generate-slug', generateSlug],
|
||||
['current-timestamp', currentTimestamp],
|
||||
['frontmatter.get', frontmatterGet],
|
||||
['config-get', configGet],
|
||||
['config-path', configPath],
|
||||
['resolve-model', resolveModel],
|
||||
] as const;
|
||||
|
||||
export const STATE_SUPPORT_STATIC_CATALOG: ReadonlyArray<readonly [string, QueryHandler]> = [
|
||||
['state-snapshot', stateSnapshot],
|
||||
['find-phase', findPhase],
|
||||
['phase-plan-index', phasePlanIndex],
|
||||
['plan.task-structure', planTaskStructure],
|
||||
['plan task-structure', planTaskStructure],
|
||||
['requirements.extract-from-plans', requirementsExtractFromPlans],
|
||||
['requirements extract-from-plans', requirementsExtractFromPlans],
|
||||
] as const;
|
||||
|
||||
export const MUTATION_SURFACES_STATIC_CATALOG: ReadonlyArray<readonly [string, QueryHandler]> = [
|
||||
['progress', progressJson],
|
||||
['progress.json', progressJson],
|
||||
['frontmatter.set', frontmatterSet],
|
||||
['frontmatter.merge', frontmatterMerge],
|
||||
['frontmatter.validate', frontmatterValidate],
|
||||
['frontmatter validate', frontmatterValidate],
|
||||
['config-set', configSet],
|
||||
['config-set-model-profile', configSetModelProfile],
|
||||
['config-new-project', configNewProject],
|
||||
['config-ensure-section', configEnsureSection],
|
||||
['commit', commit],
|
||||
['check-commit', checkCommit],
|
||||
['template.fill', templateFill],
|
||||
['template.select', templateSelect],
|
||||
['template select', templateSelect],
|
||||
] as const;
|
||||
|
||||
export const VERIFY_DECISION_STATIC_CATALOG: ReadonlyArray<readonly [string, QueryHandler]> = [
|
||||
['verify-summary', verifySummary],
|
||||
['verify.summary', verifySummary],
|
||||
['verify summary', verifySummary],
|
||||
['verify-path-exists', verifyPathExists],
|
||||
['verify.path-exists', verifyPathExists],
|
||||
['verify path-exists', verifyPathExists],
|
||||
['decisions.parse', decisionsParse],
|
||||
['decisions parse', decisionsParse],
|
||||
['check.decision-coverage-plan', checkDecisionCoveragePlan],
|
||||
['check decision-coverage-plan', checkDecisionCoveragePlan],
|
||||
['check.decision-coverage-verify', checkDecisionCoverageVerify],
|
||||
['check decision-coverage-verify', checkDecisionCoverageVerify],
|
||||
] as const;
|
||||
|
||||
export const DECISION_ROUTING_STATIC_CATALOG: ReadonlyArray<readonly [string, QueryHandler]> = [
|
||||
['check.config-gates', checkConfigGates],
|
||||
['check config-gates', checkConfigGates],
|
||||
['check.auto-mode', checkAutoMode],
|
||||
['check auto-mode', checkAutoMode],
|
||||
['check.phase-ready', checkPhaseReady],
|
||||
['check phase-ready', checkPhaseReady],
|
||||
['route.next-action', routeNextAction],
|
||||
['route next-action', routeNextAction],
|
||||
['detect.phase-type', detectPhaseType],
|
||||
['detect phase-type', detectPhaseType],
|
||||
['check.completion', checkCompletion],
|
||||
['check completion', checkCompletion],
|
||||
['check.gates', checkGates],
|
||||
['check gates', checkGates],
|
||||
['check.verification-status', checkVerificationStatus],
|
||||
['check verification-status', checkVerificationStatus],
|
||||
['check.ship-ready', checkShipReady],
|
||||
['check ship-ready', checkShipReady],
|
||||
] as const;
|
||||
Reference in New Issue
Block a user