From 5aaf0dbea50d3e2752f37f116d347fc4fa8a3677 Mon Sep 17 00:00:00 2001
From: Tom Boucher <trekkie@nomorestars.com>
Date: Mon, 4 May 2026 20:22:58 -0400
Subject: [PATCH] refactor: reduce query error factory public surface

---
 sdk/src/query-tools-error-factory.test.ts | 10 ++++------
 sdk/src/query-tools-error-factory.ts      |  4 ++--
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/sdk/src/query-tools-error-factory.test.ts b/sdk/src/query-tools-error-factory.test.ts
index 84f63a058..616d592c2 100644
--- a/sdk/src/query-tools-error-factory.test.ts
+++ b/sdk/src/query-tools-error-factory.test.ts
@@ -3,17 +3,15 @@ import { ErrorClassification, GSDError } from './errors.js';
 import {
   createQueryNativeErrorFactory,
   createQueryToolsErrorFactory,
-  failureToolsError,
-  timeoutToolsError,
   toToolsErrorFromUnknown,
 } from './query-tools-error-factory.js';
 
 describe('query tools error factory', () => {
-  it('builds timeout and failure tools errors', () => {
-    expect(timeoutToolsError('t', 'state', ['load'], '', 10).classification).toEqual({ kind: 'timeout', timeoutMs: 10 });
-    expect(failureToolsError('f', 'state', ['load'], 1).classification).toEqual({ kind: 'failure' });
+  it('builds timeout and failure tools errors via seam factories', () => {
+    const toolsFactory = createQueryToolsErrorFactory();
+    expect(toolsFactory.createTimeoutError('t', 'state', ['load'], '', 10).classification).toEqual({ kind: 'timeout', timeoutMs: 10 });
+    expect(toolsFactory.createFailureError('f', 'state', ['load'], 1, '').classification).toEqual({ kind: 'failure' });
   });
-
   it('maps GSDError to failure with semantic exit code', () => {
     const err = toToolsErrorFromUnknown('state', ['load'], new GSDError('bad', ErrorClassification.Validation));
     expect(err.exitCode).toBe(10);
diff --git a/sdk/src/query-tools-error-factory.ts b/sdk/src/query-tools-error-factory.ts
index f427cf170..cb008ffa5 100644
--- a/sdk/src/query-tools-error-factory.ts
+++ b/sdk/src/query-tools-error-factory.ts
@@ -29,11 +29,11 @@ export interface QueryNativeErrorFactory {
   createNativeFailureError: (message: string, command: string, args: string[], cause: unknown) => GSDToolsError;
 }
 
-export function timeoutToolsError(message: string, command: string, args: string[], stderr = '', timeoutMs?: number): GSDToolsError {
+function timeoutToolsError(message: string, command: string, args: string[], stderr = '', timeoutMs?: number): GSDToolsError {
   return GSDToolsError.timeout(message, command, args, stderr, timeoutMs);
 }
 
-export function failureToolsError(
+function failureToolsError(
   message: string,
   command: string,
   args: string[],