Deepen query dispatch seam with Command Topology Module (#3078)

* Deepen query dispatch seam with command topology module

* Stabilize SDK parity defaults and integration test gating

* docs(architecture): record pre-project config policy and e2e gate

* refactor(query): stop injecting native adapter in CLI dispatch path

* fix(config): align workflow auto-chain typing and docs
This commit is contained in:
Tom Boucher
2026-05-03 18:11:38 -04:00
committed by GitHub
parent 9c92c32f6e
commit 5e21bf7567
27 changed files with 260 additions and 121 deletions

View File

@@ -6,7 +6,6 @@
*/
import { readFile } from 'node:fs/promises';
import { homedir } from 'node:os';
import { join } from 'node:path';
import { relPlanningPath } from './workstream-utils.js';
@@ -27,6 +26,8 @@ export interface WorkflowConfig {
/** Mirrors gsd-tools flat `config.tdd_mode` (from `workflow.tdd_mode`). */
tdd_mode: boolean;
auto_advance: boolean;
/** Internal auto-chain flag used by workflow routing. */
_auto_chain_active?: boolean;
node_repair: boolean;
node_repair_budget: number;
ui_phase: boolean;
@@ -68,8 +69,6 @@ export interface GSDConfig {
project_code?: string | null;
/** Interactive vs headless; mirrors gsd-tools flat `config.mode`. */
mode?: string;
/** Internal auto-chain flag; mirrors gsd-tools `config._auto_chain_active`. */
_auto_chain_active?: boolean;
[key: string]: unknown;
}
@@ -107,6 +106,7 @@ export const CONFIG_DEFAULTS: GSDConfig = {
max_discuss_passes: 3,
subagent_timeout: 300000,
context_coverage_gate: true,
_auto_chain_active: false,
},
hooks: {
context_warnings: true,
@@ -114,44 +114,16 @@ export const CONFIG_DEFAULTS: GSDConfig = {
agent_skills: {},
project_code: null,
mode: 'interactive',
_auto_chain_active: false,
};
// ─── Loader ──────────────────────────────────────────────────────────────────
/**
* Load project config from `.planning/config.json`, merging with defaults.
* When project config is missing or empty, layers user defaults
* (`~/.gsd/defaults.json`) over built-in defaults.
* When project config is missing or empty, this returns `mergeDefaults({})`
* (built-in defaults only; no `~/.gsd/defaults.json` layering).
* Throws on malformed JSON with a helpful error message.
*/
/**
* Read user-level defaults from `~/.gsd/defaults.json` (or `$GSD_HOME/.gsd/`
* when set). Returns `{}` when the file is missing, empty, or malformed —
* matches CJS behavior in `get-shit-done/bin/lib/core.cjs` (#1683, #2652).
*/
async function loadUserDefaults(): Promise<Record<string, unknown>> {
const home = process.env.GSD_HOME || homedir();
const defaultsPath = join(home, '.gsd', 'defaults.json');
let raw: string;
try {
raw = await readFile(defaultsPath, 'utf-8');
} catch {
return {};
}
const trimmed = raw.trim();
if (trimmed === '') return {};
try {
const parsed = JSON.parse(trimmed);
if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed)) {
return {};
}
return parsed as Record<string, unknown>;
} catch {
return {};
}
}
export async function loadConfig(projectDir: string, workstream?: string): Promise<GSDConfig> {
const configPath = join(projectDir, relPlanningPath(workstream), 'config.json');
const rootConfigPath = join(projectDir, '.planning', 'config.json');
@@ -175,22 +147,16 @@ export async function loadConfig(projectDir: string, workstream?: string): Promi
}
}
// Pre-project context: no .planning/config.json exists. Layer user-level
// defaults from ~/.gsd/defaults.json over built-in defaults. Mirrors the
// CJS fall-back branch in get-shit-done/bin/lib/core.cjs:421 (#1683) so
// SDK-dispatched init queries (e.g. resolveModel in Codex installs, #2652)
// honor user-level knobs like `resolve_model_ids: "omit"`.
// Pre-project context: no .planning/config.json exists.
// Use built-in defaults only so SDK query parity stays stable across machines.
if (!projectConfigFound) {
const userDefaults = await loadUserDefaults();
return mergeDefaults(userDefaults);
return mergeDefaults({});
}
const trimmed = raw.trim();
if (trimmed === '') {
// Empty project config — treat as no project config (CJS core.cjs
// catches JSON.parse on empty and falls through to the pre-project path).
const userDefaults = await loadUserDefaults();
return mergeDefaults(userDefaults);
// Empty project config — treat as no project config.
return mergeDefaults({});
}
let parsed: Record<string, unknown>;