fix: recover silently-excluded test dirs + test-architecture audit hardening (#1195)
* fix: recurse test discovery so subdir test suites actually run
scripts/run-tests.cjs discovered tests with a flat readdirSync(testDir),
silently excluding tests/observability/ (4 files), tests/dispatch/ (1) and
tests/installer-migrations/ (1) — 94 passing tests — from `npm test` and all
CI lanes. Walk the tree recursively (relative subpaths preserved), classify
suites by basename, and add a fail-on-zero-executed guard for suite/default
runs (escape hatch GSD_ALLOW_EMPTY_SUITE=1) while preserving the empty
--files/--files-from path the CI inert lane relies on.
Unit suite 735 -> 741 files; surfaces ADR-227's observability/dispatch seam.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: retire 5 verified-worthless tests
Adversarial verification confirmed these 5 prove nothing — their coverage is
provided more strictly elsewhere:
- enh-2790 'has a name: field' spot-checks (command-contract enforces /^gsd[:-]/)
- command-routing-hub duplicate construct + duplicate ERROR_KINDS assertions
- no-cjs-sdk-handsync-tooling (guarded files that never existed on main; bug-190
covers the real retired SDK artifacts)
- runtime-artifact-layout cline edge case (subsumed by the explicit-global test
and bug-782-cline-skills-emission)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: add ADR-218 release version-validation coverage
ADR-218 (reject leading-zero versions like 1.01.0; npm duplicate pre-check) had
zero tests — the logic lived only in release.yml bash. Add a test that extracts
the actual rejection regexes from the workflow and exercises them against a
boundary table (leading-zero/malformed rejected, valid accepted) plus structural
wiring assertions. Goes red if the regex is reverted to [0-9]+.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: redesign weak tests into behavioral, deterministic assertions
Per the ADR test audit, rewrite 27 weak test files (test-only, no source
changes) so each can go red for the defect it guards:
- kill pass-always assert.ok(true) placeholders (research-cli, worktree-baseref,
bug-260 security guard, eslint-rules x24, clusters '|| true')
- replace source-text grep with behavioral calls (install Kilo, sh-hook-paths,
plan-review-convergence) and add a repo-layout governance test
- de-flake real-clock/Math.random coupling (phase last_updated, bug-3707 mtime,
context-utilization property, feat-3594)
- fix independence/shared-state violations (bug-492 singleton, issue-844 tmpRoot,
core reapStaleTempFiles, active-workstream TTY, feat-488 GSD_HOME)
- strengthen property/shape-only tests (research-provider/store classification +
collision) and unconditional plugin.json schema validation (issue-766)
Verified: all 28 files run together 1220 pass / 0 fail / 1 skip.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore: add no-tautological-assert lint rule, error in test suite
New custom ESLint rule (eslint-rules/no-tautological-assert.cjs) bans asserts
that can never fail: assert(true)/assert.ok(<always-truthy literal>),
'cond || true' inside an assert, and equality asserts comparing two identical
literals. Wired as error on tests/**; full sweep confirmed zero existing
violations so the suite stays green. Prevents the placeholder-assert regressions
the audit redesigns just removed. RuleTester coverage added (6 valid, 8 invalid).
Note: no-only-tests was already enforced via eslint-plugin-no-only-tests, so no
duplicate rule was added.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore: gate new allow-test-rule exemptions to require an issue ref
ADR-456 requires any allow-test-rule exemption added after the ADR to carry a
tracking issue number, but nothing enforced it. New ratchet gate
(scripts/lint-allow-test-rule-refs.cjs, wired into lint:ci) fails when a NEW
allow-test-rule comment lacks a #NNN/URL reference; the 323 existing untracked
exemptions are grandfathered in an allowlist that ratchets down as they gain
refs. Red-green verified (novel untracked offender fails; compliant passes).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* docs: add ADR test-audit evidence report (#1192)
Full risk-first qa-test-architect audit of the ADR portfolio (37 ADRs + 4
platform lenses, adversarial verification of retire verdicts) that drove the
P0 discovery fix, ADR-218 coverage, 5 retires, 27 redesigns, and the two new
lint gates. Filed as point-in-time evidence under docs/issueevidence/, named
for tracking issue #1192.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: replace pre-existing raw NUL byte with escape in feat-3594 fixture
feat-3594's null-byte parser fixture contained a literal NUL byte (pre-existing
on next at b10e5681 — confirmed: base blob has 1 NUL, this fix has 0), which
made git treat the file as binary and would break grep/editors. Switch to the
\x00 escape; the runtime string value (a real NUL in the parser input) is
unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: address adversarial-review findings
Codex adversarial pass over the branch:
- capability-registry drift test no longer mutates the committed generated
capability-registry.cjs in place (concurrency hazard) — uses in-memory
checkPipeline comparison instead.
- allow-test-rule ratchet now detects exemptions in ALL comment forms (block
/* */ too, matching no-source-grep) so a block comment can't bypass it;
one newly-surfaced pre-existing offender grandfathered (323->324).
- install.test Kilo case asserts on what install(false,'kilo') actually writes
rather than manually calling configureKiloPermissions (masked the call site).
- issue-766 drops the undeclared transitive ajv dep for explicit structural
assertions from the schema fixture.
- adr-218 test notes the hotfix leading-zero gap is tracked in #1186.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: address code-review findings (subdir discovery, rule + test gaps)
xhigh code review surfaced 15 confirmed issues, all fixed:
- run-tests.cjs --files now resolves subdir tests by bare basename + handles
Windows backslash paths (ambiguous basenames error clearly).
- affected-tests-lib.cjs listTestFiles made recursive — the targeted CI lane was
silently dropping changed subdir tests (same false-green class the audit fixed).
- no-tautological-assert now catches 'true || cond' and empty []/{} equality.
- verify-test-quality: restore provenance-classification coverage, tighten the
writeFile circular-detection check, guard the module-level file read.
- sh-hook-paths: cover the global-install .sh delegation branch (#2045 guard).
- active-workstream null-guard runs deterministically (no longer skipped on TTY).
- adr-218 structural guards tightened (major/minor leading-zero; needs: membership).
- repo-layout AGENTS.md guard no longer false-alarms on equivalent refactors.
- cross-ai ordering guard fails red when the step is missing.
- issue-766 parses required fields from the schema fixture (auto-enforced).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test: stub USERPROFILE alongside HOME in feat-488 (Windows parity)
The feat-488 redesign stubbed process.env.HOME but not USERPROFILE; os.homedir()
resolves from USERPROFILE on Windows, so the home stub was not hermetic there —
caught by windows-test-parity-guard (stubsHomeNoUserProfile). Save/set/restore
USERPROFILE symmetrically with HOME (delete-if-originally-undefined).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore: reconcile allow-test-rule allowlist after rebase onto next
Rebasing onto current next pulled in merged PR #1170, which added
inventory-headings-countfree.test.cjs (a baseline allow-test-rule exemption) and
deleted inventory-counts.test.cjs. Grandfather the former and prune the latter so
the ratchet matches the merged tree. No new debt from this PR.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -21,7 +21,7 @@
|
||||
'use strict';
|
||||
|
||||
const { readdirSync } = require('fs');
|
||||
const { join } = require('path');
|
||||
const { join, basename } = require('path');
|
||||
const { execFileSync } = require('child_process');
|
||||
const { ExitError, runMain } = require('./lib/cli-exit.cjs');
|
||||
|
||||
@@ -112,6 +112,21 @@ function ensureBuiltArtifacts(overrides = {}) {
|
||||
}
|
||||
const MARKED_SUITES = ['integration', 'install', 'security', 'slow'];
|
||||
|
||||
// Recursively collect *.test.cjs files under dir, returning paths relative to dir.
|
||||
// Skips node_modules to avoid accidentally picking up decoy files.
|
||||
function walkTestFiles(dir, relBase) {
|
||||
const results = [];
|
||||
for (const entry of readdirSync(dir, { withFileTypes: true })) {
|
||||
if (entry.isDirectory()) {
|
||||
if (entry.name === 'node_modules') continue;
|
||||
results.push(...walkTestFiles(join(dir, entry.name), relBase ? `${relBase}/${entry.name}` : entry.name));
|
||||
} else if (entry.name.endsWith('.test.cjs')) {
|
||||
results.push(relBase ? `${relBase}/${entry.name}` : entry.name);
|
||||
}
|
||||
}
|
||||
return results;
|
||||
}
|
||||
|
||||
function parseArgs(argv) {
|
||||
let suite = null;
|
||||
let seen = false;
|
||||
@@ -188,9 +203,12 @@ function parseArgs(argv) {
|
||||
// Return the marked suite name embedded in a filename, or null if it's unmarked.
|
||||
// foo.security.test.cjs -> "security"
|
||||
// foo.test.cjs -> null (unit)
|
||||
// Accepts either a bare filename or a relative subdir path; classification is
|
||||
// based on the basename only so subdir paths classify identically to root files.
|
||||
function suiteOf(filename) {
|
||||
if (!filename.endsWith('.test.cjs')) return null;
|
||||
const base = filename.slice(0, -'.test.cjs'.length);
|
||||
const name = basename(filename);
|
||||
if (!name.endsWith('.test.cjs')) return null;
|
||||
const base = name.slice(0, -'.test.cjs'.length);
|
||||
const lastDot = base.lastIndexOf('.');
|
||||
if (lastDot === -1) return null;
|
||||
const marker = base.slice(lastDot + 1);
|
||||
@@ -213,7 +231,8 @@ function splitFileList(value) {
|
||||
.split(/[,\s]+/)
|
||||
.map(v => v.trim())
|
||||
.filter(Boolean)
|
||||
.map(v => v.replace(/^tests[\\/]/, ''));
|
||||
.map(v => v.replace(/\\/g, '/')) // normalize Windows backslashes
|
||||
.map(v => v.replace(/^tests\//, ''));
|
||||
}
|
||||
|
||||
function selectExplicitFiles(allFiles, filesValue, filesFrom) {
|
||||
@@ -222,8 +241,19 @@ function selectExplicitFiles(allFiles, filesValue, filesFrom) {
|
||||
? splitFileList(fs.readFileSync(filesFrom, 'utf8'))
|
||||
: splitFileList(filesValue);
|
||||
const available = new Set(allFiles);
|
||||
|
||||
// Build a basename -> [relpath, ...] index for bare-basename resolution.
|
||||
// A bare basename (no directory separator) may match exactly one subdir file.
|
||||
const basenameIndex = new Map();
|
||||
for (const f of allFiles) {
|
||||
const b = basename(f);
|
||||
if (!basenameIndex.has(b)) basenameIndex.set(b, []);
|
||||
basenameIndex.get(b).push(f);
|
||||
}
|
||||
|
||||
const selected = [];
|
||||
const missing = [];
|
||||
const errors = [];
|
||||
for (const file of requested) {
|
||||
// If the token is a bare suite name (e.g. "unit" written by ci-test-scope
|
||||
// as the #408 fallback sentinel), delegate to the existing suite resolver
|
||||
@@ -234,11 +264,27 @@ function selectExplicitFiles(allFiles, filesValue, filesFrom) {
|
||||
selected.push(f);
|
||||
}
|
||||
} else if (available.has(file)) {
|
||||
// Exact relpath match (e.g. "installer-migrations/001-legacy-orphan-files.test.cjs").
|
||||
selected.push(file);
|
||||
} else if (!file.includes('/')) {
|
||||
// Bare basename (no directory separator): resolve via index.
|
||||
const candidates = basenameIndex.get(file);
|
||||
if (!candidates || candidates.length === 0) {
|
||||
missing.push(file);
|
||||
} else if (candidates.length > 1) {
|
||||
errors.push(
|
||||
`ambiguous basename "${file}" matches multiple files: ${candidates.join(', ')} — pass the subdir path instead`,
|
||||
);
|
||||
} else {
|
||||
selected.push(candidates[0]);
|
||||
}
|
||||
} else {
|
||||
missing.push(file);
|
||||
}
|
||||
}
|
||||
if (errors.length > 0) {
|
||||
return { error: errors.join('; ') };
|
||||
}
|
||||
if (missing.length > 0) {
|
||||
return {
|
||||
error: `requested test file(s) not found: ${missing.join(', ')}`,
|
||||
@@ -266,17 +312,16 @@ function main() {
|
||||
? process.env.GSD_TEST_DIR
|
||||
: join(__dirname, '..', 'tests');
|
||||
|
||||
const allFiles = readdirSync(testDir)
|
||||
.filter(f => f.endsWith('.test.cjs'))
|
||||
.sort();
|
||||
const allFiles = walkTestFiles(testDir, '').sort();
|
||||
|
||||
if (allFiles.length === 0) {
|
||||
console.error(`No test files found in ${testDir}`);
|
||||
throw new ExitError(1);
|
||||
}
|
||||
|
||||
const usingExplicitFiles = parsed.files !== null || parsed.filesFrom !== null;
|
||||
let selectedNames;
|
||||
if (parsed.files !== null || parsed.filesFrom !== null) {
|
||||
if (usingExplicitFiles) {
|
||||
const explicit = selectExplicitFiles(allFiles, parsed.files, parsed.filesFrom);
|
||||
if (explicit.error) {
|
||||
console.error(`run-tests: ${explicit.error}`);
|
||||
@@ -289,11 +334,20 @@ function main() {
|
||||
const selected = selectedNames.map(f => join(testDir, f));
|
||||
|
||||
if (selected.length === 0) {
|
||||
// Empty suite: report and exit 0 so empty lanes (e.g. `security` before
|
||||
// adversarial tests land) don't gate CI. CI consumers wanting strictness
|
||||
// can grep stderr for "no tests in suite".
|
||||
console.error(`run-tests: no tests in suite "${suite || 'all'}"`);
|
||||
return 0;
|
||||
if (usingExplicitFiles) {
|
||||
// Empty file list from --files/--files-from: allowed (e.g. CI passes an
|
||||
// empty .ci-selected-tests.txt on docs-only/inert PRs). Exit 0 silently.
|
||||
console.error(`run-tests: no tests in suite "${suite || 'all'}"`);
|
||||
return 0;
|
||||
}
|
||||
// Empty suite/default run: this means discovery or the suite filter is broken.
|
||||
// Allow GSD_ALLOW_EMPTY_SUITE=1 as an escape hatch (downgrades to a warning).
|
||||
if (process.env.GSD_ALLOW_EMPTY_SUITE === '1') {
|
||||
console.error(`run-tests: WARNING: 0 test files selected for suite "${suite || 'all'}" — discovery or suite filter may be broken (GSD_ALLOW_EMPTY_SUITE=1 suppressed the error)`);
|
||||
return 0;
|
||||
}
|
||||
console.error(`run-tests: ERROR: 0 test files selected for suite "${suite || 'all'}" — discovery or suite filter is broken`);
|
||||
throw new ExitError(1);
|
||||
}
|
||||
|
||||
// Build the gitignored bin/lib artifact if absent, before any test requires it.
|
||||
|
||||
Reference in New Issue
Block a user