fix: recover silently-excluded test dirs + test-architecture audit hardening (#1195)

* fix: recurse test discovery so subdir test suites actually run

scripts/run-tests.cjs discovered tests with a flat readdirSync(testDir),
silently excluding tests/observability/ (4 files), tests/dispatch/ (1) and
tests/installer-migrations/ (1) — 94 passing tests — from `npm test` and all
CI lanes. Walk the tree recursively (relative subpaths preserved), classify
suites by basename, and add a fail-on-zero-executed guard for suite/default
runs (escape hatch GSD_ALLOW_EMPTY_SUITE=1) while preserving the empty
--files/--files-from path the CI inert lane relies on.

Unit suite 735 -> 741 files; surfaces ADR-227's observability/dispatch seam.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: retire 5 verified-worthless tests

Adversarial verification confirmed these 5 prove nothing — their coverage is
provided more strictly elsewhere:
- enh-2790 'has a name: field' spot-checks (command-contract enforces /^gsd[:-]/)
- command-routing-hub duplicate construct + duplicate ERROR_KINDS assertions
- no-cjs-sdk-handsync-tooling (guarded files that never existed on main; bug-190
  covers the real retired SDK artifacts)
- runtime-artifact-layout cline edge case (subsumed by the explicit-global test
  and bug-782-cline-skills-emission)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: add ADR-218 release version-validation coverage

ADR-218 (reject leading-zero versions like 1.01.0; npm duplicate pre-check) had
zero tests — the logic lived only in release.yml bash. Add a test that extracts
the actual rejection regexes from the workflow and exercises them against a
boundary table (leading-zero/malformed rejected, valid accepted) plus structural
wiring assertions. Goes red if the regex is reverted to [0-9]+.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: redesign weak tests into behavioral, deterministic assertions

Per the ADR test audit, rewrite 27 weak test files (test-only, no source
changes) so each can go red for the defect it guards:
- kill pass-always assert.ok(true) placeholders (research-cli, worktree-baseref,
  bug-260 security guard, eslint-rules x24, clusters '|| true')
- replace source-text grep with behavioral calls (install Kilo, sh-hook-paths,
  plan-review-convergence) and add a repo-layout governance test
- de-flake real-clock/Math.random coupling (phase last_updated, bug-3707 mtime,
  context-utilization property, feat-3594)
- fix independence/shared-state violations (bug-492 singleton, issue-844 tmpRoot,
  core reapStaleTempFiles, active-workstream TTY, feat-488 GSD_HOME)
- strengthen property/shape-only tests (research-provider/store classification +
  collision) and unconditional plugin.json schema validation (issue-766)

Verified: all 28 files run together 1220 pass / 0 fail / 1 skip.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: add no-tautological-assert lint rule, error in test suite

New custom ESLint rule (eslint-rules/no-tautological-assert.cjs) bans asserts
that can never fail: assert(true)/assert.ok(<always-truthy literal>),
'cond || true' inside an assert, and equality asserts comparing two identical
literals. Wired as error on tests/**; full sweep confirmed zero existing
violations so the suite stays green. Prevents the placeholder-assert regressions
the audit redesigns just removed. RuleTester coverage added (6 valid, 8 invalid).

Note: no-only-tests was already enforced via eslint-plugin-no-only-tests, so no
duplicate rule was added.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: gate new allow-test-rule exemptions to require an issue ref

ADR-456 requires any allow-test-rule exemption added after the ADR to carry a
tracking issue number, but nothing enforced it. New ratchet gate
(scripts/lint-allow-test-rule-refs.cjs, wired into lint:ci) fails when a NEW
allow-test-rule comment lacks a #NNN/URL reference; the 323 existing untracked
exemptions are grandfathered in an allowlist that ratchets down as they gain
refs. Red-green verified (novel untracked offender fails; compliant passes).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs: add ADR test-audit evidence report (#1192)

Full risk-first qa-test-architect audit of the ADR portfolio (37 ADRs + 4
platform lenses, adversarial verification of retire verdicts) that drove the
P0 discovery fix, ADR-218 coverage, 5 retires, 27 redesigns, and the two new
lint gates. Filed as point-in-time evidence under docs/issueevidence/, named
for tracking issue #1192.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: replace pre-existing raw NUL byte with escape in feat-3594 fixture

feat-3594's null-byte parser fixture contained a literal NUL byte (pre-existing
on next at b10e5681 — confirmed: base blob has 1 NUL, this fix has 0), which
made git treat the file as binary and would break grep/editors. Switch to the
\x00 escape; the runtime string value (a real NUL in the parser input) is
unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: address adversarial-review findings

Codex adversarial pass over the branch:
- capability-registry drift test no longer mutates the committed generated
  capability-registry.cjs in place (concurrency hazard) — uses in-memory
  checkPipeline comparison instead.
- allow-test-rule ratchet now detects exemptions in ALL comment forms (block
  /* */ too, matching no-source-grep) so a block comment can't bypass it;
  one newly-surfaced pre-existing offender grandfathered (323->324).
- install.test Kilo case asserts on what install(false,'kilo') actually writes
  rather than manually calling configureKiloPermissions (masked the call site).
- issue-766 drops the undeclared transitive ajv dep for explicit structural
  assertions from the schema fixture.
- adr-218 test notes the hotfix leading-zero gap is tracked in #1186.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: address code-review findings (subdir discovery, rule + test gaps)

xhigh code review surfaced 15 confirmed issues, all fixed:
- run-tests.cjs --files now resolves subdir tests by bare basename + handles
  Windows backslash paths (ambiguous basenames error clearly).
- affected-tests-lib.cjs listTestFiles made recursive — the targeted CI lane was
  silently dropping changed subdir tests (same false-green class the audit fixed).
- no-tautological-assert now catches 'true || cond' and empty []/{}  equality.
- verify-test-quality: restore provenance-classification coverage, tighten the
  writeFile circular-detection check, guard the module-level file read.
- sh-hook-paths: cover the global-install .sh delegation branch (#2045 guard).
- active-workstream null-guard runs deterministically (no longer skipped on TTY).
- adr-218 structural guards tightened (major/minor leading-zero; needs: membership).
- repo-layout AGENTS.md guard no longer false-alarms on equivalent refactors.
- cross-ai ordering guard fails red when the step is missing.
- issue-766 parses required fields from the schema fixture (auto-enforced).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: stub USERPROFILE alongside HOME in feat-488 (Windows parity)

The feat-488 redesign stubbed process.env.HOME but not USERPROFILE; os.homedir()
resolves from USERPROFILE on Windows, so the home stub was not hermetic there —
caught by windows-test-parity-guard (stubsHomeNoUserProfile). Save/set/restore
USERPROFILE symmetrically with HOME (delete-if-originally-undefined).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: reconcile allow-test-rule allowlist after rebase onto next

Rebasing onto current next pulled in merged PR #1170, which added
inventory-headings-countfree.test.cjs (a baseline allow-test-rule exemption) and
deleted inventory-counts.test.cjs. Grandfather the former and prune the latter so
the ratchet matches the merged tree. No new debt from this PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

tests/core.test.cjs

@@ -1830,51 +1830,88 @@ describe('findProjectRoot', () => {
 });
 
 // ─── reapStaleTempFiles ─────────────────────────────────────────────────────
+//
+// Isolation strategy: reapStaleTempFiles always scans the shared GSD_TEMP_DIR
+// (os.tmpdir()/gsd) and has no { dir } option, so we cannot redirect it to a
+// per-test directory. Instead we isolate via a per-test unique prefix that
+// embeds a random hex token, guaranteeing no two concurrent test workers can
+// share the same prefix. Each test records every path it creates in `created`
+// and afterEach removes them unconditionally so a failed assertion cannot leak
+// files into a sibling test's prefix scan.
 
 describe('reapStaleTempFiles', () => {
   const gsdTmpDir = path.join(os.tmpdir(), 'gsd');
 
-  test('removes stale gsd-*.json files older than maxAgeMs', () => {
+  // Unique token per describe-run so parallel test files never collide.
+  const runToken = Math.random().toString(36).slice(2, 10);
+
+  /** Paths created by the current test; cleaned up in afterEach. */
+  let created = [];
+  /** Per-test prefix derived from runToken + sequential counter. */
+  let testPrefix;
+  let testCounter = 0;
+
+  beforeEach(() => {
+    created = [];
+    testCounter += 1;
+    testPrefix = `gsd-core-reap-${runToken}-${testCounter}-`;
     fs.mkdirSync(gsdTmpDir, { recursive: true });
-    const stalePath = path.join(gsdTmpDir, `gsd-reap-test-${Date.now()}.json`);
+  });
+
+  afterEach(() => {
+    for (const p of created) {
+      try {
+        // eslint-disable-next-line local/no-raw-rmsync-in-tests -- afterEach cleanup of per-test fixture paths tracked in `created`
+        fs.rmSync(p, { recursive: true, force: true });
+      } catch {
+        // Best-effort: already removed by the SUT or a prior cleanup
+      }
+    }
+    created = [];
+  });
+
+  test('removes stale gsd-*.json files older than maxAgeMs', () => {
+    const stalePath = path.join(gsdTmpDir, `${testPrefix}stale.json`);
     fs.writeFileSync(stalePath, '{}');
-    // Set mtime to 10 minutes ago
+    created.push(stalePath); // guard against assertion failure leaking the file
+    // Set mtime to 10 minutes ago so it exceeds the 5-minute maxAgeMs
     const oldTime = new Date(Date.now() - 10 * 60 * 1000);
     fs.utimesSync(stalePath, oldTime, oldTime);
 
-    reapStaleTempFiles('gsd-reap-test-', { maxAgeMs: 5 * 60 * 1000 });
+    reapStaleTempFiles(testPrefix, { maxAgeMs: 5 * 60 * 1000 });
 
-    assert.ok(!fs.existsSync(stalePath), 'stale file should be removed');
+    assert.ok(!fs.existsSync(stalePath), 'stale file should be removed by reapStaleTempFiles');
   });
 
-  test('preserves fresh gsd-*.json files', () => {
-    fs.mkdirSync(gsdTmpDir, { recursive: true });
-    const freshPath = path.join(gsdTmpDir, `gsd-reap-fresh-${Date.now()}.json`);
+  test('preserves fresh gsd-*.json files within maxAgeMs', () => {
+    const freshPath = path.join(gsdTmpDir, `${testPrefix}fresh.json`);
     fs.writeFileSync(freshPath, '{}');
+    created.push(freshPath); // afterEach will clean up regardless of assertion outcome
 
-    reapStaleTempFiles('gsd-reap-fresh-', { maxAgeMs: 5 * 60 * 1000 });
+    reapStaleTempFiles(testPrefix, { maxAgeMs: 5 * 60 * 1000 });
 
-    assert.ok(fs.existsSync(freshPath), 'fresh file should be preserved');
-    // Clean up
-    fs.unlinkSync(freshPath);
+    assert.ok(fs.existsSync(freshPath), 'fresh file should be preserved by reapStaleTempFiles');
   });
 
   test('removes stale temp directories when present', () => {
-    fs.mkdirSync(gsdTmpDir, { recursive: true });
-    const staleDir = fs.mkdtempSync(path.join(gsdTmpDir, 'gsd-reap-dir-'));
+    const staleDir = path.join(gsdTmpDir, `${testPrefix}dir`);
+    fs.mkdirSync(staleDir, { recursive: true });
     fs.writeFileSync(path.join(staleDir, 'data.jsonl'), 'test');
-    // Set mtime to 10 minutes ago
+    created.push(staleDir); // guard against assertion failure leaking the dir
+    // Set mtime to 10 minutes ago so it exceeds the 5-minute maxAgeMs
     const oldTime = new Date(Date.now() - 10 * 60 * 1000);
     fs.utimesSync(staleDir, oldTime, oldTime);
 
-    reapStaleTempFiles('gsd-reap-dir-', { maxAgeMs: 5 * 60 * 1000 });
+    reapStaleTempFiles(testPrefix, { maxAgeMs: 5 * 60 * 1000 });
 
-    assert.ok(!fs.existsSync(staleDir), 'stale directory should be removed');
+    assert.ok(!fs.existsSync(staleDir), 'stale directory should be removed by reapStaleTempFiles');
   });
 
-  test('does not throw on empty or missing prefix matches', () => {
+  test('does not throw when no entries match the prefix', () => {
+    // Use a prefix that is guaranteed to match nothing (unique nonce appended)
+    const absentPrefix = `gsd-core-reap-absent-${runToken}-`;
     assert.doesNotThrow(() => {
-      reapStaleTempFiles('gsd-nonexistent-prefix-xyz-', { maxAgeMs: 0 });
+      reapStaleTempFiles(absentPrefix, { maxAgeMs: 0 });
     });
   });
 });