golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: recover silently-excluded test dirs + test-architecture audit hardening (#1195)

Browse Source 
* fix: recurse test discovery so subdir test suites actually run

scripts/run-tests.cjs discovered tests with a flat readdirSync(testDir),
silently excluding tests/observability/ (4 files), tests/dispatch/ (1) and
tests/installer-migrations/ (1) — 94 passing tests — from `npm test` and all
CI lanes. Walk the tree recursively (relative subpaths preserved), classify
suites by basename, and add a fail-on-zero-executed guard for suite/default
runs (escape hatch GSD_ALLOW_EMPTY_SUITE=1) while preserving the empty
--files/--files-from path the CI inert lane relies on.

Unit suite 735 -> 741 files; surfaces ADR-227's observability/dispatch seam.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: retire 5 verified-worthless tests

Adversarial verification confirmed these 5 prove nothing — their coverage is
provided more strictly elsewhere:
- enh-2790 'has a name: field' spot-checks (command-contract enforces /^gsd[:-]/)
- command-routing-hub duplicate construct + duplicate ERROR_KINDS assertions
- no-cjs-sdk-handsync-tooling (guarded files that never existed on main; bug-190
  covers the real retired SDK artifacts)
- runtime-artifact-layout cline edge case (subsumed by the explicit-global test
  and bug-782-cline-skills-emission)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: add ADR-218 release version-validation coverage

ADR-218 (reject leading-zero versions like 1.01.0; npm duplicate pre-check) had
zero tests — the logic lived only in release.yml bash. Add a test that extracts
the actual rejection regexes from the workflow and exercises them against a
boundary table (leading-zero/malformed rejected, valid accepted) plus structural
wiring assertions. Goes red if the regex is reverted to [0-9]+.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: redesign weak tests into behavioral, deterministic assertions

Per the ADR test audit, rewrite 27 weak test files (test-only, no source
changes) so each can go red for the defect it guards:
- kill pass-always assert.ok(true) placeholders (research-cli, worktree-baseref,
  bug-260 security guard, eslint-rules x24, clusters '|| true')
- replace source-text grep with behavioral calls (install Kilo, sh-hook-paths,
  plan-review-convergence) and add a repo-layout governance test
- de-flake real-clock/Math.random coupling (phase last_updated, bug-3707 mtime,
  context-utilization property, feat-3594)
- fix independence/shared-state violations (bug-492 singleton, issue-844 tmpRoot,
  core reapStaleTempFiles, active-workstream TTY, feat-488 GSD_HOME)
- strengthen property/shape-only tests (research-provider/store classification +
  collision) and unconditional plugin.json schema validation (issue-766)

Verified: all 28 files run together 1220 pass / 0 fail / 1 skip.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: add no-tautological-assert lint rule, error in test suite

New custom ESLint rule (eslint-rules/no-tautological-assert.cjs) bans asserts
that can never fail: assert(true)/assert.ok(<always-truthy literal>),
'cond || true' inside an assert, and equality asserts comparing two identical
literals. Wired as error on tests/**; full sweep confirmed zero existing
violations so the suite stays green. Prevents the placeholder-assert regressions
the audit redesigns just removed. RuleTester coverage added (6 valid, 8 invalid).

Note: no-only-tests was already enforced via eslint-plugin-no-only-tests, so no
duplicate rule was added.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: gate new allow-test-rule exemptions to require an issue ref

ADR-456 requires any allow-test-rule exemption added after the ADR to carry a
tracking issue number, but nothing enforced it. New ratchet gate
(scripts/lint-allow-test-rule-refs.cjs, wired into lint:ci) fails when a NEW
allow-test-rule comment lacks a #NNN/URL reference; the 323 existing untracked
exemptions are grandfathered in an allowlist that ratchets down as they gain
refs. Red-green verified (novel untracked offender fails; compliant passes).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs: add ADR test-audit evidence report (#1192)

Full risk-first qa-test-architect audit of the ADR portfolio (37 ADRs + 4
platform lenses, adversarial verification of retire verdicts) that drove the
P0 discovery fix, ADR-218 coverage, 5 retires, 27 redesigns, and the two new
lint gates. Filed as point-in-time evidence under docs/issueevidence/, named
for tracking issue #1192.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: replace pre-existing raw NUL byte with escape in feat-3594 fixture

feat-3594's null-byte parser fixture contained a literal NUL byte (pre-existing
on next at b10e5681 — confirmed: base blob has 1 NUL, this fix has 0), which
made git treat the file as binary and would break grep/editors. Switch to the
\x00 escape; the runtime string value (a real NUL in the parser input) is
unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: address adversarial-review findings

Codex adversarial pass over the branch:
- capability-registry drift test no longer mutates the committed generated
  capability-registry.cjs in place (concurrency hazard) — uses in-memory
  checkPipeline comparison instead.
- allow-test-rule ratchet now detects exemptions in ALL comment forms (block
  /* */ too, matching no-source-grep) so a block comment can't bypass it;
  one newly-surfaced pre-existing offender grandfathered (323->324).
- install.test Kilo case asserts on what install(false,'kilo') actually writes
  rather than manually calling configureKiloPermissions (masked the call site).
- issue-766 drops the undeclared transitive ajv dep for explicit structural
  assertions from the schema fixture.
- adr-218 test notes the hotfix leading-zero gap is tracked in #1186.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: address code-review findings (subdir discovery, rule + test gaps)

xhigh code review surfaced 15 confirmed issues, all fixed:
- run-tests.cjs --files now resolves subdir tests by bare basename + handles
  Windows backslash paths (ambiguous basenames error clearly).
- affected-tests-lib.cjs listTestFiles made recursive — the targeted CI lane was
  silently dropping changed subdir tests (same false-green class the audit fixed).
- no-tautological-assert now catches 'true || cond' and empty []/{}  equality.
- verify-test-quality: restore provenance-classification coverage, tighten the
  writeFile circular-detection check, guard the module-level file read.
- sh-hook-paths: cover the global-install .sh delegation branch (#2045 guard).
- active-workstream null-guard runs deterministically (no longer skipped on TTY).
- adr-218 structural guards tightened (major/minor leading-zero; needs: membership).
- repo-layout AGENTS.md guard no longer false-alarms on equivalent refactors.
- cross-ai ordering guard fails red when the step is missing.
- issue-766 parses required fields from the schema fixture (auto-enforced).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* test: stub USERPROFILE alongside HOME in feat-488 (Windows parity)

The feat-488 redesign stubbed process.env.HOME but not USERPROFILE; os.homedir()
resolves from USERPROFILE on Windows, so the home stub was not hermetic there —
caught by windows-test-parity-guard (stubsHomeNoUserProfile). Save/set/restore
USERPROFILE symmetrically with HOME (delete-if-originally-undefined).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: reconcile allow-test-rule allowlist after rebase onto next

Rebasing onto current next pulled in merged PR #1170, which added
inventory-headings-countfree.test.cjs (a baseline allow-test-rule exemption) and
deleted inventory-counts.test.cjs. Grandfather the former and prune the latter so
the ratchet matches the merged tree. No new debt from this PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-13 23:35:08 -04:00
committed by GitHub
parent 3ebd13c45d
commit 5fa4dcd78c
44 changed files with 3958 additions and 757 deletions
Download Patch File Download Diff File Expand all files Collapse all files

127
tests/install.test.cjs
View File

@@ -670,8 +670,9 @@ describe('configureKiloPermissions', () => {
});
});
describe('Kilo source integration assertions', () => {
const src = fs.readFileSync(path.join(__dirname, '..', 'bin', 'install.js'), 'utf8');
describe('Kilo integration — install/uninstall behaviour', () => {
// Product-text reads for test 6 only — update.md and update-context.cjs
// are deployed artifacts whose text IS the runtime contract (allow-test-rule).
const updateWorkflowSrc = fs.readFileSync(
path.join(__dirname, '..', 'gsd-core', 'workflows', 'update.md'), 'utf8');
// #498: update.md's runtime/scope/config-dir resolution moved into the tested
@@ -680,8 +681,32 @@ describe('Kilo source integration assertions', () => {
const updateContextSrc = fs.readFileSync(
path.join(__dirname, '..', 'gsd-core', 'bin', 'lib', 'update-context.cjs'), 'utf8');
test('--kilo flag parsing exists', () => {
assert.ok(src.includes("runtimeArgs.includes('--kilo')"));
let tmpDir;
let previousCwd;
let savedKiloConfigDir;
beforeEach(() => {
tmpDir = createTempDir('gsd-kilo-integration-');
previousCwd = process.cwd();
process.chdir(tmpDir);
savedKiloConfigDir = process.env.KILO_CONFIG_DIR;
// Point KILO_CONFIG_DIR at the install target so configureKiloPermissions
// and uninstall resolve to the same dir without needing the real ~/.config/kilo.
process.env.KILO_CONFIG_DIR = path.join(tmpDir, '.kilo');
});
afterEach(() => {
process.chdir(previousCwd);
if (savedKiloConfigDir !== undefined) process.env.KILO_CONFIG_DIR = savedKiloConfigDir;
else delete process.env.KILO_CONFIG_DIR;
cleanup(tmpDir);
});
test('--kilo flag routes to kilo runtime via selectRuntimesFromArgs', () => {
// Behavioural replacement for source-grep on runtimeArgs.includes('--kilo').
// The flag must produce ['kilo'] — a rename or deletion of the flag branch
// would make this go red.
assert.deepStrictEqual(selectRuntimesFromArgs(['--kilo']), ['kilo']);
});
test('runtimeMap has Kilo as option 12 after Kimi', () => {
@@ -695,12 +720,98 @@ describe('Kilo source integration assertions', () => {
assert.ok(!plain.includes('the #1 AI coding platform on OpenRouter'));
});
test('finishInstall passes the actual config dir to Kilo permissions', () => {
assert.ok(src.includes('configureKiloPermissions(isGlobal, configDir);'));
test('install() for kilo writes artifacts to the configDir it returns', () => {
// Behavioural replacement for source-grep on the kilo install branch.
//
// IMPORTANT: GSD_TEST_MODE=1 (set at the top of this file) suppresses the
// configureKiloPermissions() call inside install() to avoid mutating the real
// ~/.config/kilo during unit tests. Asserting on kilo.json permissions here
// would require manually calling configureKiloPermissions(), which only tests
// that helper — not install()'s wiring of it.
//
// Instead we assert on what install() ITSELF produces on disk, which is the
// correct target:
// 1. The returned configDir exists and is the KILO_CONFIG_DIR we set.
// 2. install() wrote kilo artifacts (skills/, agents/) into that dir.
// 3. The configDir returned by install() matches what resolveKiloConfigPath
// resolves for the same env, proving the dir-resolution path is correct.
//
// If someone breaks the kilo install branch (wrong configDir, wrong skill
// target, removed case) these assertions go red immediately.
const result = install(false, 'kilo');
const configDir = result.configDir;
// (1) install() returned the expected configDir (respects KILO_CONFIG_DIR env).
assert.strictEqual(
result.runtime,
'kilo',
'install() must return runtime: "kilo"',
);
assert.ok(
fs.existsSync(configDir),
`install() must create the configDir it returns: ${configDir}`,
);
// (2) Kilo-specific artifacts were written by install() into configDir.
const skillsDir = path.join(configDir, 'skills');
assert.ok(
fs.existsSync(skillsDir),
`install() must create skills/ under the kilo configDir: ${skillsDir}`,
);
const agentsDir = path.join(configDir, 'agents');
assert.ok(
fs.existsSync(agentsDir),
`install() must create agents/ under the kilo configDir: ${agentsDir}`,
);
// (3) The configDir is consistent with resolveKiloConfigPath, proving the
// path-resolution wiring between install() and configureKiloPermissions is
// stable: both read from the same env (KILO_CONFIG_DIR).
const kiloConfigPath = resolveKiloConfigPath(configDir);
assert.ok(
typeof kiloConfigPath === 'string' && kiloConfigPath.length > 0,
`resolveKiloConfigPath must return a valid path for configDir: ${configDir}`,
);
assert.ok(
kiloConfigPath.startsWith(configDir),
`resolveKiloConfigPath must return a path inside the install configDir.\n` +
`Expected prefix: ${configDir}\n` +
`Got: ${kiloConfigPath}`,
);
});
test('uninstall cleans Kilo permissions from the resolved target dir', () => {
assert.ok(src.includes('const configPath = resolveKiloConfigPath(targetDir);'));
test('uninstall removes GSD permissions from the resolved kilo config path', () => {
// Behavioural replacement for source-grep on
// "const configPath = resolveKiloConfigPath(targetDir)".
// The contract: after install + configureKiloPermissions, an uninstall must
// strip the GSD permission entries from kilo.json at the resolved path.
const result = install(false, 'kilo');
const configDir = result.configDir;
configureKiloPermissions(true, configDir);
const kiloJsonPath = resolveKiloConfigPath(configDir);
const beforeConfig = JSON.parse(fs.readFileSync(kiloJsonPath, 'utf8'));
const gsdGlob = `${configDir.replace(/\\/g, '/')}/gsd-core/*`;
assert.ok(
beforeConfig.permission.read[gsdGlob] === 'allow',
'pre-condition: GSD read permission must exist before uninstall',
);
uninstall(false, 'kilo');
// After uninstall the GSD permission keys must be absent. The file may
// still exist (Kilo preserves user settings) but the gsd-core/* entries
// must be gone.
const afterConfig = JSON.parse(fs.readFileSync(kiloJsonPath, 'utf8'));
assert.ok(
!(afterConfig.permission && afterConfig.permission.read && afterConfig.permission.read[gsdGlob]),
`GSD read permission must be removed from ${kiloJsonPath} after uninstall`,
);
assert.ok(
!(afterConfig.permission && afterConfig.permission.external_directory &&
afterConfig.permission.external_directory[gsdGlob]),
`GSD external_directory permission must be removed from ${kiloJsonPath} after uninstall`,
);
});
test('update workflow checks preferred custom config dirs', () => {