golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(#2808): SKILL.md files use hyphen name form (gsd-cmd not gsd:cmd) (#2819)

Browse Source 
* fix(#2808): SKILL.md name uses hyphen form for Claude Code autocomplete

skillFrontmatterName() was converting gsd-<cmd> to gsd:<cmd> (colon) so
installed SKILL.md files had name: gsd:add-phase etc. Claude Code surfaces
this name in autocomplete, showing the deprecated colon form to users even
though the hyphen form is canonical everywhere else.

Root cause: the colon form was needed because workflows called
Skill(skill="gsd:<cmd>"). All 4 remaining colon-form Skill() calls in
autonomous.md and execute-phase.md are updated to hyphen form.

skillFrontmatterName() now returns the hyphen dir name unchanged.
Updated 4 existing tests that asserted colon form.

Regression test: tests/bug-2808-skill-hyphen-name.test.cjs

* fix(#2808): address CodeRabbit — bash/text fences, structured test assertions, fail-loud on errors
This commit is contained in:
Tom Boucher
2026-04-28 20:22:37 -04:00
committed by GitHub
parent fa78692167
commit 5fe1f00a0d
7 changed files with 196 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
get-shit-done/workflows/autonomous.md
View File

@@ -262,7 +262,7 @@ The discuss step in `--auto` mode MUST NOT loop. If CONTEXT.md already exists af
**If `INTERACTIVE` is set:** Run the standard discuss-phase skill inline (asks interactive questions, waits for user answers). This preserves user input on all design decisions while keeping plan+execute out of the main context:
```
Skill(skill="gsd:discuss-phase", args="${PHASE_NUM}")
Skill(skill="gsd-discuss-phase", args="${PHASE_NUM}")
```
**If `INTERACTIVE` is NOT set:** Execute the smart_discuss step for this phase (batch table proposals, auto-optimized).
@@ -367,12 +367,12 @@ CODE_REVIEW_ENABLED=$(gsd-sdk query config-get workflow.code_review 2>/dev/null
If `"false"`: display "Code review skipped (workflow.code_review=false)" and proceed to 3d.
```
Skill(skill="gsd:code-review", args="${PHASE_NUM}")
Skill(skill="gsd-code-review", args="${PHASE_NUM}")
```
Parse status from REVIEW.md frontmatter. If "clean" or "skipped": proceed to 3d. If findings found: auto-invoke:
```
Skill(skill="gsd:code-review-fix", args="${PHASE_NUM} --auto")
```text
Skill(skill="gsd-code-review-fix", args="${PHASE_NUM} --auto")
```
**Error handling:** If either Skill fails, catch the error, display as non-blocking, and proceed to 3d.

2
get-shit-done/workflows/execute-phase.md
View File

@@ -1095,7 +1095,7 @@ If `CODE_REVIEW_ENABLED` is `"false"`: display "Code review skipped (workflow.co
**Invoke review:**
```
Skill(skill="gsd:code-review", args="${PHASE_NUMBER}")
Skill(skill="gsd-code-review", args="${PHASE_NUMBER}")
```
**Check results using deterministic path (not glob):**