refactor: replace try/finally with beforeEach/afterEach + add CONTRIBUTING.md
Test suite modernization: - Converted all try/finally cleanup patterns to beforeEach/afterEach hooks across 11 test files (core, copilot-install, config, workstream, milestone-summary, forensics, state, antigravity, profile-pipeline, workspace) - Consolidated 40 inline mkdtempSync calls to use centralized helpers - Added createTempDir() helper for bare temp directories - Added optional prefix parameter to createTempProject/createTempGitProject - Fixed config test HOME sandboxing (was reading global defaults.json) New CONTRIBUTING.md: - Test standards: hooks over try/finally, centralized helpers, HOME sandboxing - Node 22/24 compatibility requirements with Node 26 forward-compat - Code style, PR guidelines, security practices - File structure overview All 1382 tests pass, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -149,27 +149,34 @@ describe('state-snapshot command', () => {
|
||||
assert.strictEqual(output.paused_at, 'Phase 3, Plan 1, Task 2 - mid-implementation', 'paused_at extracted');
|
||||
});
|
||||
|
||||
test('supports --cwd override when command runs outside project root', () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'STATE.md'),
|
||||
`# Session State
|
||||
describe('--cwd override', () => {
|
||||
let outsideDir;
|
||||
|
||||
beforeEach(() => {
|
||||
outsideDir = fs.mkdtempSync(path.join(require('os').tmpdir(), 'gsd-test-outside-'));
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup(outsideDir);
|
||||
});
|
||||
|
||||
test('supports --cwd override when command runs outside project root', () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'STATE.md'),
|
||||
`# Session State
|
||||
|
||||
**Current Phase:** 03
|
||||
**Status:** Ready to plan
|
||||
`
|
||||
);
|
||||
const outsideDir = fs.mkdtempSync(path.join(require('os').tmpdir(), 'gsd-test-outside-'));
|
||||
);
|
||||
|
||||
try {
|
||||
const result = runGsdTools(`state-snapshot --cwd "${tmpDir}"`, outsideDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
|
||||
const output = JSON.parse(result.output);
|
||||
assert.strictEqual(output.current_phase, '03', 'should read STATE.md from overridden cwd');
|
||||
assert.strictEqual(output.status, 'Ready to plan', 'should parse status from overridden cwd');
|
||||
} finally {
|
||||
cleanup(outsideDir);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
test('returns error for invalid --cwd path', () => {
|
||||
|
||||
Reference in New Issue
Block a user