golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(#4665): route --fix past the empty-scope exit (#4810)

Browse Source 
* test(#4665): add failing-first contract coverage for the --fix empty-scope recovery

* fix(#4665): route --fix past the empty-scope exit

check_empty_scope exited the entire workflow whenever REVIEW_FILES was
empty — before dispatch-fix — so with #3661's incremental scoping, a phase
whose only post-review changes were planning artifacts could never run
--fix against its standing REVIEW.md findings, and the skip output did not
even mention the flag.

The skip is now a self-contained guarded fence (explicit REVIEW_FILES
emptiness check): it fires only when --fix is absent OR the phase's
REVIEW.md does not exist. Otherwise the workflow proceeds directly to
dispatch-fix, which delegates to code-review-fix.md — the canonical fix
implementation that already documents handling an existing REVIEW.md —
while the fresh-review steps (structural pre-pass, reviewer lanes,
spawn_reviewer, commit_review) are skipped: nothing new to review, nothing
to commit. dispatch-fix.md's route docstring is synced.

Emitted-Drift-Ack-Growth: code-review.md — check_empty_scope gains the --fix recovery branch (#4665)

* docs(#4665): backfill changeset PR number

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-09-16 19:09:19 -04:00
committed by GitHub
parent 85545a77a5
commit 652796e903
4 changed files with 95 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gsd-core/workflows/code-review/steps/dispatch-fix.md
View File

@@ -2,9 +2,10 @@
If the `--fix` flag was passed (`FIX_FLAG=true`), delegate to the `code-review-fix.md` workflow
to auto-apply findings from the REVIEW.md that was just written (or that already existed).
This step runs AFTER `commit_review` so REVIEW.md is guaranteed to be on disk before the fixer
is invoked. If REVIEW.md was not created (agent failed, scope was empty, etc.), the `code-review-fix.md`
workflow handles the missing-review error and exits cleanly.
This step runs AFTER `commit_review` so a freshly-written REVIEW.md is guaranteed to be on disk
before the fixer is invoked. Since #4665 there is a second route: `check_empty_scope` jumps here
directly when the incremental scope is empty but `--fix` was passed and a REVIEW.md already exists
— `code-review-fix.md` resolves it from the phase and owns the missing-review error either way.
```bash
if [ "$FIX_FLAG" = "true" ]; then